refactor(shell): rewrite OpenClash installer workflow

Author: Aethersailor

.github/scripts/test_installers.sh

@@ -18,39 +18,26 @@ run_suite() (
     temporary=$(mktemp -d)
     trap 'rm -rf "$temporary"' EXIT HUP INT TERM
 
-    EXT=apk
-    metadata_file="$temporary/flat.json"
-    printf '%s\n' \
-        '[' \
-        '  {' \
-        '    "name": "/dev/luci-app-openclash-1.2.3.apk",' \
-        '    "hash": "YWJj",' \
-        '    "size": 123' \
-        '  }' \
-        ']' >"$metadata_file"
-    [ "$(parse_package_metadata "$metadata_file")" = \
-        'luci-app-openclash-1.2.3.apk|YWJj|123' ] ||
-        fail "$installer metadata parsing"
-
     version_file="$temporary/version"
     printf '%s\n' 'v0.47.999' >"$version_file"
     [ "$(parse_package_version "$version_file")" = '0.47.999' ] ||
         fail "$installer version parsing"
 
     attempts=''
-    attempt_count=0
     curl_download() {
-        attempt_count=$((attempt_count + 1))
         attempts="${attempts}${2}\n"
-        [ "$attempt_count" -eq 3 ]
+        case "$2" in
+            https://raw.example/*) return 0 ;;
+            *) return 1 ;;
+        esac
     }
     verify_package_file() {
         return 0
     }
     RAW_PACKAGE_PREFIX='https://raw.example/repository'
     JSDELIVR_PACKAGE_PREFIX='https://cdn.example/repository@'
     GH_PROXY_PREFIX='https://proxy.example/'
-    download_openclash_package deadbeef package.apk '' '' "$temporary/package.apk" ||
+    download_openclash_package deadbeef package.apk "$temporary/package.apk" ||
         fail "$installer download fallback"
     expected_attempts='https://cdn.example/repository@deadbeef/dev/package.apk
 https://proxy.example/https://raw.example/repository/deadbeef/dev/package.apk

py/sync_installer_common.py

@@ -1,5 +1,5 @@
 #!/usr/bin/env python3
-"""Keep shared installer helpers synchronized while publishing standalone scripts."""
+"""Synchronize shared helpers while keeping both public installers standalone."""
 
 from __future__ import annotations
 
@@ -13,9 +13,7 @@
 LIGHT_INSTALLER = ROOT / "shell" / "install_openclash_dev.sh"
 FULL_INSTALLER = ROOT / "shell" / "install_openclash_dev_update.sh"
 
-# The full installer is canonical for helpers whose behavior is intentionally
-# identical. The lightweight file embeds synchronized copies so its public
-# curl | sh entrypoint remains self-contained.
+# The full installer is canonical for every helper used by both entrypoints.
 SHARED_FUNCTIONS = {
     "print_line",
     "print_step",
@@ -24,32 +22,42 @@
     "log_error",
     "log_ok",
     "die",
+    "logo",
     "restore_feed",
+    "cleanup",
+    "init_runtime",
+    "detect_distribution",
     "detect_environment",
+    "select_feed_file",
+    "rewrite_feed_to_mirror",
+    "prepare_temporary_feed",
     "package_update",
     "package_install_dependencies",
-    "set_feed_file",
-    "enable_temporary_nju_mirror",
-    "fetch_package_metadata",
-    "parse_package_metadata",
+    "install_dependencies",
+    "check_required_commands",
+    "curl_download",
+    "fetch_package_refs_route",
+    "fetch_package_branch_sha",
+    "download_commit_file",
     "parse_package_version",
-    "resolve_package_metadata",
-    "verify_file_size",
-    "verify_sha256_base64",
+    "package_file_name",
+    "apk_supports_allow_downgrade",
     "verify_package_file",
-    "prepare_latest_package",
-    "install_openclash_package",
-    "extract_version_from_filename",
+    "download_openclash_package",
     "normalize_version",
+    "get_installed_version",
+    "install_openclash_package",
+    "preserve_failed_package",
+    "install_latest_openclash_package",
     "has_cpu_flag",
     "has_all_cpu_flags",
     "detect_mips_float",
     "detect_loongarch_abi",
+    "detect_core_arch",
     "get_effective_core_type",
-    "get_core_path",
-    "verify_core_version",
-    "update_core",
-    "start_openclash",
+    "configure_base_uci",
+    "run_core_update",
+    "enable_and_restart_openclash",
 }
 
 
@@ -85,10 +93,10 @@ def synchronized_light_content(light: str, full: str) -> str:
         raise ValueError(f"missing shared installer functions: {sorted(missing)}")
 
     replacements = sorted(
-        [
+        (
             (light_functions[name], full_functions[name].content)
             for name in SHARED_FUNCTIONS
-        ],
+        ),
         key=lambda item: item[0].start,
         reverse=True,
     )