fix: migrating to uuids

Author: 0xda157

fission/src/systems/preferences/PreferencesSystem.ts

@@ -1,3 +1,5 @@
+import DefaultInputs from "../input/DefaultInputs"
+import * as UUID from "uuid"
 import {
     defaultFieldPreferences,
     defaultGraphicsPreferences,
@@ -184,7 +186,32 @@ class PreferencesSystem {
 
             unmigratedKeys.forEach(key => {
                 const userPreferences = saved[USER_PREFERENCE_KEY] as Record<UserPreference, unknown>
-                userPreferences[key] = saved[key]
+
+                switch (key) {
+                    case "InputSchemes": {
+                        // migrate to uuids
+                        const defaultSchemes = DefaultInputs.defaultInputCopies
+                        userPreferences[key] = saved[key].map(scheme => {
+                            if (scheme.schemeId) return scheme
+
+                            if (scheme.customized) {
+                                scheme.schemeId = UUID.v4()
+                                return scheme
+                            }
+
+                            const matchingDefaultScheme =
+                                defaultSchemes.find(s => s.descriptiveName === scheme.descriptiveName) ??
+                                defaultSchemes.find(s => s.schemeName === scheme.schemeName)
+
+                            scheme.schemeId = matchingDefaultScheme?.schemeId ?? UUID.v4()
+
+                            return scheme
+                        })
+                        break
+                    }
+                    default:
+                        userPreferences[key] = saved[key]
+                }
 
                 delete saved[key]
             })

fission/src/test/InputSystem.test.ts

@@ -82,7 +82,7 @@ describe("Input Scheme Manager Checks", () => {
 
         const rebound = InputSystem.brainIndexSchemeMap.get(brainIndex)!
         expect(rebound).not.toBe(edited)
-        expect(rebound.schemeName).toBe(DefaultInputs.ernie().schemeName)
+        expect(rebound.schemeId).toBe(DefaultInputs.ernie().schemeId)
     })
 })
 

fission/src/ui/panels/configuring/assembly-config/interfaces/inputs/ConfigureSchemeInterface.tsx

@@ -1,5 +1,6 @@
 import { Divider, Stack } from "@mui/material"
 import type React from "react"
+import * as UUID from "uuid"
 import { useCallback, useEffect, useReducer, useRef, useState } from "react"
 import Checkbox from "@/components/Checkbox.tsx"
 import EventSystem from "@/systems/EventSystem.ts"
@@ -82,6 +83,8 @@ const ConfigureSchemeInterface: React.FC<ConfigSchemeProps> = ({ selectedScheme,
                         selectedScheme.usesTouchControls = false
                     }
                     selectedScheme.usesGamepad = val
+
+                    if (!selectedScheme.customized) selectedScheme.schemeId = UUID.v4()
                     selectedScheme.customized = true
                 }}
                 tooltip="Supported controllers: Xbox one, Xbox 360."
@@ -112,6 +115,7 @@ const ConfigureSchemeInterface: React.FC<ConfigSchemeProps> = ({ selectedScheme,
                             useGamepad={useGamepad}
                             useTouchControls={useTouchControls}
                             onInputChanged={() => {
+                                if (!selectedScheme.customized) selectedScheme.schemeId = UUID.v4()
                                 selectedScheme.customized = true
                             }}
                         />
@@ -124,6 +128,7 @@ const ConfigureSchemeInterface: React.FC<ConfigSchemeProps> = ({ selectedScheme,
                             .filter(val => !isNaN(val))
                         const newJointIndex = Math.max(0, ...existingJointIndexes) + 1
                         selectedScheme.inputs.push(AxisInput.unbound(`joint ${newJointIndex}`))
+                        if (!selectedScheme.customized) selectedScheme.schemeId = UUID.v4()
                         selectedScheme.customized = true
                         update()
                     }}