Skip to content

Commit 70bca71

Browse files
Avalonia 12 support (#44)
* fix!(Avalonia12): Avalonia 12 drops .net framework/net standard, only .net 8 and later are supported: https://docs.avaloniaui.net/docs/avalonia12-breaking-changes Updated demo project to use ReactiveUI.Avalonia instead of the deprecated Avalonia.ReactiveUI Avalonia.DiagnosticsSupport replaces Avalonia.Diagnostics * Migrate to single target framework, downgrade Avalonia version, adjust package dependencies --------- Co-authored-by: SKProCH <skproch@yandex.ru>
1 parent 33720a5 commit 70bca71

7 files changed

Lines changed: 19 additions & 20 deletions

File tree

AsyncImageLoader.Avalonia.Demo/App.axaml.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public override void OnFrameworkInitializationCompleted() {
1616
desktop.MainWindow = new MainWindow {
1717
DataContext = new MainWindowViewModel(),
1818
};
19-
desktop.MainWindow.AttachDevTools();
19+
this.AttachDeveloperTools();
2020
}
2121

2222
base.OnFrameworkInitializationCompleted();

AsyncImageLoader.Avalonia.Demo/AsyncImageLoader.Avalonia.Demo.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<TargetFramework>net8.0</TargetFramework>
55
<IsPackable>false</IsPackable>
66

7-
<AvaloniaVersion>11.3.2</AvaloniaVersion>
7+
<AvaloniaVersion>12.0.1</AvaloniaVersion>
88
</PropertyGroup>
99
<ItemGroup>
1010
<AvaloniaResource Include="Assets/avalonia-logo.ico" />
@@ -13,8 +13,8 @@
1313
<ItemGroup>
1414
<PackageReference Include="Avalonia.Desktop" />
1515
<PackageReference Include="Avalonia.Themes.Fluent" />
16-
<PackageReference Include="Avalonia.Diagnostics" />
17-
<PackageReference Include="Avalonia.ReactiveUI" />
16+
<PackageReference Include="AvaloniaUI.DiagnosticsSupport" />
17+
<PackageReference Include="ReactiveUI.Avalonia" />
1818
</ItemGroup>
1919
<ItemGroup>
2020
<ProjectReference Include="..\AsyncImageLoader.Avalonia\AsyncImageLoader.Avalonia.csproj" />

AsyncImageLoader.Avalonia.Demo/Controls/HamburgerMenu.axaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<ResourceDictionary xmlns="https://github.com/avaloniaui"
22
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
33
xmlns:controls="clr-namespace:AsyncImageLoader.Avalonia.Demo.Controls">
4-
<Design.PreviewWith>
4+
<!-- <Design.PreviewWith>
55
<Border Width="400"
66
Height="150">
77
<controls:HamburgerMenu>
@@ -18,7 +18,7 @@
1818
<TabItem Header="Item2" />
1919
</controls:HamburgerMenu>
2020
</Border>
21-
</Design.PreviewWith>
21+
</Design.PreviewWith> -->
2222

2323
<x:Double x:Key="PaneCompactWidth">40</x:Double>
2424
<x:Double x:Key="PaneExpandWidth">220</x:Double>
@@ -188,7 +188,7 @@
188188
</SplitView.Pane>
189189
<SplitView.Content>
190190
<DockPanel>
191-
<Border Height="{StaticResource HeaderHeight}" DockPanel.Dock="Top">
191+
<!-- <Border Height="{StaticResource HeaderHeight}" DockPanel.Dock="Top">
192192
<TextBlock x:Name="HeaderHolder"
193193
VerticalAlignment="Center"
194194
Classes="h1"
@@ -202,7 +202,7 @@
202202
</Transitions>
203203
</TextBlock.Transitions>
204204
</TextBlock>
205-
</Border>
205+
</Border> -->
206206
<Border x:Name="BackgroundBorder">
207207
<Border.Transitions>
208208
<Transitions>
@@ -252,10 +252,10 @@
252252
<Setter Property="PaneBackground" Value="{TemplateBinding PaneBackground}" />
253253
</Style>
254254
<Style Selector="^ /template/ SplitView[DisplayMode=Overlay]">
255-
<Setter Property="Background" Value="{Binding $parent[TabControl].ContentBackground}" />
255+
<Setter Property="Background" Value="{Binding $parent[controls:HamburgerMenu].ContentBackground}" />
256256
</Style>
257257
<Style Selector="^ /template/ SplitView[DisplayMode=Inline] Border#BackgroundBorder">
258-
<Setter Property="Background" Value="{Binding $parent[TabControl].ContentBackground}" />
258+
<Setter Property="Background" Value="{Binding $parent[controls:HamburgerMenu].ContentBackground}" />
259259
<Setter Property="BoxShadow" Value="{StaticResource NavigationContentShadow}" />
260260
</Style>
261261
<Style Selector="^ /template/ SplitView[DisplayMode=Inline][IsPaneOpen=True] Border#BackgroundBorder">

AsyncImageLoader.Avalonia.Demo/Program.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
using System;
22
using Avalonia;
33
using Avalonia.Controls.ApplicationLifetimes;
4-
using Avalonia.ReactiveUI;
4+
using ReactiveUI.Avalonia;
55

66
namespace AsyncImageLoader.Avalonia.Demo;
77

@@ -18,5 +18,5 @@ public static AppBuilder BuildAvaloniaApp()
1818
=> AppBuilder.Configure<App>()
1919
.UsePlatformDetect()
2020
.LogToTrace()
21-
.UseReactiveUI();
21+
.UseReactiveUI(rxui => { });
2222
}

AsyncImageLoader.Avalonia.Demo/Views/MainWindow.axaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ namespace AsyncImageLoader.Avalonia.Demo.Views;
77
public partial class MainWindow : Window {
88
public MainWindow() {
99
InitializeComponent();
10-
this.AttachDevTools();
1110
}
1211

1312
private void InitializeComponent() {

AsyncImageLoader.Avalonia/AsyncImageLoader.Avalonia.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
4+
<TargetFramework>net8.0</TargetFramework>
55
<RootNamespace>AsyncImageLoader</RootNamespace>
66

77
<Title>AsyncImageLoader.Avalonia</Title>

Directory.Packages.props

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<PropertyGroup>
33
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
44
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
5-
<AvaloniaVersion>11.1.0</AvaloniaVersion>
5+
<AvaloniaVersion>12.0.0</AvaloniaVersion>
66
</PropertyGroup>
77
<ItemGroup>
88
<PackageReference Include="Avalonia" />
@@ -11,9 +11,9 @@
1111
<PackageVersion Include="Avalonia" Version="$(AvaloniaVersion)" />
1212
<PackageVersion Include="Avalonia.Desktop" Version="$(AvaloniaVersion)" />
1313
<PackageVersion Include="Avalonia.Themes.Fluent" Version="$(AvaloniaVersion)" />
14-
<PackageVersion Include="Avalonia.Diagnostics" Version="$(AvaloniaVersion)" />
15-
<PackageVersion Include="Avalonia.ReactiveUI" Version="$(AvaloniaVersion)" />
14+
<PackageVersion Include="ReactiveUI.Avalonia" Version="11.4.12" />
1615
<!--For _build-->
17-
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
16+
<PackageVersion Include="AvaloniaUI.DiagnosticsSupport" Version="2.2.1" />
17+
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.102" />
1818
</ItemGroup>
19-
</Project>
19+
</Project>

0 commit comments

Comments
 (0)