Skip to content

Commit 4fa9736

Browse files
2-meancursoragent
andcommitted
docs: Gate 6 batch 8 close cleanup-status and record tombstones
Mark cleanup-status closed, expand removed-materials with Gate 6 removal inventory and post-Gate-6 debt, and point migration/plan docs at the closure. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 3442c0c commit 4fa9736

6 files changed

Lines changed: 52 additions & 23 deletions

File tree

MIGRATION.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
This guide tracks the staged migration from the historical `spectral_fl`
44
identity to the planned `graphfl_lab` identity. The migration is not complete
5-
yet; follow `docs/maintenance/cleanup-status.md` for current gate status.
5+
yet. Gate 6 hard cleanup is complete; see `docs/removed-materials.md` for
6+
tombstones and `docs/maintenance/cleanup-status.md` (closed) for the execution log.
67

78
## For Users
89

docs/framework/cleanup-plan.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ Stage risky renames: canonical name -> alias -> internal migration -> docs/confi
1414

1515
## Resumable Execution
1616

17-
Long-running cleanup/rename work is tracked in
18-
`docs/maintenance/cleanup-status.md`. Use that file for current gate state,
19-
unexpected findings, existing-plan mapping, and the next safe action.
17+
Gate 6 hard cleanup is complete. The execution log is in
18+
`docs/maintenance/cleanup-status.md` (**closed**). Removal tombstones and
19+
post-Gate-6 compatibility debt are in `docs/removed-materials.md`.
2020

2121
Gate checks run through:
2222

docs/maintenance/cleanup-status.md

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
11
# GraphFL Lab Cleanup Status
22

3-
This file is the source of truth for the staged cleanup/rename execution state.
4-
Git is the source of truth for code state; this file records intent,
5-
checkpoint status, and the next safe action. If Git state and this file
6-
disagree, rerun the relevant gate check and update this file from the result.
3+
**Status: closed** (Gate 6 hard cleanup complete on `main`, 2026-05-22).
4+
5+
This file recorded the staged cleanup/rename execution. Git remains the source of
6+
truth for code; long-term removal notes and tombstones live in
7+
[`docs/removed-materials.md`](../removed-materials.md). Rerun
8+
`python scripts/dev/run.py gate-check <gate>` only when reopening maintenance work.
79

810
## Current Status
911

1012
| Field | Value |
1113
|---|---|
12-
| current_gate | Gate 4c complete on `main`; Gate 6 batch 7 in progress on `main` |
13-
| status | PR #2 merged; nightly 26288800411 green; Gate 6 batches 2–7 landed; batch 8 (close status doc) and `general_*` CLI facades remain |
14+
| current_gate | Gate 6 complete (batches 2–7 on `main`; batch 8 doc closure) |
15+
| status | **closed**PR #2 merged; nightly 26288800411; Gate 6 batches 2–7 landed; CI green on batch 7 (`26290266011`) |
1416
| owner | codex |
1517
| started_at | 2026-05-21 |
16-
| last_verified | see `docs/maintenance/last_gate_check.json` |
17-
| next_step | Batch 8: mark `cleanup-status.md` closed, extend `removed-materials.md` tombstones; optional: remove root `general_*` CLI facades in a later batch if still listed in compatibility docs |
18+
| closed_at | 2026-05-22 |
19+
| last_verified | `docs/maintenance/last_gate_check.json` (5d-prep pass after batch 7) |
20+
| next_step | none for Gate 6; optional post-Gate-6 debt: `graphfl_lab/general_*` CLI facades (see `removed-materials.md`) |
1821

1922
Only one Gate branch should be active at a time. In short: use a single Gate branch.
2023
If parallel work is
@@ -275,6 +278,7 @@ result-schema contracts.
275278
| 2026-05-22 | Deleting only `spectral_fl/__init__.py` left an on-disk `spectral_fl/__pycache__` tree; Python 3 still exposed a namespace package and gate-check 3 flagged the tracked path until the directory was removed. | Delete the full `spectral_fl/` directory (not only `__init__.py`); assert `ModuleNotFoundError` after clearing `sys.modules`. |
276279
| 2026-05-22 | Gate 6 batch 7 pre-check: no `configs/**` files use `ours_spectral_filtered_*` or `spectral_filtered_*`; reporting still pairs legacy result variant tags via `reporting.py` prefixes. | Remove CLI `choices`/dual flags and suite `parse_target_variant` spectral branch; keep `config_io` JSON key alias, lifecycle/strategy input aliases, and report readers. |
277280
| 2026-05-22 | Gate 6 batch 7: public CLI listed `spectral_filtered_*` choices and dual `--spectral-filter-strength`; suite parser accepted `ours_spectral_filtered_*` launch tokens. | Drop argparse choices/flags and suite launch tokens; keep runtime aggregation aliases and `reporting.py` legacy result-tag pairing for historical artifacts. |
281+
| 2026-05-22 | Gate 6 batch 8: hard-removal checklist in `gate-6-prep.md` steps 1–7 complete; batch 8 is documentation closure only. | Mark this file `closed`; record Gate 6 tombstones in `docs/removed-materials.md`; leave `general_*` CLI facades as documented post-Gate-6 debt. |
278282

279283
## Gate 4c Local Readiness
280284

@@ -284,11 +288,11 @@ present: docs/maintenance/last_nightly_run.json (run 26288800411, success)
284288
present: scripts/dev/golden.py + tests/dev/test_golden.py + tests/golden/README.md
285289
local pass: python scripts/dev/run.py gate-check 4c
286290
local pass: python scripts/dev/run.py gate-check 5d-prep
287-
Gate 6 entry: pragmatic policy (4c + merge CI green; optional 1 more green before first deletion)
288-
Gate 6 hard removal: batches 2–7 done; batch 8 (doc closure) remains — see docs/maintenance/gate-6-prep.md
291+
Gate 6: batches 2–7 complete; batch 8 doc closure complete — see docs/removed-materials.md
289292
```
290293

291294
## Closure Policy
292295

293-
After Gate 6 completes, mark this file `closed`. Keep only a tombstone link from
294-
`docs/removed-materials.md`.
296+
This file is **closed**. Gate 6 hard cleanup (batches 2–7) and documentation
297+
closure (batch 8) are complete. Historical findings above are preserved for
298+
audit; active removal inventory is in `docs/removed-materials.md`.

docs/maintenance/gate-6-prep.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ replace with the recommended check above unless you explicitly want a week-long
3838
5. [x] Remove `graphfl_lab/strategies/spectral/` wrappers (keep real spectral math names in operators).
3939
6. [x] Remove `spectral_fl` package shim last, after grep shows no remaining imports outside tests explicitly checking deprecation.
4040
7. [x] Remove legacy CLI choices (`spectral_filtered_*` inputs) and old suite token spellings only after suite/history policy is frozen.
41-
8. Update `docs/maintenance/cleanup-status.md` to `closed` and link from `docs/removed-materials.md`.
41+
8. [x] Update `docs/maintenance/cleanup-status.md` to `closed` and link from `docs/removed-materials.md`.
4242

4343
## Verify After Each Batch
4444

docs/maintenance/last_gate_check.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
"gate": "5d-prep",
33
"pass": true,
44
"failed_checks": [],
5-
"verified_at": "2026-05-22T13:20:40.596332+00:00",
6-
"commit_sha": "ff62dd5850d7320b1b192ec3be9b8b382b75b092"
5+
"verified_at": "2026-05-22T13:25:49.091264+00:00",
6+
"commit_sha": "3442c0caf7e818d39bd2d6b5f36e68cc15f6df03"
77
}

docs/removed-materials.md

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,45 @@
11
# Removed Materials And Tombstones
22

33
This document records material removed or archived during the GraphFL Lab
4-
cleanup/rename. It is also the long-term pointer for closed maintenance
5-
documents after Gate 6.
4+
cleanup/rename. It is the long-term pointer for closed maintenance documents
5+
after Gate 6.
66

77
## Release Anchors
88

99
| Anchor | Status | Notes |
1010
|---|---|---|
1111
| `pre-graphfl-rename` | created | SHA `e647da931bb3a78cc228ac2ad31103537b5ed640`; Gate 0 workspace baseline before Gate 1 inventory. |
1212

13+
## Gate 6 Hard Cleanup (2026-05-22)
14+
15+
Execution log (findings and decisions): [`docs/maintenance/cleanup-status.md`](maintenance/cleanup-status.md) (**closed**).
16+
17+
| Removed surface | Batch | Replacement / policy |
18+
|---|---|---|
19+
| `general_suite_*` / `result_general_*` artifact **writers** | 2 | New runs emit `vision_suite_*` / `result_vision_*` only; readers still resolve legacy paths |
20+
| `run_general_*` root entrypoints | 3 | `run_vision_*` |
21+
| `plot_general_convergence.py`, `merge_general_fedavg_ours.py`, `deep_dive_general.py` | 3 | `plot_vision_convergence.py` and vision-named analysis helpers |
22+
| `graphfl_lab/experiments/general/`, `graphfl_lab/experiments/suites/general/` | 4 | `graphfl_lab/experiments/vision/`, `suites/vision/` |
23+
| `graphfl_lab/strategies/spectral/` import facades | 5 | `graphfl_lab/strategies/graphfl/` |
24+
| `spectral_fl/` package shim | 6 | `graphfl_lab`; scan pickles via `scripts/dev/migrate_serialized_objects.py` |
25+
| CLI `spectral_filtered_*` argparse choices; `--spectral-filter-strength` flag | 7 | `graph_filtered_*` choices; `--graph-filter-strength`; JSON key alias `spectral_filter_strength` retained in `config_io` |
26+
| Suite launch tokens `ours_spectral_filtered_*` | 7 | `ours_graph_filtered_*`; legacy result tags still paired in `reporting.py` |
27+
28+
## Post-Gate-6 Compatibility Debt (intentional)
29+
30+
| Surface | Status | Notes |
31+
|---|---|---|
32+
| `graphfl_lab/general_*`, `graphfl_lab/cli/general_*` | retained | thin CLI/import facades; not part of Gate 6 batch 2–7 |
33+
| `general_suite_*` / `result_general_*` artifact **readers** | retained | historical experiment directories |
34+
| Runtime `spectral_filtered_*` aggregation **input** aliases | retained | lifecycle/strategy accept legacy target strings |
35+
| `spectral_filter_strength` in traces / JSON config keys | retained | maps to `graph_filter_strength` |
36+
1337
## Tombstones
1438

1539
| Path or material | Status | Replacement |
1640
|---|---|---|
17-
| `spectral_fl/__init__.py` (package shim) | removed Gate 6 batch 6 | `graphfl_lab` canonical imports; serialized assets scanned via `scripts/dev/migrate_serialized_objects.py` |
18-
| `docs/maintenance/cleanup-status.md` | active until Gate 6 | After Gate 6, mark closed and link from this table. |
41+
| `docs/maintenance/cleanup-status.md` | **closed** Gate 6 batch 8 | This file + git history; use `gate-check` when reopening maintenance |
42+
| `spectral_fl/__init__.py` (package shim) | removed Gate 6 batch 6 | `graphfl_lab` canonical imports |
1943
| `docs/framework/experimental-design.md` | removed duplicate bridge | `docs/framework/graph_fl_experimental_design.md`, `docs/framework/graph_fl_experimental_design_appendix.md` |
2044

2145
## Archive Policy

0 commit comments

Comments
 (0)