Skip to content

Commit 67057a0

Browse files
GitHub Workshop Botclaude
andcommitted
docs: correct remaining chapter/challenge drift found in the full-curriculum sweep
Chapter 10 (Notifications) claimed a required "Chapter 10 challenge issue" and counted it toward "eleven Day 1 challenges," but no such core challenge exists - the real hook is the optional Bonus D, which unlocks after Challenge 15. Reroute its evidence and Day 1 close-out reflection to the actual Challenge 9 (Merge Day) issue, and correct the Day 1 count to nine. Chapter 15 Part 1 (VS Code PR extension) told students to close a "Chapter 12" issue, but Part 1 is prep practice with no issue of its own - the real Challenge 12 evidence is already correctly handled later in Part 2. Chapter 4's bonus-challenge summary described five topics that don't match any of the actual Bonus A-E templates; replaced with accurate one-line summaries of each. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent c8754b4 commit 67057a0

7 files changed

Lines changed: 59 additions & 62 deletions

docs/04-the-learning-room.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ Each challenge lists the file(s) to edit, estimated time, skills practiced, and
344344

345345
### Bonus Challenges
346346

347-
Five bonus challenges (A through E) are available for students who finish faster. These include an accessibility audit, mentoring a peer, cross-repository contribution, creating a custom workflow, and documentation improvement.
347+
Five bonus challenges (A through E) unlock after Challenge 15 for students who finish faster: improving an existing agent and opening a PR (A), writing a reflection on your workshop journey (B), designing a collaborative challenge for future cohorts (C), configuring GitHub notifications (D), and exploring repository history visually with GitHub Desktop (E).
348348

349349
## How PR Sharing Works
350350

docs/10-notifications-and-day-1-close.md

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
1414
## Workshop Recommendation (Chapter 10)
1515

16-
For this workshop, Chapter 10 is a **guided practice chapter**, not a graded automation chapter.
16+
Chapter 10 is a **guided practice chapter** with no required Day 1 challenge issue of its own. The walkthrough below corresponds to the optional **Bonus D: Notification Mastery** issue, which unlocks after Challenge 15 (Day 2). You can read this chapter and try the walkthrough today, but you do not need a challenge issue to do so, and you do not need to wait for Bonus D to unlock to practice it.
1717

18-
- **Challenge count:** 1 guided walkthrough
18+
- **Challenge count:** 0 required (optional Bonus D covers this topic later)
1919
- **Automation check:** none - notification settings are account-level and cannot be validated by the Learning Room PR bot
20-
- **Evidence:** structured completion comment on your assigned challenge issue
20+
- **Evidence:** if you want credit now, note what you tried in a comment on your current challenge issue; formal evidence is submitted on the Bonus D issue once it unlocks
2121
- **Pattern:** configure, filter, act
2222

2323
### Important Note: This Challenge Uses GitHub's Web Notification Inbox
@@ -39,11 +39,11 @@ This challenge focuses on **GitHub's web-based notification inbox** (at `github.
3939

4040
If you have already configured email notifications on your GitHub account, that is fine—but this challenge does not require or test email delivery. Focus on the web inbox workflow instead.
4141

42-
### Chapter 10 Challenge Set
42+
### Chapter 10 Practice Set
4343

44-
1. **Configure notifications and practice inbox management** - set your watch level, use filters to find relevant notifications, and perform one inbox action.
44+
1. **Configure notifications and practice inbox management** - set your watch level, use filters to find relevant notifications, and perform one inbox action. (Formal evidence for this goes on the Bonus D issue once it unlocks.)
4545

46-
### Challenge 10.1 Step-by-Step: Notification Inbox Walkthrough
46+
### Practice Step-by-Step: Notification Inbox Walkthrough
4747

4848
**Goal:** Set up a useful notification workflow so you can keep up with reviews, mentions, and assignments without inbox overload.
4949

@@ -68,17 +68,15 @@ If you have already configured email notifications on your GitHub account, that
6868

6969
### Completing Chapter 10: Submit Your Evidence
7070

71-
Open your **assigned Chapter 10 challenge issue** and post a completion comment:
71+
This practice does not have its own required issue. If you want to record what you tried, post a comment on your current challenge issue (or later on the **Bonus D: Notification Mastery** issue once it unlocks):
7272

7373
```text
74-
Chapter 10 completed:
74+
Chapter 10 practice completed:
7575
- Watch level set to: Participating and @mentions
7676
- Filters tested: Review requested, Assigned
7777
- Inbox action performed: [mute / mark done] on [thread description]
7878
```
7979

80-
Close your Chapter 10 challenge issue when done.
81-
8280
### Expected Outcomes
8381

8482
- Student can configure repository watch levels to reduce noise.
@@ -586,7 +584,7 @@ Go to [github.com/notifications](https://github.com/notifications) and practice:
586584

587585
Take a breath. Day 1 is complete -- and you did a lot.
588586

589-
Here is every skill you practiced, mapped to the chapter where you learned it and the evidence you created along the way:
587+
Here is every skill you practiced, mapped to the chapter where you learned it and the evidence you created along the way. Chapters 00-01 are setup (no challenge issue); Challenges 1-9 are the required Day 1 challenges; Chapters 09 and 10 are practice content with no required issue of their own (Chapter 09's evidence folds into Challenge 8, and Chapter 10 corresponds to the optional Bonus D, unlocked later):
590588

591589
| Chapter | Skill | Evidence |
592590
|---|---|---|
@@ -598,11 +596,11 @@ Here is every skill you practiced, mapped to the chapter where you learned it an
598596
| [Chapter 05](05-working-with-issues.md) | Created, labeled, and commented on issues | Issue created with a descriptive title and body |
599597
| [Chapter 06](06-working-with-pull-requests.md) | Created a branch, edited a file, and opened a pull request | Merged PR visible in the repository |
600598
| [Chapter 07](07-merge-conflicts.md) | Recognized a merge conflict and resolved it | Conflict-free merge committed |
601-
| [Chapter 08](08-open-source-culture.md) | Read contributing guidelines, understood community norms, and practiced respectful communication | Thoughtful comment on a peer's issue or PR |
602-
| [Chapter 09](09-labels-milestones-projects.md) | Used labels, milestones, and project boards to organize work | Labels applied, milestone progress visible |
603-
| [Chapter 10](10-notifications-and-day-1-close.md) | Configured notification preferences and managed your inbox | Watch level set, at least one notification acted on |
599+
| [Chapter 08](08-open-source-culture.md) | Read contributing guidelines, understood community norms, and practiced respectful communication | Thoughtful comment on a peer's issue or PR, plus a label triaged |
600+
| [Chapter 09](09-labels-milestones-projects.md) | Used labels, milestones, and project boards to organize work | Folded into your Challenge 8 evidence - no separate issue |
601+
| [Chapter 10](10-notifications-and-day-1-close.md) | Configured notification preferences and managed your inbox | Optional - formal evidence goes on Bonus D once it unlocks |
604602

605-
That is eleven chapters, eleven skills, and a trail of real evidence in a real repository.
603+
That is eleven chapters and eleven skills, built on nine required Day 1 challenges and a trail of real evidence in a real repository.
606604

607605
### If This Was Your First Time
608606

@@ -612,7 +610,7 @@ If parts felt confusing or slow, that is completely normal. Every skill you prac
612610

613611
### Confidence Check
614612

615-
Before you close your laptop, take two minutes to answer these questions in your Chapter 10 challenge issue. There are no wrong answers -- this is for you.
613+
Before you close your laptop, take two minutes to answer these questions in a comment on your **Challenge 9: Merge Day** issue (or in a personal note if you have already closed it). There are no wrong answers -- this is for you.
616614

617615
1. Which chapter felt the most natural to you? Which one do you want to revisit?
618616
2. Can you explain what a pull request does to someone who has never used GitHub?
@@ -625,7 +623,7 @@ Before you close your laptop, take two minutes to answer these questions in your
625623

626624
Look at how many challenge issues you completed today. Each one represents a skill you did not just read about -- you practiced it, posted evidence, and moved on. Some workshops hand you a certificate for sitting in a chair. This one asked you to prove your skills in a live repository, and you did.
627625

628-
If you completed all eleven challenges, you are ready for Day 2 with a strong foundation. If you missed a few, that is fine -- you can finish them at your own pace before Day 2 begins. The Learning Room stays open.
626+
If you completed all nine Day 1 challenges, you are ready for Day 2 with a strong foundation. If you missed a few, that is fine -- you can finish them at your own pace before Day 2 begins. The Learning Room stays open.
629627

630628
### Learning Cards: What You Accomplished Today
631629

docs/15-code-review.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ Chapter 15, Part 1 introduces the **GitHub Pull Requests extension** for managin
8686

8787
**You are done when:** You have posted at least one constructive review comment on someone else's PR.
8888

89-
### Completing Chapter 15, Part 1: Submit Your Evidence
89+
### Completing Chapter 15, Part 1: Practice Only
9090

91-
Open your assigned setup or review practice issue and post a completion comment:
91+
Part 1 is setup and practice - it does not have its own required issue. Post a comment on your current challenge issue if you want to record what you tried:
9292

9393
```text
9494
Chapter 15 Part 1 completed:
@@ -99,7 +99,7 @@ Chapter 15 Part 1 completed:
9999
- My comment was about: [one-sentence summary]
100100
```
101101

102-
Close your Chapter 12 challenge issues when done.
102+
Your formal evidence for this skill is submitted later, on the **Challenge 12: Review Like a Pro** issue (see Part 2 below).
103103

104104
### Expected Outcomes
105105

html/docs/04-the-learning-room.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ <h3 id="docschallengesmd---your-challenge-menu">docs/CHALLENGES.md - Your Challe
692692
</tbody></table>
693693
<p>Each challenge lists the file(s) to edit, estimated time, skills practiced, and success criteria.</p>
694694
<h3 id="bonus-challenges">Bonus Challenges</h3>
695-
<p>Five bonus challenges (A through E) are available for students who finish faster. These include an accessibility audit, mentoring a peer, cross-repository contribution, creating a custom workflow, and documentation improvement.</p>
695+
<p>Five bonus challenges (A through E) unlock after Challenge 15 for students who finish faster: improving an existing agent and opening a PR (A), writing a reflection on your workshop journey (B), designing a collaborative challenge for future cohorts (C), configuring GitHub notifications (D), and exploring repository history visually with GitHub Desktop (E).</p>
696696
<h2 id="how-pr-sharing-works">How PR Sharing Works</h2>
697697
<h3 id="step-1-student-opens-a-pr">Step 1: Student Opens a PR</h3>
698698
<h4 id="student-a-working-on-challenge-3-complete-welcome-guide">Student A (working on Challenge 3: Complete Welcome Guide)</h4>

0 commit comments

Comments
 (0)