Priority rule handling for colour overrides.

[ashprice]

Making this issue partly as an explicit record of a personal docs todo (I will try to get to updating the docs soon) and partly to ask a question about changing behaviour.

Themeing colour overrides need to be parsed after colour includes. This may not be obvious based solely on the docs. If you have:

color.burndown.done=on rgb010
color.burndown.pending=on color9
color.burndown.started=on color11

include no-color.theme

You will have no colours. If you have:

include no-color.theme

color.burndown.done=on rgb010
color.burndown.pending=on color9
color.burndown.started=on color11

You get your colours.

This should probably be made more apparent, even if it is a common behaviour many configuration parsers follow.

The open question: should we implement some kind of priority rule that prioritizes taskrc over theme files, such that you could put those lines in any order within taskrc? This seems common sense to me but I wanted to pose it as a question, in case there are good reasons to avoid this.

[djmitche]

This is definitely a gotcha, even if it does sort of make sense in the way "include" is generally implemented -- treating the target file as if it was included at that point in the source file.

One possibility may be to consider all include directives before any other directives in .taskrc. We could perhaps rename it to "import" in that case.

Another is to warn if an include directive follows any other directive -- but even the example config does this, so likely every user would see the warning and have to deal with it.