Merge pull request #71 from InsForge/fix-refresh-error

Fix refresh error

Author: Fermionic-Lyu

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@insforge/sdk",
-  "version": "1.2.9",
+  "version": "1.2.10",
   "description": "Official JavaScript/TypeScript client for InsForge Backend-as-a-Service platform",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

package.json

@@ -987,6 +987,35 @@ describe('HttpClient', () => {
       expect(tokenManager.clearSession).toHaveBeenCalledOnce();
     });
 
+    it('should preserve session when refresh fails with a transient network error', async () => {
+      const tokenManager = createMockTokenManager();
+      const mockFetch = vi
+        .fn()
+        .mockResolvedValueOnce(
+          createJsonResponse(
+            401,
+            {
+              error: 'AUTH_UNAUTHORIZED',
+              message: 'Invalid token',
+              statusCode: 401,
+            },
+            'Unauthorized',
+          ),
+        )
+        .mockRejectedValueOnce(new TypeError('network down'));
+
+      const client = createClient(mockFetch, {}, tokenManager);
+      client.setAuthToken('old-token');
+      const error = (await client
+        .get('/api/protected')
+        .catch((e: unknown) => e)) as InsForgeError;
+
+      expect(error).toBeInstanceOf(InsForgeError);
+      expect(error.error).toBe('NETWORK_ERROR');
+      expect(tokenManager.clearSession).not.toHaveBeenCalled();
+      expect(client.getHeaders().Authorization).toBe('Bearer old-token');
+    });
+
     it('refresh succeeds, retry fails without clearing auth state', async () => {
       const tokenManager = createMockTokenManager();
       const mockFetch = vi

src/lib/__tests__/http-client.test.ts

@@ -518,7 +518,12 @@ export class HttpClient {
       try {
         await this.refreshAndSaveSession();
       } catch (error) {
-        this.clearAuthSession();
+        if (
+          error instanceof InsForgeError &&
+          (error.statusCode === 401 || error.statusCode === 403)
+        ) {
+          this.clearAuthSession();
+        }
         throw error;
       }
       return await this.handleRequest<T>(method, path, {
@@ -649,7 +654,12 @@ export class HttpClient {
     try {
       newTokenData = await this.refreshAndSaveSession();
     } catch (error) {
-      this.clearAuthSession();
+      if (
+        error instanceof InsForgeError &&
+        (error.statusCode === 401 || error.statusCode === 403)
+      ) {
+        this.clearAuthSession();
+      }
       throw error;
     }