You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
π€ This PR was created by Repo Assist, an automated AI assistant.
Summary
Fixes all 153 ruff lint errors in tests/test_observable/ and removes that directory from the ruff exclude list in pyproject.toml. This is the final ruff-cleanup stage β the ruff exclude list now has no test directories.
Changes
pyproject.toml
Remove tests/test_observable from [tool.ruff] exclude
tests/test_observable/ β 153 ruff errors fixed:
E741 (13): Renamed ambiguous variable l β left / items / timers in test_amb.py, test_skipuntil.py, test_takeuntil.py, test_timeinterval.py, test_groupjoin.py
E721 (1): Replaced type(err) == asyncio.CancelledError with isinstance(err, asyncio.CancelledError) in test_fromfuture.py
E501 (37): Long test assertion lines (marble data) suppressed with # noqa: E501 where needed, docstring lines wrapped at 88 chars
uv run pyright β 0 errors, 0 warnings, 0 informations (pyright exclude for tests/test_observable and tests/test_scheduler remains β strict-mode pyright fixes are a separate effort)
Note on pyright
The pyright exclude for tests/test_observable and tests/test_scheduler remains in place β strict pyright mode reveals ~7000 type errors there, which require a dedicated cleanup effort.
Warning
Protected Files
This was originally intended as a pull request, but the patch modifies protected files. These files may affect project dependencies, CI/CD pipelines, or agent behaviour. Please review the changes carefully before creating the pull request.
π€ This PR was created by Repo Assist, an automated AI assistant.
Summary
Fixes all 153 ruff lint errors in
tests/test_observable/and removes that directory from the ruffexcludelist inpyproject.toml. This is the final ruff-cleanup stage β the ruff exclude list now has no test directories.Changes
pyproject.tomltests/test_observablefrom[tool.ruff] excludetests/test_observable/β 153 ruff errors fixed:lβleft/items/timersintest_amb.py,test_skipuntil.py,test_takeuntil.py,test_timeinterval.py,test_groupjoin.pytype(err) == asyncio.CancelledErrorwithisinstance(err, asyncio.CancelledError)intest_fromfuture.py# noqa: E501where needed, docstring lines wrapped at 88 charsValidation
uv run ruff check .β All checks passed!uv run pyrightβ 0 errors, 0 warnings, 0 informations (pyright exclude fortests/test_observableandtests/test_schedulerremains β strict-mode pyright fixes are a separate effort)Note on pyright
The pyright exclude for
tests/test_observableandtests/test_schedulerremains in place β strict pyright mode reveals ~7000 type errors there, which require a dedicated cleanup effort.Warning
Protected Files
This was originally intended as a pull request, but the patch modifies protected files. These files may affect project dependencies, CI/CD pipelines, or agent behaviour. Please review the changes carefully before creating the pull request.
Click here to create the pull request once you have reviewed the changes
Protected files
pyproject.tomlTo route changes like this to a review issue instead of blocking, configure
protected-files: fallback-to-issuein your workflow configuration.Note
π Integrity filter blocked 72 items
The following items were blocked because they don't meet the GitHub integrity level.
list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: