Skip to content

[Repo Assist] test: fix all ruff lint errors in tests/test_observable/; remove from ruff excludeΒ #777

Description

@github-actions

πŸ€– This PR was created by Repo Assist, an automated AI assistant.

Summary

Fixes all 153 ruff lint errors in tests/test_observable/ and removes that directory from the ruff exclude list in pyproject.toml. This is the final ruff-cleanup stage β€” the ruff exclude list now has no test directories.

Changes

pyproject.toml

  • Remove tests/test_observable from [tool.ruff] exclude

tests/test_observable/ β€” 153 ruff errors fixed:

  • E741 (13): Renamed ambiguous variable l β†’ left / items / timers in test_amb.py, test_skipuntil.py, test_takeuntil.py, test_timeinterval.py, test_groupjoin.py
  • E721 (1): Replaced type(err) == asyncio.CancelledError with isinstance(err, asyncio.CancelledError) in test_fromfuture.py
  • E501 (37): Long test assertion lines (marble data) suppressed with # noqa: E501 where needed, docstring lines wrapped at 88 chars
  • UP032/UP031/UP004/UP035/I001/F401 etc. (rest): Auto-fixed (f-strings, useless object inheritance, deprecated imports, unsorted imports, etc.)

Validation

  • uv run ruff check . β†’ All checks passed!
  • uv run pyright β†’ 0 errors, 0 warnings, 0 informations (pyright exclude for tests/test_observable and tests/test_scheduler remains β€” strict-mode pyright fixes are a separate effort)

Note on pyright

The pyright exclude for tests/test_observable and tests/test_scheduler remains in place β€” strict pyright mode reveals ~7000 type errors there, which require a dedicated cleanup effort.


Warning

Protected Files

This was originally intended as a pull request, but the patch modifies protected files. These files may affect project dependencies, CI/CD pipelines, or agent behaviour. Please review the changes carefully before creating the pull request.

Click here to create the pull request once you have reviewed the changes

Protected files
  • pyproject.toml

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Note

πŸ”’ Integrity filter blocked 72 items

The following items were blocked because they don't meet the GitHub integrity level.

  • #749 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #748 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #742 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #736 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #711 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #700 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #698 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #634 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • using timeout with GroupedObservable leads to an index shiftΒ #225 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Sort hot observable between (slow) scan executionsΒ #237 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Observable interval appears to leakΒ #259 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Example noteboks are out of dateΒ #265 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Proposal for a subscribe schedulerΒ #309 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Convert async iterator to ObervableΒ #422 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Weird interaction between group_by and to_iterable?Β #467 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Q: how to use scheduler with subject for concurrency?Β #528 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • ... and 56 more items

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Repo Assist Β· ● 5.5M Β· β—·

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions