From 94821d853ec151c275597eadcea91b442de3f06e Mon Sep 17 00:00:00 2001 From: Noa Levi <275430404+lphuc2250gma@users.noreply.github.com> Date: Sat, 6 Jun 2026 09:37:33 +0000 Subject: [PATCH 1/2] chore: improve pr-agent maintenance path --- tests/e2e_tests/e2e_utils.py | 6 +++--- tests/health_test/main.py | 16 +++++++++++----- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/tests/e2e_tests/e2e_utils.py b/tests/e2e_tests/e2e_utils.py index b39e2a463d..8e2c1a7220 100644 --- a/tests/e2e_tests/e2e_utils.py +++ b/tests/e2e_tests/e2e_utils.py @@ -1,12 +1,12 @@ -FILE_PATH = "pr_agent/cli_pip.py" +FILE_PATH: str = "pr_agent/cli_pip.py" PR_HEADER_START_WITH = '### **User description**\nupdate cli_pip.py\n\n\n___\n\n### **PR Type**' REVIEW_START_WITH = '## PR Reviewer Guide 🔍\n\n\n
⏱️ Estimated effort to review:' IMPROVE_START_WITH_REGEX_PATTERN = r'^## PR Code Suggestions ✨\n\n\n\n' -NUM_MINUTES = 5 +NUM_MINUTES: int = 5 -NEW_FILE_CONTENT = """\ +NEW_FILE_CONTENT: str = """\ from pr_agent import cli from pr_agent.config_loader import get_settings diff --git a/tests/health_test/main.py b/tests/health_test/main.py index 436ed152ae..459700af37 100644 --- a/tests/health_test/main.py +++ b/tests/health_test/main.py @@ -16,7 +16,7 @@ setup_logger(log_level) -async def run_async(): +async def run_async() -> None: pr_url = os.getenv('TEST_PR_URL', 'https://github.com/Codium-ai/pr-agent/pull/1385') get_settings().set("config.git_provider", "github") @@ -30,7 +30,9 @@ async def run_async(): original_settings = copy.deepcopy(get_settings()) await agent.handle_request(pr_url, ['describe']) pr_header_body = dict(get_settings().data)['artifact'] - assert pr_header_body.startswith('###') and 'PR Type' in pr_header_body and 'Description' in pr_header_body + assert isinstance(pr_header_body, str), f"Expected artifact to be str, got {type(pr_header_body).__name__}" + assert pr_header_body.startswith('###') and 'PR Type' in pr_header_body and 'Description' in pr_header_body, \ + "PR description artifact missing expected sections" context['settings'] = copy.deepcopy(original_settings) # Restore settings state after each test to prevent test interference get_logger().info("PR description generated successfully\n") @@ -39,7 +41,9 @@ async def run_async(): original_settings = copy.deepcopy(get_settings()) await agent.handle_request(pr_url, ['review']) pr_review_body = dict(get_settings().data)['artifact'] - assert pr_review_body.startswith('##') and 'PR Reviewer Guide' in pr_review_body + assert isinstance(pr_review_body, str), f"Expected artifact to be str, got {type(pr_review_body).__name__}" + assert pr_review_body.startswith('##') and 'PR Reviewer Guide' in pr_review_body, \ + "PR review artifact missing expected header" context['settings'] = copy.deepcopy(original_settings) # Restore settings state after each test to prevent test interference get_logger().info("PR review generated successfully\n") @@ -48,7 +52,9 @@ async def run_async(): original_settings = copy.deepcopy(get_settings()) await agent.handle_request(pr_url, ['improve']) pr_improve_body = dict(get_settings().data)['artifact'] - assert pr_improve_body.startswith('##') and 'PR Code Suggestions' in pr_improve_body + assert isinstance(pr_improve_body, str), f"Expected artifact to be str, got {type(pr_improve_body).__name__}" + assert pr_improve_body.startswith('##') and 'PR Code Suggestions' in pr_improve_body, \ + "PR improve artifact missing expected header" context['settings'] = copy.deepcopy(original_settings) # Restore settings state after each test to prevent test interference get_logger().info("PR improvements generated successfully\n") @@ -59,7 +65,7 @@ async def run_async(): raise e -def run(): +def run() -> None: with request_cycle_context({}): context['settings'] = copy.deepcopy(global_settings) asyncio.run(run_async()) From 6f6e8bddf2552ca4bb2f3794112cfe233a7dcb50 Mon Sep 17 00:00:00 2001 From: naorpeled Date: Sun, 21 Jun 2026 22:38:09 +0300 Subject: [PATCH 2/2] style(health_test): use double quotes in sanity-check assertions Resolve AI review comment on #2431: match the double-quote style of the new assertion messages added in this PR. --- tests/health_test/main.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/health_test/main.py b/tests/health_test/main.py index 459700af37..11279f49b6 100644 --- a/tests/health_test/main.py +++ b/tests/health_test/main.py @@ -31,7 +31,7 @@ async def run_async() -> None: await agent.handle_request(pr_url, ['describe']) pr_header_body = dict(get_settings().data)['artifact'] assert isinstance(pr_header_body, str), f"Expected artifact to be str, got {type(pr_header_body).__name__}" - assert pr_header_body.startswith('###') and 'PR Type' in pr_header_body and 'Description' in pr_header_body, \ + assert pr_header_body.startswith("###") and "PR Type" in pr_header_body and "Description" in pr_header_body, \ "PR description artifact missing expected sections" context['settings'] = copy.deepcopy(original_settings) # Restore settings state after each test to prevent test interference get_logger().info("PR description generated successfully\n") @@ -42,7 +42,7 @@ async def run_async() -> None: await agent.handle_request(pr_url, ['review']) pr_review_body = dict(get_settings().data)['artifact'] assert isinstance(pr_review_body, str), f"Expected artifact to be str, got {type(pr_review_body).__name__}" - assert pr_review_body.startswith('##') and 'PR Reviewer Guide' in pr_review_body, \ + assert pr_review_body.startswith("##") and "PR Reviewer Guide" in pr_review_body, \ "PR review artifact missing expected header" context['settings'] = copy.deepcopy(original_settings) # Restore settings state after each test to prevent test interference get_logger().info("PR review generated successfully\n") @@ -53,7 +53,7 @@ async def run_async() -> None: await agent.handle_request(pr_url, ['improve']) pr_improve_body = dict(get_settings().data)['artifact'] assert isinstance(pr_improve_body, str), f"Expected artifact to be str, got {type(pr_improve_body).__name__}" - assert pr_improve_body.startswith('##') and 'PR Code Suggestions' in pr_improve_body, \ + assert pr_improve_body.startswith("##") and "PR Code Suggestions" in pr_improve_body, \ "PR improve artifact missing expected header" context['settings'] = copy.deepcopy(original_settings) # Restore settings state after each test to prevent test interference get_logger().info("PR improvements generated successfully\n")
Category