fix(ci): stabilize review workflow updates

yordis · yordis · commit 81452c27cdc6 · 2026-06-03T14:33:15.000-04:00
Signed-off-by: Yordis Prieto &lt;yordis.prieto@gmail.com&gt;
diff --git a/.github/workflows/canary-container-images.yml b/.github/workflows/canary-container-images.yml
@@ -10,7 +10,9 @@ concurrency:
   cancel-in-progress: true
 
 permissions:
+  actions: write
   contents: read
+  id-token: write
   packages: write
 
 jobs:
@@ -66,19 +68,19 @@ jobs:
           provenance: mode=max
 
       - name: Scan image for vulnerabilities
-        uses: aquasecurity/trivy-action@0.32.0
+        uses: aquasecurity/trivy-action@dc5a429b52fcf669ce959baa2c2dd26090d2a6c4 # v0.32.0
         with:
-          image-ref: ${{ steps.image.outputs.name }}:canary
+          image-ref: ${{ steps.image.outputs.name }}@${{ steps.build_image.outputs.digest }}
           scanners: vuln
           format: table
           output: trivy-results.txt
           ignore-unfixed: true
           exit-code: 0
 
       - name: Generate SBOM
-        uses: anchore/sbom-action@v0.20.6
+        uses: anchore/sbom-action@f8bdd1d8ac5e901a77a92f111440fdb1b593736b # v0.20.6
         with:
-          image: ${{ steps.image.outputs.name }}:canary
+          image: ${{ steps.image.outputs.name }}@${{ steps.build_image.outputs.digest }}
           artifact-name: sbom-${{ matrix.service }}-spdx
           format: spdx-json
 
@@ -88,7 +90,7 @@ jobs:
           {
             echo "## Image security audit: \`${{ matrix.service }}\`"
             echo ""
-            echo "- Image: \`${{ steps.image.outputs.name }}:canary\`"
+            echo "- Image: \`${{ steps.image.outputs.name }}@${{ steps.build_image.outputs.digest }}\`"
             echo "- Runtime base: \`debian:bookworm-20260518-slim\`"
             echo "- SBOM artifact: \`sbom-${{ matrix.service }}-spdx\` (SPDX JSON)"
             echo ""
diff --git a/.github/workflows/docs-pages.yml b/.github/workflows/docs-pages.yml
@@ -24,16 +24,18 @@ jobs:
           persist-credentials: false
           fetch-depth: 0
 
+      - name: Setup pnpm
+        uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
+        with:
+          package_json_file: docs/package.json
+
       - name: Setup Node
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
         with:
           node-version: 26
           cache: pnpm
           cache-dependency-path: docs/pnpm-lock.yaml
 
-      - name: Enable Corepack
-        run: corepack enable
-
       - name: Setup Pages
         uses: actions/configure-pages@45bfe0192ca1faeb007ade9deae92b16b8254a0d
 
diff --git a/.mise.toml b/.mise.toml
@@ -18,7 +18,7 @@ depends = ["build:rust", "build:docs"]
 
 [tasks."build:docs"]
 dir = "docs"
-run = "pnpm install --frozen-lockfile && pnpm docs:build"
+run = "pnpm docs:build"
 
 [tasks."build:rust"]
 dir = "rsworkspace"
diff --git a/rsworkspace/crates/trogon-decider/tests/ui/fail/after_then.stderr b/rsworkspace/crates/trogon-decider/tests/ui/fail/after_then.stderr
@@ -7,9 +7,9 @@ error[E0599]: no method named `when` found for struct `ThenEvents<Event>` in the
    |  _____method `when` is available on `TestCase<TestCommand>`
    | |
 10 | |         .given_no_history()
-   | |          ------------------ method `when` is available on `TestCase<TestCommand, NoHistory>`
+   | |          ------------------ method `when` is available on `TestCase<TestCommand, trogon_decider::testing::NoHistory>`
 11 | |         .when(TestCommand)
-   | |          ----------------- method `when` is available on `TestCase<TestCommand, When<TestEvent, TestState, TestCommand>>`
+   | |          ----------------- method `when` is available on `TestCase<TestCommand, trogon_decider::testing::When<TestEvent, TestState, TestCommand>>`
 12 | |         .then([TestEvent::Registered])
 13 | |         .when(TestCommand);
    | |         -^^^^ method not found in `ThenEvents<TestEvent>`
diff --git a/rsworkspace/crates/trogon-decider/tests/ui/fail/double_given.stderr b/rsworkspace/crates/trogon-decider/tests/ui/fail/double_given.stderr
@@ -1,13 +1,13 @@
-error[E0599]: no method named `given` found for struct `TestCase<TestCommand, NoHistory>` in the current scope
+error[E0599]: no method named `given` found for struct `TestCase<TestCommand, trogon_decider::testing::NoHistory>` in the current scope
   --> tests/ui/fail/double_given.rs:11:10
    |
  9 | /     TestCase::<TestCommand>::new()
 10 | |         .given_no_history()
 11 | |         .given([]);
-   | |         -^^^^^ method not found in `TestCase<TestCommand, NoHistory>`
+   | |         -^^^^^ method not found in `TestCase<TestCommand, trogon_decider::testing::NoHistory>`
    | |_________|
    |
    |
    = note: the method was found for
-           - `TestCase<C, Given<<C as Decider>::Event>>`
+           - `TestCase<C, trogon_decider::testing::Given<<C as Decider>::Event>>`
            - `TestCase<C>`
diff --git a/rsworkspace/crates/trogon-decider/tests/ui/fail/double_when.stderr b/rsworkspace/crates/trogon-decider/tests/ui/fail/double_when.stderr
@@ -1,4 +1,4 @@
-error[E0599]: no method named `when` found for struct `TestCase<TestCommand, When<TestEvent, TestState, TestCommand>>` in the current scope
+error[E0599]: no method named `when` found for struct `TestCase<TestCommand, trogon_decider::testing::When<TestEvent, TestState, TestCommand>>` in the current scope
   --> tests/ui/fail/double_when.rs:12:10
    |
  9 |       TestCase::<TestCommand>::new()
@@ -7,7 +7,7 @@ error[E0599]: no method named `when` found for struct `TestCase<TestCommand, Whe
    |  _____method `when` is available on `TestCase<TestCommand>`
    | |
 10 | |         .given_no_history()
-   | |          ------------------ method `when` is available on `TestCase<TestCommand, NoHistory>`
+   | |          ------------------ method `when` is available on `TestCase<TestCommand, trogon_decider::testing::NoHistory>`
 11 | |         .when(TestCommand)
 12 | |         .when(TestCommand);
    | |_________-^^^^
diff --git a/rsworkspace/crates/trogon-decider/tests/ui/fail/missing_given.stderr b/rsworkspace/crates/trogon-decider/tests/ui/fail/missing_given.stderr
@@ -5,5 +5,5 @@ error[E0599]: no method named `when` found for struct `TestCase<TestCommand>` in
   |                                    ^^^^ method not found in `TestCase<TestCommand>`
   |
   = note: the method was found for
-          - `TestCase<C, Given<<C as Decider>::Event>>`
-          - `TestCase<C, NoHistory>`
+          - `TestCase<C, trogon_decider::testing::Given<<C as Decider>::Event>>`
+          - `TestCase<C, trogon_decider::testing::NoHistory>`
diff --git a/rsworkspace/crates/trogon-decider/tests/ui/fail/missing_initial_when.stderr b/rsworkspace/crates/trogon-decider/tests/ui/fail/missing_initial_when.stderr
@@ -7,5 +7,4 @@ error[E0599]: no method named `then_error` found for struct `TestCase<TestComman
    | |_________|
    |
    |
-   = note: the method was found for
-           - `TestCase<C, When<<C as Decider>::Event, <C as Decider>::State, C>>`
+   = note: the method was found for `TestCase<C, trogon_decider::testing::When<<C as Decider>::Event, <C as Decider>::State, C>>`
diff --git a/rsworkspace/crates/trogon-decider/tests/ui/fail/missing_when.stderr b/rsworkspace/crates/trogon-decider/tests/ui/fail/missing_when.stderr
@@ -1,12 +1,11 @@
-error[E0599]: no method named `then_error` found for struct `TestCase<TestCommand, NoHistory>` in the current scope
+error[E0599]: no method named `then_error` found for struct `TestCase<TestCommand, trogon_decider::testing::NoHistory>` in the current scope
   --> tests/ui/fail/missing_when.rs:11:10
    |
  9 | /     TestCase::<TestCommand>::new()
 10 | |         .given_no_history()
 11 | |         .then_error(TestDecisionError::AlreadyRegistered);
-   | |         -^^^^^^^^^^ method not found in `TestCase<TestCommand, NoHistory>`
+   | |         -^^^^^^^^^^ method not found in `TestCase<TestCommand, trogon_decider::testing::NoHistory>`
    | |_________|
    |
    |
-   = note: the method was found for
-           - `TestCase<C, When<<C as Decider>::Event, <C as Decider>::State, C>>`
+   = note: the method was found for `TestCase<C, trogon_decider::testing::When<<C as Decider>::Event, <C as Decider>::State, C>>`
diff --git a/rsworkspace/crates/trogon-nats/src/jetstream/mocks.rs b/rsworkspace/crates/trogon-nats/src/jetstream/mocks.rs
@@ -932,7 +932,7 @@ impl JetStreamKvKeys for MockJetStreamKvStore {
         match result {
             Ok(keys) => {
                 let items: Vec<Result<String, kv::WatcherError>> = keys.into_iter().map(Ok).collect();
-                Ok(futures::stream::iter(items.into_iter()))
+                Ok(futures::stream::iter(items))
             }
             Err(kind) => Err(kv::HistoryError::new(kind)),
         }

Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,13 @@`
`1`		-error[E0599]: no method named `given` found for struct `TestCase<TestCommand, NoHistory>` in the current scope
	`1`	+error[E0599]: no method named `given` found for struct `TestCase<TestCommand, trogon_decider::testing::NoHistory>` in the current scope
`2`	`2`	`--> tests/ui/fail/double_given.rs:11:10`
`3`	`3`	`\|`
`4`	`4`	`9 \| / TestCase::<TestCommand>::new()`
`5`	`5`	`10 \| \| .given_no_history()`
`6`	`6`	`11 \| \| .given([]);`
`7`		- \| \| -^^^^^ method not found in `TestCase<TestCommand, NoHistory>`
	`7`	+ \| \| -^^^^^ method not found in `TestCase<TestCommand, trogon_decider::testing::NoHistory>`
`8`	`8`	`\| \|_________\|`
`9`	`9`	`\|`
`10`	`10`	`\|`
`11`	`11`	`= note: the method was found for`
`12`		- - `TestCase<C, Given<<C as Decider>::Event>>`
	`12`	+ - `TestCase<C, trogon_decider::testing::Given<<C as Decider>::Event>>`
`13`	`13`	- `TestCase<C>`
Original file line number	Diff line number	Diff line change
@@ -5,5 +5,5 @@ error[E0599]: no method named `when` found for struct `TestCase<TestCommand>` in
`5`	`5`	\| ^^^^ method not found in `TestCase<TestCommand>`
`6`	`6`	`\|`
`7`	`7`	`= note: the method was found for`
`8`		- - `TestCase<C, Given<<C as Decider>::Event>>`
`9`		- - `TestCase<C, NoHistory>`
	`8`	+ - `TestCase<C, trogon_decider::testing::Given<<C as Decider>::Event>>`
	`9`	+ - `TestCase<C, trogon_decider::testing::NoHistory>`
Original file line number	Diff line number	Diff line change
@@ -7,5 +7,4 @@ error[E0599]: no method named `then_error` found for struct `TestCase<TestComman
`7`	`7`	`\| \|_________\|`
`8`	`8`	`\|`
`9`	`9`	`\|`
`10`		`- = note: the method was found for`
`11`		- - `TestCase<C, When<<C as Decider>::Event, <C as Decider>::State, C>>`
	`10`	+ = note: the method was found for `TestCase<C, trogon_decider::testing::When<<C as Decider>::Event, <C as Decider>::State, C>>`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,11 @@`
`1`		-error[E0599]: no method named `then_error` found for struct `TestCase<TestCommand, NoHistory>` in the current scope
	`1`	+error[E0599]: no method named `then_error` found for struct `TestCase<TestCommand, trogon_decider::testing::NoHistory>` in the current scope
`2`	`2`	`--> tests/ui/fail/missing_when.rs:11:10`
`3`	`3`	`\|`
`4`	`4`	`9 \| / TestCase::<TestCommand>::new()`
`5`	`5`	`10 \| \| .given_no_history()`
`6`	`6`	`11 \| \| .then_error(TestDecisionError::AlreadyRegistered);`
`7`		- \| \| -^^^^^^^^^^ method not found in `TestCase<TestCommand, NoHistory>`
	`7`	+ \| \| -^^^^^^^^^^ method not found in `TestCase<TestCommand, trogon_decider::testing::NoHistory>`
`8`	`8`	`\| \|_________\|`
`9`	`9`	`\|`
`10`	`10`	`\|`
`11`		`- = note: the method was found for`
`12`		- - `TestCase<C, When<<C as Decider>::Event, <C as Decider>::State, C>>`
	`11`	+ = note: the method was found for `TestCase<C, trogon_decider::testing::When<<C as Decider>::Event, <C as Decider>::State, C>>`
Original file line number	Diff line number	Diff line change
`@@ -932,7 +932,7 @@ impl JetStreamKvKeys for MockJetStreamKvStore {`
`932`	`932`	`match result {`
`933`	`933`	`Ok(keys) => {`
`934`	`934`	`let items: Vec<Result<String, kv::WatcherError>> = keys.into_iter().map(Ok).collect();`
`935`		`- Ok(futures::stream::iter(items.into_iter()))`
	`935`	`+ Ok(futures::stream::iter(items))`
`936`	`936`	`}`
`937`	`937`	`Err(kind) => Err(kv::HistoryError::new(kind)),`
`938`	`938`	`}`