Skip to content

Commit 334254e

Browse files
committed
fix(ui5-modernization): Apply Code Review
1 parent b112d60 commit 334254e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

plugins/ui5-modernization/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ claude plugin install ui5-modernization@claude-plugins-official
2929

3030
The goal is to make your app compatible with **modern UI5** — targeting Manifest version 2.0.0 with a minimum UI5 framework version of 1.136.0. Modern UI5 removes all deprecated APIs and enforces strict module imports, meaning apps that rely on globals or legacy patterns will break at runtime.
3131

32-
This plugin is built around [UI5 linter](https://github.com/SAP/ui5-linter) (`@ui5/linter`) — a static analysis tool that detects deprecated APIs, global namespace access, and other incompatibilities. The linter serves two roles in the modernization workflow:
32+
This plugin is built around the [UI5 Linter](https://github.com/UI5/linter) (`@ui5/linter`) — a static analysis tool that detects deprecated APIs, global namespace access, and other incompatibilities. The linter serves two roles in the modernization workflow:
3333

3434
1. **Detection** — Each skill reads linter output to identify what needs fixing. The linter's rule IDs (e.g., `no-deprecated-api`, `no-globals`) map directly to specific fix skills.
3535
2. **Verification** — After applying fixes, the linter is re-run to confirm errors are resolved. Zero remaining errors = phase complete.

plugins/ui5-modernization/skills/modernize-ui5-app/references/SAPUI5_Local_Build.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ URLs after the server is up:
5353
- Test bootstrap: `http://localhost:8090/<artifactId>/test-resources/testFLPService.html`
5454
- Test Starter: `http://localhost:8090/<artifactId>/test-resources/<namespace-path>/Test.qunit.html?testsuite=test-resources/<namespace-path>/testsuite.qunit&test=<entry-key>`
5555

56-
Replace `<artifactId>` with the value from `pom.xml` (e.g., `ui.cloudfnd.analyticsdesigntool.s1`) and `<namespace-path>` with the slash-separated app namespace (e.g., `ui/cloudfnd/analyticsdesigntool/s1`).
56+
Replace `<artifactId>` with the value from `pom.xml` (e.g., `my.sample.app`) and `<namespace-path>` with the slash-separated app namespace (e.g., `my/sample/app`).
5757

5858
### §1.2 Failure: `test-resources/` 404s OR `ClassNotFoundException` at boot
5959

0 commit comments

Comments
 (0)