Skip to content

Commit 7302cd1

Browse files
kadamwhiteclaude
andcommitted
docs: record the Node 22 FormData filename fix in handoff.md
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent c066a2a commit 7302cd1

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

handoff.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,17 @@ the exportless superagent stub (emits `export {}` — correct).
6060
currently has no production callers (dead since the Phase 2 transport
6161
rewrite) — flagged as removable dead code, left in place.
6262

63+
### Post-merge fix: Node 22 CI failure (latent since Phase 2)
64+
65+
Main's CI Node 22 leg had been red since the Phase 2 merge, unnoticed
66+
(local dev runs Node 24). Cause: `FormData#append( name, file, undefined )`
67+
with an explicit third argument coerces the filename to the string
68+
`"undefined"` on Node 18-22, clobbering a File attachment's own name;
69+
Node 24+ treats a trailing undefined as absent. Fixed in fetch-transport's
70+
`createUploadForm` by omitting the argument when there is no name override.
71+
Lesson: run the transport suite under the oldest CI Node before merging
72+
transport changes (`nvm exec 22 npx vitest run fetch/tests/unit`).
73+
6374
### Dependency notes
6475

6576
- Added `@types/node@^20` (vitest 4's peer floor; the published runtime

0 commit comments

Comments
 (0)