chore(state): improve logging when not restoring non-finalized backup due to higher checkpoint (#11150)

Author: mergify[bot]

zebra-state/src/service.rs

@@ -352,12 +352,22 @@ impl StateService {
         // aren't blocks in the restored non-finalized state that are above the max checkpoint height,
         // otherwise, unless checkpoint sync is disabled in the zebra-consensus configuration,
         // Zebra will be unable to commit checkpoint verified blocks, and its chain sync will stall.
-        let is_finalized_tip_past_max_checkpoint = if let Some(tip) = &finalized_tip {
-            tip.coinbase_height().expect("valid block must have height") >= max_checkpoint_height
-        } else {
-            false
-        };
+        let finalized_tip_height = finalized_tip
+            .as_ref()
+            .map(|tip| tip.coinbase_height().expect("valid block must have height"));
+        let is_finalized_tip_past_max_checkpoint =
+            finalized_tip_height.is_some_and(|tip_height| tip_height >= max_checkpoint_height);
         let backup_dir_path = config.non_finalized_state_backup_dir(network);
+
+        if backup_dir_path.is_some() && !is_finalized_tip_past_max_checkpoint {
+            tracing::info!(
+                ?finalized_tip_height,
+                ?max_checkpoint_height,
+                "not restoring the non-finalized state backup, because the finalized tip is absent \
+                 or below the max checkpoint height: Zebra will re-download and re-verify the \
+                 blocks above its finalized tip"
+            );
+        }
         let skip_backup_task = config.debug_skip_non_finalized_state_backup_task;
         let (non_finalized_state, non_finalized_state_sender, non_finalized_state_receiver) =
             NonFinalizedState::new(network)

zebra-state/src/service/non_finalized_state.rs

@@ -175,7 +175,14 @@ impl NonFinalizedState {
             return with_watch_channel(self);
         };
 
-        if skip_backup_task {
+        if !should_restore_backup {
+            tracing::info!(
+                ?backup_dir_path,
+                spawning_backup_task = !skip_backup_task,
+                "not restoring non-finalized blocks from backup, any backed up blocks that are \
+                 missing from the non-finalized state will be deleted"
+            );
+        } else if skip_backup_task {
             tracing::info!(
                 ?backup_dir_path,
                 "restoring non-finalized blocks from backup (sync write mode, backup task skipped)"
@@ -221,6 +228,8 @@ impl NonFinalizedState {
                 ?num_blocks_restored,
                 "restored blocks from non-finalized backup cache"
             );
+        } else if should_restore_backup {
+            tracing::info!("no blocks were restored from the non-finalized backup cache");
         }
 
         (non_finalized_state, sender, receiver)