Skip to content

Commit b014a79

Browse files
authored
ci: make changelog check optional; update docs (#11180)
2 parents 3dd9756 + e234320 commit b014a79

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/pr-gate.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ jobs:
137137
feature-group: default-features
138138
baseline-rev: ${{ steps.baseline.outputs.rev }}
139139

140+
# This checks for changelog entries depending on the type of the PR (per title).
141+
# An entry is required for a crate if any file in the crate changed.
142+
# If the title indicates a breaking change, the changelog must also have a `### Breaking Changes` section.
140143
changelog-gate:
141144
needs: changes
142145
if: >-
@@ -192,6 +195,8 @@ jobs:
192195
exit 1
193196
fi
194197
echo "base_sha=${base_sha}" >> "${GITHUB_OUTPUT}"
198+
# Checks if the changelogs have entries for the versions being released
199+
# (used in the in the release PR).
195200
- name: Validate release changelogs
196201
id: changelogs
197202
continue-on-error: true
@@ -284,4 +289,7 @@ jobs:
284289
uses: re-actors/alls-green@05ac9388f0aebcb5727afa17fcccfecd6f8ec5fe # v1.2.2
285290
with:
286291
jobs: ${{ toJSON(needs) }}
292+
# Leave it for the PR author and reviewer to decide if the changelog
293+
# entries are good enough.
294+
allowed-failures: changelog-gate
287295
allowed-skips: semver-checks, changelog-gate, release-readiness

0 commit comments

Comments
 (0)