ci: drop Windows and macOS runners (#10845)

* ci: drop Windows and macOS runners

Remove the Windows/macOS unit-test matrix and the brew/choco install
branches from setup-zebra-build. Unnecessary CI overhead: no relevant
node operators run those OSes, and other enthusiasts can use Docker.

Claude-Session: https://claude.ai/code/session_01VUPwpe81Ws8c5MeXWWgZb7

* docs: demote Windows and macOS to tier 3

CI no longer builds or tests them, so they no longer meet the tier 2
"guaranteed to build" bar. Tier 3 = supported in code, untested, may or
may not work — use Docker.

Claude-Session: https://claude.ai/code/session_01VUPwpe81Ws8c5MeXWWgZb7

* test: drop Windows and macOS test exclusions

Remove the `cfg(not(windows))` / `cfg(not(macos))` skips and the nextest
`delete_old_databases` Windows filter, now that neither platform runs in
CI. For feature-combined gates, keep the `#[cfg(feature = ...)]` and drop
only the OS predicate. Genuine platform-abstraction code (`stop()`,
`random_known_port`, `default_lwd_cache_dir`) is left intact.

Claude-Session: https://claude.ai/code/session_01VUPwpe81Ws8c5MeXWWgZb7

* test: drop Windows guard from rpc.rs test imports

The `metrics_endpoint` / `tracing_endpoint` helper imports kept
`not(target_os = "windows")` after the tests themselves became
feature-only gated, so a Windows build with `prometheus` or
`filter-reload` would compile the tests without their imports and fail.
Match the imports to the tests' gating.

Claude-Session: https://claude.ai/code/session_01VUPwpe81Ws8c5MeXWWgZb7

* test: merge config.rs imports after dropping the macOS gate

Addresses review: the two `crate::common` import blocks can be one now
that the `#[cfg(not(target_os = "macos"))]` gate is gone.

Claude-Session: https://claude.ai/code/session_01VUPwpe81Ws8c5MeXWWgZb7

* ci: keep the Linux guard on setup-zebra-build's apt step

Addresses review: the composite action is Linux-only, but guarding the
apt-get step keeps it inert if ever reused on another runner.

Claude-Session: https://claude.ai/code/session_01VUPwpe81Ws8c5MeXWWgZb7

Author: upbqdn

.config/nextest.toml

@@ -12,12 +12,6 @@ fail-fast = true
 status-level = "pass"
 default-filter = 'not test(/^stateful::/) and not test(/^e2e::/) and not test(=unit::end_of_support::check_no_git_dependencies)'
 
-# --- Platform overrides ---
-
-[[profile.default.overrides]]
-platform = 'cfg(target_os = "windows")'
-filter = "not test(=integration::database::delete_old_databases)"
-
 # --- CI Profile (PRs) ---
 
 [profile.ci]
@@ -26,10 +20,6 @@ failure-output = "immediate"
 slow-timeout = { period = "5m", terminate-after = 4 }
 default-filter = 'not test(/^stateful::/) and not test(/^e2e::/) and not test(=unit::end_of_support::check_no_git_dependencies)'
 
-[[profile.ci.overrides]]
-platform = 'cfg(target_os = "windows")'
-filter = "not test(=integration::database::delete_old_databases)"
-
 [[profile.ci.overrides]]
 filter = 'test(=integration::network::disconnects_from_misbehaving_peers)'
 retries = 2

.github/actions/setup-zebra-build/action.yml

@@ -10,21 +10,3 @@ runs:
         sudo apt-get -qq update
         sudo apt-get -qq install -y --no-install-recommends protobuf-compiler librocksdb-dev
         echo "ROCKSDB_LIB_DIR=/usr/lib/" >> $GITHUB_ENV
-
-    - name: Install protoc and RocksDB on macOS
-      if: runner.os == 'macOS'
-      shell: bash
-      run: |
-        brew install protobuf rocksdb
-        # Set ROCKSDB_LIB_DIR for both Intel and Apple Silicon Macs
-        if [ -d "/opt/homebrew/lib" ]; then
-          echo "ROCKSDB_LIB_DIR=/opt/homebrew/lib" >> $GITHUB_ENV
-        else
-          echo "ROCKSDB_LIB_DIR=/usr/local/lib" >> $GITHUB_ENV
-        fi
-
-    - name: Install protoc on Windows
-      if: runner.os == 'Windows'
-      shell: bash
-      run: |
-        choco install protoc -y

.github/workflows/tests-unit.yml

@@ -43,28 +43,20 @@ jobs:
           filters: .github/path-filters.yml
 
   run-unit-tests:
-    name: ${{ matrix.rust-version }} on ${{ matrix.os }}
+    name: ${{ matrix.rust-version }}
     needs: changes
     if: needs.changes.outputs.unit_tests == 'true'
     permissions:
       contents: read
       id-token: write
       statuses: write
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     timeout-minutes: 120
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
         rust-version: [stable, beta]
         features: [default-release-binaries]
-        exclude:
-          # Exclude macOS beta due to limited runner capacity and slower performance
-          # Exclude Windows beta to reduce the amount of minutes cost per workflow run
-          - os: macos-latest
-            rust-version: beta
-          - os: windows-latest
-            rust-version: beta
 
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #v6.0.2
@@ -73,31 +65,13 @@ jobs:
       - uses: actions-rust-lang/setup-rust-toolchain@46268bd060767258de96ed93c1251119784f2ab6 #v1.16.1
         with:
           toolchain: ${{ matrix.rust-version }}
-          cache-key: unit-tests-${{ matrix.os }}-${{ matrix.rust-version }}-${{ matrix.features }}
+          cache-key: unit-tests-${{ matrix.rust-version }}-${{ matrix.features }}
           cache-on-failure: true
       - uses: taiki-e/install-action@65851e10cd6c377f11a60e600abc07cb08643468 #v2.79.3
         with:
           tool: cargo-nextest
       - uses: ./.github/actions/setup-zebra-build
 
-      # Windows-specific setup
-      - name: Install LLVM on Windows
-        if: matrix.os == 'windows-latest'
-        run: |
-          choco install llvm -y
-          echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
-          echo "LIBCLANG_PATH=C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
-
-      - name: Minimise proptest cases on macOS and Windows
-        # We set cases to 1, because some tests already run 1 case by default.
-        # We keep maximum shrink iterations at the default value, because it only happens on failure.
-        #
-        # Windows compilation and tests are slower than other platforms.
-        if: matrix.os == 'windows-latest'
-        run: |
-          echo "PROPTEST_CASES=1" >> $GITHUB_ENV
-          echo "PROPTEST_MAX_SHRINK_ITERS=1024" >> $GITHUB_ENV
-
       - name: Run unit tests
         run: cargo nextest run --profile ci --locked --release --features "${{ matrix.features }}" --run-ignored=all
 

book/src/user/supported-platforms.md

@@ -43,8 +43,6 @@ For the full requirements, see [Tier 2 platform policy](target-tier-policies.md#
 | -------------------------- | ----------------------------------------------------------------------------------------------- | ----------- | ------------------------------------------------------------------------------ | --------- |
 | `x86_64-unknown-linux-gnu` | [GitHub ubuntu-latest](https://github.com/actions/virtual-environments#available-environments)  | 64-bit      | [latest stable release](https://github.com/rust-lang/rust/releases)            | N/A       |
 | `x86_64-unknown-linux-gnu` | [GitHub ubuntu-latest](https://github.com/actions/virtual-environments#available-environments)  | 64-bit beta | [latest beta release](https://github.com/rust-lang/rust/blob/beta/src/version) | N/A       |
-| `x86_64-apple-darwin`      | [GitHub macos-latest](https://github.com/actions/virtual-environments#available-environments)   | 64-bit      | [latest stable release](https://github.com/rust-lang/rust/releases)            | N/A       |
-| `x86_64-pc-windows-msvc`   | [GitHub windows-latest](https://github.com/actions/virtual-environments#available-environments) | 64-bit      | [latest stable release](https://github.com/rust-lang/rust/releases)            | N/A       |
 
 > **Note:** Linux is tested on both stable and beta Rust to catch potential regressions early.
 
@@ -56,6 +54,8 @@ work. Official builds are not available.
 
 For the full requirements, see [Tier 3 platform policy](target-tier-policies.md#tier-3-platform-policy) in the Platform Tier Policy.
 
-| platform               | os           | notes                  | rust                                                                | artifacts |
-| ---------------------- | ------------ | ---------------------- | ------------------------------------------------------------------- | --------- |
-| `aarch64-apple-darwin` | latest macOS | 64-bit, Apple M1 or M2 | [latest stable release](https://github.com/rust-lang/rust/releases) | N/A       |
+| platform                 | os             | notes                  | rust                                                                | artifacts |
+| ------------------------ | -------------- | ---------------------- | ------------------------------------------------------------------- | --------- |
+| `x86_64-apple-darwin`    | latest macOS   | 64-bit                 | [latest stable release](https://github.com/rust-lang/rust/releases) | N/A       |
+| `aarch64-apple-darwin`   | latest macOS   | 64-bit, Apple M1 or M2 | [latest stable release](https://github.com/rust-lang/rust/releases) | N/A       |
+| `x86_64-pc-windows-msvc` | latest Windows | 64-bit                 | [latest stable release](https://github.com/rust-lang/rust/releases) | N/A       |

zebra-network/src/peer_set/initialize/tests/vectors.rs

@@ -27,7 +27,6 @@ use tower::{service_fn, Layer, Service, ServiceExt};
 
 use zebra_chain::{chain_tip::NoChainTip, parameters::Network, serialization::DateTime32};
 
-#[cfg(not(target_os = "windows"))]
 use zebra_test::net::random_known_port;
 
 use crate::{
@@ -147,7 +146,6 @@ async fn local_listener_unspecified_port_localhost_addr_v6() {
 
 /// Test that zebra-network propagates fixed localhost listener ports to the `AddressBook`.
 #[tokio::test]
-#[cfg(not(target_os = "windows"))]
 async fn local_listener_fixed_port_localhost_addr_v4() {
     let _init_guard = zebra_test::init();
 
@@ -164,7 +162,6 @@ async fn local_listener_fixed_port_localhost_addr_v4() {
 
 /// Test that zebra-network propagates fixed localhost listener ports to the `AddressBook`.
 #[tokio::test]
-#[cfg(not(target_os = "windows"))]
 async fn local_listener_fixed_port_localhost_addr_v6() {
     let _init_guard = zebra_test::init();
 
@@ -946,10 +943,6 @@ async fn listener_peer_limit_default_handshake_error() {
 
 /// Test the listener with the default inbound peer limit,
 /// and a handshaker that returns success then disconnects the peer.
-///
-/// TODO: tweak the crawler timeouts and rate-limits so we get over the actual limit on macOS
-///       (currently, getting over the limit can take 30 seconds or more)
-#[cfg(not(target_os = "macos"))]
 #[tokio::test]
 async fn listener_peer_limit_default_handshake_ok_then_drop() {
     let _init_guard = zebra_test::init();

zebra-state/src/service/non_finalized_state/tests/prop.rs

@@ -447,7 +447,6 @@ fn finalized_equals_pushed_history_tree() -> Result<()> {
 /// Check that rejected blocks do not change the internal state of a genesis chain
 /// in a non-finalized state.
 #[test]
-#[cfg(not(target_os = "windows"))]
 fn rejection_restores_internal_state_genesis() -> Result<()> {
     use zebra_chain::fmt::DisplayToDebug;
 

zebrad/src/components/health/tests.rs

@@ -175,7 +175,6 @@ async fn not_ready_when_tip_is_too_old() {
 }
 
 #[tokio::test]
-#[cfg(not(target_os = "windows"))]
 async fn rate_limiting_drops_bursts() {
     // With a sleep shorter than the configured interval we should only be able
     // to observe one successful request before the limiter responds with 429.

zebrad/tests/e2e/lightwalletd.rs

@@ -8,12 +8,8 @@ use crate::common::{lightwalletd::lwd_integration_test, test_type::TestType::Ful
 /// - `TEST_LIGHTWALLETD` is set,
 /// - a persistent cached state is configured (e.g., via `ZEBRA_STATE__CACHE_DIR`), and
 /// - Zebra is compiled with `--features=lightwalletd-grpc-tests`.
-///
-///
-/// This test doesn't work on Windows, so it is always skipped on that platform.
 #[test]
 #[ignore]
-#[cfg(not(target_os = "windows"))]
 fn lwd_sync_full() -> Result<()> {
     lwd_integration_test(FullSyncFromGenesis {
         allow_lightwalletd_cached_state: false,

zebrad/tests/integration/database.rs

@@ -174,7 +174,6 @@ where
 }
 
 #[test]
-#[cfg(not(target_os = "windows"))]
 fn delete_old_databases() -> Result<()> {
     use std::fs::{canonicalize, create_dir};
 

zebrad/tests/integration/mod.rs

@@ -1,5 +1,4 @@
 pub mod database;
-#[cfg(not(target_os = "windows"))]
 pub mod network;
 pub mod regtest;
 pub mod rpc;