Tracking: 27 ignored tests after Transaction newtype migration

[arya2]

Summary

As part of the Transaction type migration from enum to zcash_primitives newtype wrapper (#10461), 27 tests were marked #[ignore] because they require mutating Transaction internals that the newtype wrapper does not expose. No tests were deleted.

The underlying verification logic is unchanged — only the test setup code (which constructs or mutates transactions to create specific test scenarios) is blocked.

Ignored Tests by Capability Needed

1. outputs_mut() / inputs_mut() — 8 tests

These need the ability to replace specific transparent outputs/inputs with test-crafted scripts (e.g., OP_RETURN, bare multisig). Restorable by adding with_transparent_output_at(index, output) to Transaction.

Test	File
mempool_reject_non_standard	zebrad/.../vector.rs:1190
mempool_accept_standard_op_return	zebrad/.../vector.rs:1198
mempool_reject_op_return_too_large	zebrad/.../vector.rs:1206
mempool_reject_multi_op_return	zebrad/.../vector.rs:1214
mempool_reject_non_standard_scriptpubkey	zebrad/.../vector.rs:1222
mempool_reject_bare_multisig	zebrad/.../vector.rs:1230
mempool_reject_large_multisig	zebrad/.../vector.rs:1238
mempool_reject_large_scriptsig	zebrad/.../vector.rs:1246

2. insert_fake_orchard_shielded_data — 5 tests

These construct synthetic orchard bundles for testing. Restorable by adding a builder method in librustzcash or by constructing the data via byte-level serialization.

Test	File
v5_coinbase_transaction_without_enable_spends_flag_passes_validation	zebra-consensus/.../tests.rs:1111
v5_coinbase_transaction_with_enable_spends_flag_fails_validation	zebra-consensus/.../tests.rs:1118
coinbase_outputs_are_decryptable_for_fake_v5_blocks	zebra-consensus/.../tests.rs:2780
shielded_outputs_are_not_decryptable_for_fake_v5_blocks	zebra-consensus/.../tests.rs:2788
mempool_skip_accepts_block_with_garbage_orchard_proofs	zebra-consensus/.../tests.rs:2933

3. expiry_height_mut / update_network_upgrade — 4 tests

These mutate the expiry height or network upgrade field after construction. Restorable by adding a with_expiry_height(height) builder method to Transaction.

Test	File
v5_coinbase_transaction_expiry_height	zebra-consensus/.../tests.rs:1758
v5_consensus_branch_ids	zebra-consensus/.../tests.rs:2343
mempool_expired_basic	zebrad/.../vectors.rs:247
mempool_transaction_expiration	zebrad/.../fake_peer_set.rs:335

4. Construct V4 with joinsplit data — 4 tests

These build V4 transactions with specific sprout JoinSplit data. Restorable via byte-level serialization (pattern already established in build_v4_tx_with_joinsplit_data in the anchors tests).

Test	File
v4_transaction_with_conflicting_sprout_nullifier_inside_joinsplit_is_rejected	zebra-consensus/.../tests.rs:1639
v4_transaction_with_conflicting_sprout_nullifier_across_joinsplits_is_rejected	zebra-consensus/.../tests.rs:1647
v4_with_modified_joinsplit_is_rejected	zebra-consensus/.../tests.rs:2073
v5_with_duplicate_orchard_action	zebra-consensus/.../tests.rs:2335

5. Mutate shielded data (sapling/orchard) — 4 tests (+ 2 from group 4)

These modify sapling/orchard shielded data after construction for negative testing.

Test	File
v5_transaction_with_orchard_actions_has_inputs_and_outputs	zebra-consensus/.../tests.rs:82
v5_transaction_with_orchard_actions_has_flags	zebra-consensus/.../tests.rs:92
v4_with_duplicate_sapling_spends	zebra-consensus/.../tests.rs:2159
v5_with_duplicate_sapling_spends	zebra-consensus/.../tests.rs:2294

Restoration Paths (in order of feasibility)

1. outputs_mut/inputs_mut tests (8): Add with_transparent_output_at(index, output) to Transaction — straightforward, similar to existing with_transparent_inputs().
2. expiry_height_mut tests (4): Add with_expiry_height(height) builder — straightforward via from_parts reconstruction.
3. Joinsplit construction tests (4): Use byte-level V4 transaction construction (pattern already established in build_v4_tx_with_joinsplit_data).
4. Fake orchard data tests (5): Requires constructing orchard bundles — best done in librustzcash with an orchard::testing module.
5. Shielded data mutation tests (4): Requires map_authorization or builder patterns in librustzcash.

Groups 1-3 (16 tests) can be restored entirely within Zebra. Groups 4-5 (9 tests, including 2 that overlap with group 4) likely need upstream librustzcash support.