feat(rpc): expose the Ironwood note commitment tree and subtrees - #10888
Merged
Conversation
arya2
reviewed
Jul 2, 2026
arya2
previously approved these changes
Jul 2, 2026
arya2
left a comment
Contributor
There was a problem hiding this comment.
Looks good pending a fix for the getblock RPC returning error for heights below NU6.3
arya2
previously approved these changes
Jul 2, 2026
jvff
previously approved these changes
Jul 2, 2026
upbqdn
force-pushed
the
ironwood-rpc-read-path
branch
from
July 2, 2026 18:48
9c3d5d0 to
2187d21
Compare
upbqdn
force-pushed
the
ironwood-rpc-read-path
branch
from
July 2, 2026 18:57
2187d21 to
e3a02fb
Compare
upbqdn
force-pushed
the
ironwood-review-fixes-2
branch
from
July 2, 2026 19:58
7b876e0 to
7655df2
Compare
upbqdn
force-pushed
the
ironwood-rpc-read-path
branch
from
July 2, 2026 19:58
e3a02fb to
5f90f58
Compare
conradoplg
dismissed stale reviews from arya2 and jvff
July 2, 2026 20:16
The base branch was changed.
Add the Ironwood read path that mirrors Orchard, so wallets and indexers can obtain Ironwood frontiers and subtree roots after NU6.3: - state: ReadRequest/ReadResponse IronwoodTree and IronwoodSubtrees variants, read::ironwood_tree / ironwood_subtrees, and the ZebraDb::ironwood_tree_by_hash_or_height accessor. - rpc: an ironwood treestate in z_gettreestate (present from NU6.3), the ironwood pool in z_getsubtreesbyindex, and the ironwood tree size in verbose getblock. All are skipped/omitted when empty, so pre-NU6.3 responses and fixtures are unchanged.
Collaborator
|
Not sure how it does not have conflicts, but should probably be rebased after #10886 merged |
upbqdn
force-pushed
the
ironwood-rpc-read-path
branch
from
July 2, 2026 20:30
5f90f58 to
51442b7
Compare
arya2
approved these changes
Jul 2, 2026
jvff
approved these changes
Jul 2, 2026
Collaborator
|
Admin-merging, tested locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Ironwood state (#10762) stores a note commitment tree and subtrees, but no read request or RPC exposes them, so a wallet or light-client indexer cannot obtain Ironwood frontiers or subtree roots after NU6.3 — the pool is spendable per consensus but unusable through Zebra's RPC surface. This adds the read path, mirroring Orchard. Stacks on #10886.
Solution
state:
ReadRequest::IronwoodTree/ReadRequest::IronwoodSubtreesand the matchingReadResponsevariants;read::ironwood_tree/read::ironwood_subtrees; theZebraDb::ironwood_tree_by_hash_or_heightaccessor; and the read-service handlers. These mirror the Orchard read path (Ironwood reuses the Orchard tree/node types in separate column families).rpc:
z_gettreestategains anironwoodtreestate, present only from NU6.3.z_getsubtreesbyindexacceptspool = "ironwood".getblockreports the Ironwood note-commitment-tree size undertrees.ironwood.All three are
Option/skip_serializing_if-empty andserde(default)on read, so pre-NU6.3 responses and existing fixtures are byte-for-byte unchanged.Tests
Local gate green on
d.lan:fmt --check,clippy --workspace --all-targets -D warnings,cargo doc, andnextestfor zebra-rpc (107) and zebra-state (149). The existingz_gettreestate/getblocksnapshot and serialization round-trip tests pass unchanged (Ironwood is empty/absent pre-NU6.3); theGetBlockTreesround-trip test now also carries the empty Ironwood tree.Specifications & References
Follow-up Work
None outstanding.
AI Disclosure
PR Checklist
type(scope): description