Skip to content

Commit 5c1019b

Browse files
revert: align three files to main after merge
test_no_flask_import, the test_miniofs comment, and the groups.yaml Fernet comment were intentionally dropped or shortened in #2115; keep main's version rather than the e2e branch's re-additions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017UVfw7aAocC3KCJaEyZ5GU
1 parent 8b39503 commit 5c1019b

3 files changed

Lines changed: 3 additions & 25 deletions

File tree

tests/groups.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ groups:
6666
# base.py resolves these at import time with no default; supply test-safe
6767
# values here.
6868
DJANGO_SECRET_KEY: test-secret-key-not-for-production
69-
# All-zero Fernet key: valid format, zero entropy so it reads as the
70-
# obvious test placeholder it is (not a real secret).
69+
# All-zero Fernet key: valid format, obviously a placeholder.
7170
ENCRYPTION_KEY: AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
7271
CELERY_BROKER_BASE_URL: redis://localhost:6379
7372
CELERY_BROKER_USER: guest

unstract/connectors/tests/filesystems/test_miniofs.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@ class TestMinoFS(unittest.TestCase):
2323
"Integration test requires a live MinIO and MINIO_ACCESS_KEY_ID + MINIO_SECRET_ACCESS_KEY",
2424
)
2525
def test_minio(self) -> None:
26-
# Endpoint comes from the rig (testcontainers MinIO) via
27-
# MINIO_ENDPOINT_URL; falls back to the local run-platform MinIO so a
28-
# developer can run this by hand. Real round-trip: create a bucket and
29-
# prove it shows up through the access-filtered listing.
26+
# Endpoint from the rig's testcontainers MinIO via MINIO_ENDPOINT_URL;
27+
# falls back to the local platform MinIO for manual runs.
3028
self.assertEqual(MinioFS.requires_oauth(), False)
3129
fs = MinioFS(
3230
{

workers/tests/test_legacy_executor_scaffold.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -249,25 +249,6 @@ def test_extraction_error_has_code_and_message(self):
249249
assert err.message == "extraction failed"
250250
assert err.code == 500
251251

252-
def test_no_flask_import(self):
253-
"""Verify exceptions module does NOT (transitively) import Flask.
254-
255-
Runs in a fresh interpreter: an in-process check would be polluted
256-
by whatever sibling tests already imported, and reloading the
257-
module in place would swap class identities under other tests.
258-
"""
259-
import os
260-
import subprocess
261-
import sys
262-
263-
code = (
264-
"import sys; import executor.executors.exceptions; "
265-
"flask = [m for m in sys.modules if m.startswith('flask')]; "
266-
"assert not flask, f'Flask modules imported: {flask}'"
267-
)
268-
env = {**os.environ, "PYTHONPATH": os.pathsep.join(sys.path)}
269-
subprocess.run([sys.executable, "-c", code], check=True, env=env)
270-
271252
def test_custom_data_error_signature(self):
272253
from executor.executors.exceptions import CustomDataError
273254

0 commit comments

Comments
 (0)