refactor: remove dead code across workspaces

amitsingh-007 · claude · amitsingh-007 · commit 9be66e927e8a · 2026-08-02T18:06:32.000+05:30
Nine confirmed-unused symbols, verified by repo-wide grep including both
Playwright suites as callers.

- trpc: drop the reqMetaData context field plus getIpAddress and
  FALLBACK_IP_ADDRESS. Two header parses ran on every request and nothing
  ever read the result; ITRPCContext collapses to { user }.
- shared: drop DEFAULT_RULE_ALIAS from e2e-tests constants. It had no
  importers and had drifted to 'http://///' against the real 'http:///' in
  ShortcutsPanel, so it was a trap rather than dead weight.
- shared: drop clickButtonByName and shouldRenderBookmarks. The latter
  reduced to contextBookmarks.length &gt; 0 because both params are
  non-nullable, so it is inlined at its two call sites.
- extension: drop searchAndVerify, the off-interface updateTaggedPersons and
  resetCutBookmarks store members (invisible to the compiler, so they would
  have rotted silently), setProgress/resetProgress, and fullName — a
  write-only duplicate of displayName that was being persisted to
  localStorage.
- web: drop the bookmarks localStorage write-back, which re-serialised the
  entire bookmark DB on every mount and folder navigation without changing
  anything.

Removing shouldRenderBookmarks also drops `folders` from the BookmarksPanel
useShallow selector, so that component no longer re-renders when folders
change.

Co-Authored-By: Claude Opus 5 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/apps/extension/src/entrypoints/popup/panels/BookmarksPanel/components/BookmarksPanel.tsx b/apps/extension/src/entrypoints/popup/panels/BookmarksPanel/components/BookmarksPanel.tsx
@@ -5,7 +5,6 @@ import {
   HEADER_HEIGHT,
   ScrollButton,
   getFilteredContextBookmarks,
-  shouldRenderBookmarks,
 } from '@bypass/shared';
 import { ScrollArea } from '@bypass/ui';
 import { useVirtualizer } from '@tanstack/react-virtual';
@@ -31,15 +30,13 @@ function BookmarksPanel({ folderId, operation, bmUrl }: BMPanelQueryParams) {
   );
   const {
     contextBookmarks,
-    folders,
     selectedBookmarks,
     cutBookmarks,
     isFetching,
     loadData,
   } = useBookmarkStore(
     useShallow((state) => ({
       contextBookmarks: state.contextBookmarks,
-      folders: state.folders,
       selectedBookmarks: state.selectedBookmarks,
       cutBookmarks: state.cutBookmarks,
       isFetching: state.isFetching,
@@ -117,7 +114,7 @@ function BookmarksPanel({ folderId, operation, bmUrl }: BMPanelQueryParams) {
             className="w-full"
             style={{ height: MAX_PANEL_SIZE.HEIGHT - HEADER_HEIGHT }}
           >
-            {shouldRenderBookmarks(folders, filteredContextBookmarks) ? (
+            {filteredContextBookmarks.length > 0 ? (
               <div
                 className="relative w-full"
                 style={{ height: virtualizer.getTotalSize() }}
diff --git a/apps/extension/src/entrypoints/popup/panels/BookmarksPanel/store/useBookmarkStore.ts b/apps/extension/src/entrypoints/popup/panels/BookmarksPanel/store/useBookmarkStore.ts
@@ -60,7 +60,6 @@ const useBookmarkStore = create<State>()((set, get) => ({
   cutBookmarks: [],
   isFetching: true,
   isSaveButtonActive: false,
-  updateTaggedPersons: [],
 
   async loadData(folderId: string) {
     set({ isSaveButtonActive: false, isFetching: true });
@@ -98,8 +97,6 @@ const useBookmarkStore = create<State>()((set, get) => ({
     set({ cutBookmarks: [...selectedBookmarks] });
   },
 
-  resetCutBookmarks: () => set({ cutBookmarks: [] }),
-
   handleCreateNewFolder(name: string, parentFolderId: string) {
     const { contextBookmarks, folderList } = get();
     const isDir = true;
diff --git a/apps/extension/src/interfaces/firebase.ts b/apps/extension/src/interfaces/firebase.ts
@@ -1,7 +1,6 @@
 export interface IAuthResponse {
   readonly uid: string;
   readonly email: string;
-  readonly fullName: string;
   readonly photoUrl?: string;
   readonly displayName?: string;
   readonly expiresIn: number;
diff --git a/apps/extension/src/store/firebase/api.ts b/apps/extension/src/store/firebase/api.ts
@@ -32,7 +32,6 @@ export const signInWithCredential = async (accessToken: string) => {
     .json<IAuthResponse>((res) => ({
       uid: res.localId,
       email: res.email,
-      fullName: res.displayName,
       photoUrl: res.photoUrl,
       displayName: res.displayName,
       idToken: res.idToken,
diff --git a/apps/extension/src/store/progress.ts b/apps/extension/src/store/progress.ts
@@ -5,9 +5,7 @@ interface ProgressState {
   progress: number;
   startLoading: () => void;
   stopLoading: () => void;
-  setProgress: (progress: number) => void;
   incrementProgress: (totalSteps: number) => void;
-  resetProgress: () => void;
 }
 
 const useProgressStore = create<ProgressState>()((set, get) => ({
@@ -21,18 +19,12 @@ const useProgressStore = create<ProgressState>()((set, get) => ({
       set(() => ({ isLoading: false, progress: 0 }));
     }, 300); // 300ms delay allows users to see progress at 100% before overlay disappears
   },
-  setProgress(progress: number) {
-    set(() => ({ progress }));
-  },
   incrementProgress(totalSteps: number) {
     const { progress } = get();
     const stepSize = 100 / totalSteps;
     const newProgress = Math.min(progress + stepSize, 100);
     set(() => ({ progress: newProgress }));
   },
-  resetProgress() {
-    set(() => ({ progress: 0 }));
-  },
 }));
 
 export default useProgressStore;
diff --git a/apps/extension/tests/auth.setup.ts b/apps/extension/tests/auth.setup.ts
@@ -38,7 +38,6 @@ const signInWithEmailAndPassword = async (): Promise<IAuthResponse> => {
     .json<IAuthResponse>((res) => ({
       uid: res.localId,
       email: res.email,
-      fullName: res.displayName,
       photoUrl: '',
       displayName: res.displayName,
       idToken: res.idToken,
diff --git a/apps/extension/tests/utils/test-utils.ts b/apps/extension/tests/utils/test-utils.ts
@@ -1,7 +1,4 @@
-import {
-  fillSearchInput as fillSearchInputShared,
-  parseBadgeCount,
-} from '@bypass/shared/tests';
+import { parseBadgeCount } from '@bypass/shared/tests';
 import { expect, type Page } from '@playwright/test';
 
 // Re-export shared utilities for convenience
@@ -83,38 +80,6 @@ export const openFolder = async (page: Page, folderName: string) => {
   await folder.click();
 };
 
-interface SearchAndVerifyOptions {
-  visibleTexts: string[];
-  hiddenTexts?: string[];
-  selector?: string;
-}
-
-/**
- * Search and verify elements are visible/not visible.
- */
-export const searchAndVerify = async (
-  page: Page,
-  searchText: string,
-  options: SearchAndVerifyOptions
-) => {
-  const {
-    visibleTexts,
-    hiddenTexts = [],
-    selector = '[data-testid^="person-item-"]',
-  } = options;
-  await fillSearchInputShared(page, searchText);
-
-  for (const text of visibleTexts) {
-    const element = page.locator(selector).filter({ hasText: text });
-    await expect(element).toBeVisible();
-  }
-
-  for (const text of hiddenTexts) {
-    const element = page.locator(selector).filter({ hasText: text });
-    await expect(element).not.toBeVisible();
-  }
-};
-
 /**
  * Get item from chrome.storage.local
  */
diff --git a/apps/web/src/app/bookmark-panel/page.tsx b/apps/web/src/app/bookmark-panel/page.tsx
@@ -9,15 +9,14 @@ import {
   getFolderName,
   Header,
   type IBookmarksObj,
-  shouldRenderBookmarks,
   STORAGE_KEYS,
 } from '@bypass/shared';
 import { ScrollArea } from '@bypass/ui';
 import { useVirtualizer } from '@tanstack/react-virtual';
 import { useSearchParams } from 'next/navigation';
 import { useCallback, useEffect, useRef, useState } from 'react';
 
-import { getFromLocalStorage, setToLocalStorage } from '@app/utils/storage';
+import { getFromLocalStorage } from '@app/utils/storage';
 
 import VirtualRow from './components/VirtualRow';
 
@@ -61,7 +60,6 @@ export default function BookmarksPage() {
     setContextBookmarks(modifiedBookmarks);
     setFolders(foldersData);
     setFolderName(getFolderName(folderListData, folderId));
-    setToLocalStorage(STORAGE_KEYS.bookmarks, bookmarksData);
   }, [folderId]);
 
   useEffect(() => {
@@ -77,7 +75,7 @@ export default function BookmarksPage() {
         onSearchChange={handleSearchTextChange}
       />
       <ScrollArea viewportRef={scrollAreaRef} className="flex-1">
-        {shouldRenderBookmarks(folders, filteredContextBookmarks) ? (
+        {filteredContextBookmarks.length > 0 ? (
           <div
             style={{ height: virtualizer.getTotalSize() }}
             className="relative w-full"
diff --git a/packages/shared/src/components/Bookmarks/utils/index.ts b/packages/shared/src/components/Bookmarks/utils/index.ts
@@ -29,11 +29,6 @@ export const getFilteredContextBookmarks = (
     return hasText(searchText, ctx.url) || hasText(searchText, ctx.title);
   });
 
-export const shouldRenderBookmarks = (
-  folders: IBookmarksObj['folders'],
-  contextBookmarks: ContextBookmarks
-) => folders && contextBookmarks && contextBookmarks.length > 0;
-
 export const getEncryptedBookmark = (
   bookmark: IEncodedBookmark
 ): IEncodedBookmark => ({
diff --git a/packages/shared/src/constants/e2e-tests.ts b/packages/shared/src/constants/e2e-tests.ts
@@ -53,11 +53,6 @@ export const TEST_SITES = {
   EXAMPLE_NET: 'https://example.net',
 } as const;
 
-/**
- * Default rule alias that indicates an incomplete rule.
- */
-export const DEFAULT_RULE_ALIAS = 'http://///';
-
 /**
  * Timeout constants used across test files to avoid magic numbers.
  */
diff --git a/packages/shared/src/utils/test-helpers.ts b/packages/shared/src/utils/test-helpers.ts
@@ -77,22 +77,6 @@ export const clearSearchInput = async (page: Page, placeholder = 'Search') => {
   await expect(searchInput).toHaveValue('');
 };
 
-/**
- * Click a button by its visible text/label.
- */
-export const clickButtonByName = async (
-  page: Page,
-  name: string | RegExp,
-  options?: { exact?: boolean; within?: ReturnType<Page['locator']> }
-) => {
-  const scope = options?.within ?? page;
-  const button = scope.getByRole('button', {
-    name,
-    exact: options?.exact ?? false,
-  });
-  await button.click();
-};
-
 /**
  * Get the count from a badge text in format "Name (N)" or just "(N)".
  */
diff --git a/packages/trpc/src/@types/trpc.ts b/packages/trpc/src/@types/trpc.ts
@@ -8,9 +8,5 @@ export interface IUser {
 }
 
 export interface ITRPCContext {
-  reqMetaData: {
-    ip: string | null;
-    userAgent: string | null;
-  };
   user: IUser | null;
 }
diff --git a/packages/trpc/src/trpc.ts b/packages/trpc/src/trpc.ts
@@ -5,7 +5,7 @@ import {
   getFirebaseUser,
   verifyAuthToken,
 } from './services/firebaseAdminService';
-import { getAuthBearer, getIpAddress } from './utils/headers';
+import { getAuthBearer } from './utils/headers';
 
 const getLoggedInUser = async (idToken: string | undefined) => {
   if (!idToken) {
@@ -26,19 +26,9 @@ const getLoggedInUser = async (idToken: string | undefined) => {
 export const createTRPCContext = async (
   req: Request
 ): Promise<ITRPCContext> => {
-  const { headers } = req;
-  const ip = getIpAddress(req);
-  const userAgent = headers.get('user-agent');
-  const bearerToken = getAuthBearer(req);
-  const user = await getLoggedInUser(bearerToken);
+  const user = await getLoggedInUser(getAuthBearer(req));
 
-  return {
-    reqMetaData: {
-      ip,
-      userAgent,
-    },
-    user,
-  };
+  return { user };
 };
 
 export const t = initTRPC
diff --git a/packages/trpc/src/utils/headers.ts b/packages/trpc/src/utils/headers.ts
@@ -1,16 +1,2 @@
-const FALLBACK_IP_ADDRESS = '0.0.0.0';
-
-/**
- * @link https://nextjs.org/docs/app/api-reference/functions/headers#ip-address
- */
-export const getIpAddress = (req: Request) => {
-  const { headers } = req;
-  const forwardedFor = headers.get('x-forwarded-for');
-  if (forwardedFor) {
-    return forwardedFor.split(',')[0] ?? FALLBACK_IP_ADDRESS;
-  }
-  return headers.get('x-real-ip') ?? FALLBACK_IP_ADDRESS;
-};
-
 export const getAuthBearer = (req: Request) =>
   req.headers.get('authorization')?.split?.('Bearer ')?.[1];
