Count tests correctly under --parallel, and drop attach/detach from CI

The no-tests-ran guard fired on every CI run while the suite was green
locally. swift test reports differently depending on --parallel and
neither format is a superset of the other: serially it prints "Executed N
tests" plus a "Test Case ... passed" line per test, in parallel it prints
neither and emits only "[n/total] Testing Suite/name" progress lines. CI
passes --parallel; local runs here did not.

So the counter saw nothing, reported 0, and the guard I added to catch a
suite that runs no tests instead blocked a suite running 418 of them. The
guard was right to be loud — it was the count feeding it that was wrong.
It now tries the serial summary, then the parallel progress denominator,
then per-case lines, and both real log formats resolve to 418.

The completion-scripts job also asserted that generated completions list
attach and detach, which were removed in the previous commit for being
commands that only ever threw.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CmKz41eeUtZesAswErwocH

Author: beriberikix

.github/actions/run-test-suite/action.yml

@@ -333,17 +333,32 @@ runs:
 
         # Count what actually ran, from the test output. Never estimate: an
         # invented number is what let a suite that executed nothing look healthy.
-        # Prefer XCTest's own summary line. Counting "Test Case ... passed|failed"
-        # lines under-reports badly with --parallel, which emits a line for failures
-        # but not for passes: a run of 422 tests with 35 failures was reported as
-        # "35 executed". Take the largest "Executed N tests" figure, which is the
-        # per-target totals followed by the overall total.
+        # swift test reports differently depending on --parallel, and neither format
+        # is a superset of the other:
+        #
+        #   serial:   "Executed 418 tests, with 0 failures ..."   plus a
+        #             "Test Case '-[...]' passed" line per test
+        #   parallel: neither of those. Progress only: "[418/418] Testing Suite/name"
+        #
+        # Counting "Test Case" lines under --parallel reported a 422-test run with 35
+        # failures as "35 executed" (only failures get a line). Reading only the
+        # "Executed N" summary reported 0 under --parallel, which tripped the
+        # no-tests-ran guard below on every CI run while the suite was green locally.
+        #
+        # Try each shape, most authoritative first.
         TESTS_RUN=$(grep -oE "Executed [0-9]+ test" "$TEST_LOG" \
                     | grep -oE "[0-9]+" | sort -n | tail -1 || true)
         TESTS_RUN=${TESTS_RUN:-0}
 
         if [ "$TESTS_RUN" -eq 0 ]; then
-          # No summary line (very old output format): fall back to counting cases.
+          # Parallel progress lines: take the denominator of "[n/total] Testing ...".
+          TESTS_RUN=$(grep -oE "^\[[0-9]+/[0-9]+\] Testing " "$TEST_LOG" \
+                      | grep -oE "/[0-9]+\]" | grep -oE "[0-9]+" | sort -n | tail -1 || true)
+          TESTS_RUN=${TESTS_RUN:-0}
+        fi
+
+        if [ "$TESTS_RUN" -eq 0 ]; then
+          # Last resort for older output formats.
           TESTS_RUN=$(grep -cE "^Test Case .* (passed|failed)" "$TEST_LOG" 2>/dev/null || true)
           TESTS_RUN=${TESTS_RUN:-0}
         fi

.github/workflows/ci.yml

@@ -275,7 +275,9 @@ jobs:
           echo "Verifying completion script content..."
           
           # Expected commands that should be in completion scripts
-          EXPECTED_COMMANDS=("help" "list" "bind" "unbind" "attach" "detach" "daemon" "install-system-extension" "diagnose" "completion")
+          # attach/detach were removed: usbipd is the USB/IP server, and both only ever
+          # threw operationNotSupported while appearing in help and completions.
+          EXPECTED_COMMANDS=("help" "list" "bind" "unbind" "daemon" "install-system-extension" "diagnose" "completion")
           
           for cmd in "${EXPECTED_COMMANDS[@]}"; do
             echo "Checking for command: $cmd"