fix: resolve test compilation errors and add SharedUtilities to all test targets

- Add SharedUtilities sources to all test targets in Package.swift
- Fix USBIPUnlinkRequest parameter order in USBRequestProcessorTests
- Fix USBSpeed enum case from .highSpeed to .high
- Resolve duplicate responseData variable declaration
- Add MockDeviceClaimManager to RequestProcessor constructors
- Fix USBIPCommand references to USBIPProtocol.Command
- Add type annotation for USBSubmitProcessor initialization

Author: beriberikix

.spec-workflow/specs/automated-production-release/tasks.md

@@ -213,7 +213,7 @@ The implementation follows a systematic approach to build the automated producti
   - _Requirements: Code quality standards_
   - _Leverage: existing build and test infrastructure_
 
-- [-] 27. Create pull request and monitor CI validation
+- [x] 27. Create pull request and monitor CI validation
   - Push feature branch and create comprehensive pull request
   - Monitor CI pipeline execution and resolve any integration issues
   - Ensure all GitHub Actions workflows pass validation

Package.swift

@@ -63,16 +63,20 @@ let package = Package(
             ]),
         .testTarget(
             name: "USBIPDCoreTests",
-            dependencies: ["USBIPDCore"]),
+            dependencies: ["USBIPDCore"],
+            sources: [".", "../SharedUtilities"]),
         .testTarget(
             name: "USBIPDCLITests",
-            dependencies: ["USBIPDCLI"]),
+            dependencies: ["USBIPDCLI"],
+            sources: [".", "../SharedUtilities"]),
         .testTarget(
             name: "IntegrationTests",
-            dependencies: ["USBIPDCore", "QEMUTestServer", "USBIPDCLI", "SystemExtension", "Common"]),
+            dependencies: ["USBIPDCore", "QEMUTestServer", "USBIPDCLI", "SystemExtension", "Common"],
+            sources: [".", "../SharedUtilities"]),
         .testTarget(
             name: "SystemExtensionTests",
-            dependencies: ["SystemExtension", "Common"]),
+            dependencies: ["SystemExtension", "Common"],
+            sources: [".", "../SharedUtilities"]),
         .testTarget(
             name: "QEMUIntegrationTests",
             dependencies: ["QEMUTestServer", "USBIPDCore", "Common"],

Tests/IntegrationTests/QEMUUSBIPProtocolTests.swift

@@ -686,7 +686,7 @@ extension QEMUUSBIPProtocolTests {
     }
 
     /// Helper to validate USB/IP header structure
-    private func validateUSBIPHeader(_ header: USBIPHeader, expectedCommand: USBIPCommand) {
+    private func validateUSBIPHeader(_ header: USBIPHeader, expectedCommand: USBIPProtocol.Command) {
         XCTAssertEqual(header.version, USBIPProtocol.version, "Header version should match protocol")
         XCTAssertEqual(header.command, expectedCommand, "Header command should match expected")
         XCTAssertEqual(header.status, 0, "Header status should be success for normal operations")

Tests/USBIPDCoreTests/Protocol/USBRequestProcessorTests.swift

@@ -24,7 +24,7 @@ final class USBRequestProcessorTests: XCTestCase {
         mockDeviceCommunicator = MockUSBDeviceCommunicator()
         urbTracker = URBTracker()
 
-        submitProcessor = USBSubmitProcessor(deviceCommunicator: mockDeviceCommunicator)
+        submitProcessor = USBSubmitProcessor(deviceCommunicator: mockDeviceCommunicator as USBDeviceCommunicator)
         unlinkProcessor = USBUnlinkProcessor(submitProcessor: submitProcessor)
 
         testDevice = createTestDevice()
@@ -54,7 +54,7 @@ final class USBRequestProcessorTests: XCTestCase {
             deviceClass: 0x09,
             deviceSubClass: 0x00,
             deviceProtocol: 0x00,
-            speed: .highSpeed,
+            speed: .high,
             manufacturerString: "Test Manufacturer",
             productString: "Test Device",
             serialNumberString: "TEST001"
@@ -100,10 +100,10 @@ final class USBRequestProcessorTests: XCTestCase {
     ) throws -> Data {
         let request = USBIPUnlinkRequest(
             seqnum: seqnum,
+            unlinkSeqnum: unlinkSeqnum,
             devid: devid,
             direction: direction,
-            ep: endpoint,
-            unlinkSeqnum: unlinkSeqnum
+            ep: endpoint
         )
 
         return try request.encode()
@@ -113,8 +113,8 @@ final class USBRequestProcessorTests: XCTestCase {
 
     func testProcessSubmitRequestControlTransferSuccess() async throws {
         // Configure mock for control transfer success
-        let responseData = Data([0x12, 0x01, 0x00, 0x02, 0x09, 0x00, 0x00, 0x40]) // Device descriptor
-        mockDeviceCommunicator.setControlTransferResponse(responseData)
+        let mockResponseData = Data([0x12, 0x01, 0x00, 0x02, 0x09, 0x00, 0x00, 0x40]) // Device descriptor
+        mockDeviceCommunicator.setControlTransferResponse(mockResponseData)
 
         // Create control transfer request (GET_DESCRIPTOR)
         let setupPacket = Data([0x80, 0x06, 0x00, 0x01, 0x00, 0x00, 0x12, 0x00])

Tests/USBIPDCoreTests/RequestProcessorTests.swift

@@ -79,7 +79,8 @@ class RequestProcessorTests: XCTestCase {
         let device = createSampleDevice()
         deviceDiscovery.devices = [device]
 
-        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery)
+        let mockDeviceClaimManager = MockDeviceClaimManager()
+        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery, deviceClaimManager: mockDeviceClaimManager)
         let requestData = createDeviceListRequest()
 
         // Act
@@ -90,7 +91,7 @@ class RequestProcessorTests: XCTestCase {
 
         // Decode the response to verify it
         let response = try USBIPMessageDecoder.decodeDeviceListResponse(from: responseData)
-        XCTAssertEqual(response.header.command, .replyDeviceList, "Response should be a device list reply")
+        XCTAssertEqual(response.header.command, USBIPProtocol.Command.replyDeviceList, "Response should be a device list reply")
         XCTAssertEqual(response.header.status, 0, "Status should be success (0)")
         XCTAssertEqual(response.deviceCount, 1, "Response should contain 1 device")
         XCTAssertEqual(response.devices.count, 1, "Response should contain 1 device")
@@ -108,7 +109,8 @@ class RequestProcessorTests: XCTestCase {
         let deviceDiscovery = MockDeviceDiscovery()
         deviceDiscovery.devices = []
 
-        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery)
+        let mockDeviceClaimManager = MockDeviceClaimManager()
+        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery, deviceClaimManager: mockDeviceClaimManager)
         let requestData = createDeviceListRequest()
 
         // Act
@@ -119,7 +121,7 @@ class RequestProcessorTests: XCTestCase {
 
         // Decode the response to verify it
         let response = try USBIPMessageDecoder.decodeDeviceListResponse(from: responseData)
-        XCTAssertEqual(response.header.command, .replyDeviceList, "Response should be a device list reply")
+        XCTAssertEqual(response.header.command, USBIPProtocol.Command.replyDeviceList, "Response should be a device list reply")
         XCTAssertEqual(response.header.status, 0, "Status should be success (0)")
         XCTAssertEqual(response.deviceCount, 0, "Response should contain 0 devices")
         XCTAssertEqual(response.devices.count, 0, "Response should contain 0 devices")
@@ -131,7 +133,8 @@ class RequestProcessorTests: XCTestCase {
         let device = createSampleDevice()
         deviceDiscovery.devices = [device]
 
-        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery)
+        let mockDeviceClaimManager = MockDeviceClaimManager()
+        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery, deviceClaimManager: mockDeviceClaimManager)
         let requestData = createDeviceImportRequest(busID: "1-1:1.0")
 
         // Act
@@ -144,7 +147,7 @@ class RequestProcessorTests: XCTestCase {
 
         // Decode the response to verify it
         let response = try USBIPMessageDecoder.decodeDeviceImportResponse(from: responseData)
-        XCTAssertEqual(response.header.command, .replyDeviceImport, "Response should be a device import reply")
+        XCTAssertEqual(response.header.command, USBIPProtocol.Command.replyDeviceImport, "Response should be a device import reply")
         XCTAssertEqual(response.header.status, 0, "Status should be success (0)")
         XCTAssertEqual(response.status, 0, "Status should be success (0)")
         XCTAssertNotNil(response.deviceInfo, "Device info should be present")
@@ -162,7 +165,8 @@ class RequestProcessorTests: XCTestCase {
         let deviceDiscovery = MockDeviceDiscovery()
         deviceDiscovery.devices = [] // No devices available
 
-        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery)
+        let mockDeviceClaimManager = MockDeviceClaimManager()
+        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery, deviceClaimManager: mockDeviceClaimManager)
         let requestData = createDeviceImportRequest(busID: "1-1:1.0")
 
         // Act
@@ -173,15 +177,16 @@ class RequestProcessorTests: XCTestCase {
 
         // Decode the response to verify it
         let response = try USBIPMessageDecoder.decodeDeviceImportResponse(from: responseData)
-        XCTAssertEqual(response.header.command, .replyDeviceImport, "Response should be a device import reply")
+        XCTAssertEqual(response.header.command, USBIPProtocol.Command.replyDeviceImport, "Response should be a device import reply")
         XCTAssertEqual(response.status, 1, "Status should be error (1)")
         XCTAssertNil(response.deviceInfo, "Device info should not be present for error response")
     }
 
     func testProcessInvalidRequest() throws {
         // Arrange
         let deviceDiscovery = MockDeviceDiscovery()
-        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery)
+        let mockDeviceClaimManager = MockDeviceClaimManager()
+        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery, deviceClaimManager: mockDeviceClaimManager)
 
         // Create an invalid request with incorrect data
         let invalidData = Data([0x01, 0x02, 0x03, 0x04])
@@ -193,7 +198,8 @@ class RequestProcessorTests: XCTestCase {
     func testProcessUnsupportedCommand() throws {
         // Arrange
         let deviceDiscovery = MockDeviceDiscovery()
-        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery)
+        let mockDeviceClaimManager = MockDeviceClaimManager()
+        let processor = RequestProcessor(deviceDiscovery: deviceDiscovery, deviceClaimManager: mockDeviceClaimManager)
 
         // Create a reply message (which should not be processed as a request)
         let header = USBIPHeader(command: .replyDeviceList)