Merge pull request #3599 from codeeu/feature/support-email-update

Support copilot: add user_email_update

Author: bernardhanna

app/Jobs/Support/ExecuteApprovedSupportActionJob.php

@@ -11,6 +11,7 @@
 use App\Services\Support\SupportApprovalEmailService;
 use App\Services\Support\UserProfileUpdateService;
 use App\Services\Support\UserRestoreService;
+use App\Services\Support\UserEmailUpdateService;
 use App\Services\Support\UserRoleAddService;
 use App\Services\Support\UserRoleRemoveService;
 use Illuminate\Bus\Queueable;
@@ -37,6 +38,7 @@ public function handle(
         ContentUpdateService $contentUpdate,
         UserRoleAddService $userRoleAdd,
         UserRoleRemoveService $userRoleRemove,
+        UserEmailUpdateService $userEmailUpdate,
     ): void
     {
         $approval = SupportApproval::findOrFail($this->supportApprovalId);
@@ -96,6 +98,8 @@ public function handle(
             $result = $userRoleAdd->addFromCase($case, dryRun: false, viaEmailApproval: true);
         } elseif ($action === 'user_role_remove') {
             $result = $userRoleRemove->removeFromCase($case, dryRun: false, viaEmailApproval: true);
+        } elseif ($action === 'user_email_update') {
+            $result = $userEmailUpdate->updateFromCase($case, dryRun: false, viaEmailApproval: true);
         } elseif ($action === 'code_change') {
             $result = $cursorAgent->launchCodeAgent(
                 prompt: (string) ($payload['cursor_prompt'] ?? ''),

app/Jobs/Support/ProcessSupportCaseDiagnosticsJob.php

@@ -12,6 +12,7 @@
 use App\Services\Support\UserProfileUpdateService;
 use App\Services\Support\UserRestoreService;
 use App\Services\Support\UserRoleAddService;
+use App\Services\Support\UserEmailUpdateService;
 use App\Services\Support\UserRoleRemoveService;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
@@ -34,6 +35,7 @@ public function handle(
         UserProfileUpdateService $userProfileUpdate,
         UserRoleAddService $userRoleAdd,
         UserRoleRemoveService $userRoleRemove,
+        UserEmailUpdateService $userEmailUpdate,
         ArtisanCommandRunner $artisanRunner,
         ContentUpdateService $contentUpdate,
     ): void {
@@ -81,6 +83,20 @@ public function handle(
             );
         }
 
+        if ($case->case_type === 'email_change') {
+            $dryRunResult = $userEmailUpdate->updateFromCase($case, dryRun: true);
+            $logger->log(
+                case: $case,
+                actionName: 'user_email_update',
+                actionType: 'write',
+                input: ['dry_run' => true],
+                output: $dryRunResult,
+                succeeded: (bool) ($dryRunResult['ok'] ?? false),
+                executedBy: 'agent',
+                correlationId: $case->correlation_id,
+            );
+        }
+
         if ($case->case_type === 'role_remove') {
             $dryRunResult = $userRoleRemove->removeFromCase($case, dryRun: true);
             $logger->log(

app/Services/Support/Agents/CursorCliTriageProvider.php

@@ -29,6 +29,7 @@ class CursorCliTriageProvider implements TriageProvider
         'role_issue',
         'role_add',
         'role_remove',
+        'email_change',
         'code_change',
         'artisan_command',
         'content_update',
@@ -142,6 +143,8 @@ private function buildPrompt(SupportCase $case, string $rawText): string
 Use "role_remove" when the request is to remove/revoke/delete a role (e.g. "ambassador") from one
 or more users. Use the same target_email/secondary_emails and role_name fields, and set
 "role_operation" to "remove".
+Use "email_change" when the request is to change/update a user's login email address. Put the
+current account email in target_email/current_email and the requested new email in new_email.
 {$artisanBlock}{$contentBlock}
 JSON schema to return:
 {
@@ -157,6 +160,8 @@ private function buildPrompt(SupportCase $case, string $rawText): string
   "profile_lastname": "<requested last name or null>",
   "role_name": "<for role_add/role_remove: the role affected, else null>",
   "role_operation": "<for role_add: add; for role_remove: remove; else null>",
+  "current_email": "<for email_change: the account email today, else null>",
+  "new_email": "<for email_change: the requested new email, else null>",
   "change_summary": "<for code_change: one sentence describing the fix, else null>",
   "change_area": "<for code_change: e.g. frontend/blade/css/js, else null>",
   "cursor_prompt": "<for code_change: a precise instruction for a coding agent to implement the fix and open a PR, else null>",
@@ -301,6 +306,7 @@ private function normalize(array $data): array
             'account_restore' => 'user_restore',
             'role_add' => 'user_role_add',
             'role_remove' => 'user_role_remove',
+            'email_change' => 'user_email_update',
             'code_change' => 'code_change',
             'artisan_command' => 'artisan_command',
             'content_update' => 'content_update',
@@ -332,6 +338,8 @@ private function normalize(array $data): array
             'profile_lastname' => $this->stringOrNull($data['profile_lastname'] ?? null),
             'role_name' => $this->stringOrNull($data['role_name'] ?? null),
             'role_operation' => $this->normalizeRoleOperation($data['role_operation'] ?? null),
+            'current_email' => $this->stringOrNull($data['current_email'] ?? null),
+            'new_email' => $this->stringOrNull($data['new_email'] ?? null),
             'risk_level' => $risk,
             'recommended_runbook' => $this->stringOrNull($data['recommended_runbook'] ?? null) ?? $caseType,
             'needs_human_review' => (bool) ($data['needs_human_review'] ?? false),

app/Services/Support/Agents/TriageAgentService.php

@@ -3,6 +3,7 @@
 namespace App\Services\Support\Agents;
 
 use App\Models\Support\SupportCase;
+use App\Services\Support\SupportEmailChangeRequestParser;
 use App\Services\Support\SupportProfileRequestParser;
 use App\Services\Support\SupportRoleRequestParser;
 use Illuminate\Support\Str;
@@ -11,6 +12,7 @@ class TriageAgentService
 {
     public function __construct(
         private readonly SupportProfileRequestParser $profileParser,
+        private readonly SupportEmailChangeRequestParser $emailChangeParser,
         private readonly CursorCliTriageProvider $aiProvider,
         private readonly SupportRoleRequestParser $roleParser,
     ) {
@@ -58,7 +60,9 @@ private function heuristicTriage(SupportCase $case): array
         $rawText = (string) ($case->normalized_message ?? $case->raw_message ?? '');
         $text = Str::lower($rawText);
         $profile = $this->profileParser->parse($rawText);
+        $emailChange = $this->emailChangeParser->parse($rawText);
         $roleRequest = $this->roleParser->parse($rawText);
+        $hasEmailChangeRequest = $emailChange['from_email'] !== null && $emailChange['to_email'] !== null;
         $hasRoleAddRequest = $roleRequest['role'] !== null
             && $roleRequest['operation'] === 'add'
             && $roleRequest['emails'] !== [];
@@ -76,6 +80,9 @@ private function heuristicTriage(SupportCase $case): array
         } elseif ($hasRoleAddRequest) {
             $caseType = 'role_add';
             $runbook = 'add_user_role';
+        } elseif ($hasEmailChangeRequest) {
+            $caseType = 'email_change';
+            $runbook = 'update_user_email';
         } elseif (Str::contains($text, ['soft-deleted', 'deleted', 'restore account', 'account missing'])) {
             $caseType = 'account_restore';
             $runbook = 'restore_deleted_account';
@@ -107,6 +114,9 @@ private function heuristicTriage(SupportCase $case): array
         if ($hasRoleRequest) {
             $targetEmail = $roleRequest['emails'][0];
             $secondary = array_values(array_slice($roleRequest['emails'], 1));
+        } elseif ($hasEmailChangeRequest) {
+            $targetEmail = $emailChange['from_email'];
+            $secondary = [$emailChange['to_email']];
         } else {
             $targetEmail = $profile['email'] ?? $this->extractFirstEmail($text);
             $secondary = $this->extractAllEmails($text);
@@ -117,6 +127,9 @@ private function heuristicTriage(SupportCase $case): array
         if ($caseType === 'profile_update') {
             $risk = 'low';
         }
+        if ($caseType === 'email_change') {
+            $risk = 'medium';
+        }
         if ($hasRoleRequest && $this->roleLooksPrivileged((string) $roleRequest['role'])) {
             $risk = 'high';
         }
@@ -128,6 +141,7 @@ private function heuristicTriage(SupportCase $case): array
             'profile_update' => 'user_profile_update',
             'role_add' => 'user_role_add',
             'role_remove' => 'user_role_remove',
+            'email_change' => 'user_email_update',
             default => null,
         };
 
@@ -142,6 +156,8 @@ private function heuristicTriage(SupportCase $case): array
             'profile_lastname' => $profile['lastname'],
             'role_name' => $hasRoleRequest ? $roleRequest['role'] : null,
             'role_operation' => $hasRoleRequest ? $roleRequest['operation'] : null,
+            'current_email' => $hasEmailChangeRequest ? $emailChange['from_email'] : null,
+            'new_email' => $hasEmailChangeRequest ? $emailChange['to_email'] : null,
             'risk_level' => $risk,
             'recommended_runbook' => $runbook,
             'needs_human_review' => $needsHuman,

app/Services/Support/SupportApprovalEmailService.php

@@ -16,6 +16,7 @@ public function __construct(
         private readonly SupportSenderAllowlist $allowlist,
         private readonly SupportProfileRequestParser $profileParser,
         private readonly SupportRoleRequestResolver $roleResolver,
+        private readonly SupportEmailChangeRequestResolver $emailChangeResolver,
     ) {
     }
 
@@ -24,6 +25,7 @@ public function approvalSubject(SupportCase $case): string
         $prefix = (string) config('support_gmail.approval_subject_prefix', '[CW-SUPPORT');
         $headline = match ($case->case_type) {
             'profile_update' => 'Please review — name change',
+            'email_change' => 'Please review — account email change',
             'account_restore' => 'Please review — account restore',
             'role_add' => 'Please review — add user role',
             'role_remove' => 'Please review — remove user role',
@@ -269,6 +271,19 @@ private function proposedActionForCase(SupportCase $case): array
             ];
         }
 
+        if ($case->case_type === 'email_change') {
+            $change = $this->emailChangeResolver->resolve($case);
+            if ($change['from_email'] !== null && $change['to_email'] !== null) {
+                return [
+                    'action' => 'user_email_update',
+                    'payload' => [
+                        'from' => $change['from_email'],
+                        'to' => $change['to_email'],
+                    ],
+                ];
+            }
+        }
+
         if ($case->case_type === 'profile_update' && $case->target_email) {
             $profile = $this->profileParser->parse((string) ($case->normalized_message ?? $case->raw_message ?? ''));
             if ($profile['firstname'] !== null || $profile['lastname'] !== null) {
@@ -503,7 +518,11 @@ private function dryRunPlannedChangeLines(SupportCase $case, array $proposedActi
     {
         $action = $proposedAction['action'] ?? 'none';
         $payload = $proposedAction['payload'] ?? [];
-        $email = (string) ($case->target_email ?? $payload['email'] ?? '');
+        $email = (string) ($case->target_email ?? $payload['email'] ?? $payload['from'] ?? '');
+
+        if ($action === 'user_email_update') {
+            return $this->dryRunEmailChangeLines($case, $payload);
+        }
 
         if ($action === 'user_profile_update') {
             return $this->dryRunProfileChangeLines($case, $payload, $email);
@@ -540,6 +559,48 @@ private function dryRunPlannedChangeLines(SupportCase $case, array $proposedActi
         ];
     }
 
+    /**
+     * @param array<string, mixed> $payload
+     * @return list<string>
+     */
+    private function dryRunEmailChangeLines(SupportCase $case, array $payload): array
+    {
+        $output = $case->actions()
+            ->where('action_name', 'user_email_update')
+            ->where('action_type', 'write')
+            ->latest()
+            ->first()?->output_json;
+
+        $result = is_array($output) ? ($output['result'] ?? []) : [];
+        $from = (string) ($result['before']['email'] ?? $payload['from'] ?? $case->target_email ?? '');
+        $to = (string) ($result['after']['email'] ?? $payload['to'] ?? '');
+        $note = (string) ($result['note'] ?? '');
+
+        if ($note === 'email_already_matches_requested_value') {
+            return [
+                '',
+                'The account already uses '.$to.'.',
+                'Approving will make no change.',
+            ];
+        }
+
+        $lines = [
+            '',
+            'We will update the login email on this CodeWeek account:',
+            '  • From: '.($from !== '' ? $from : '(not found)'),
+            '  • To:   '.($to !== '' ? $to : '(not found)'),
+        ];
+
+        if (($result['would_update_email_display'] ?? false) === true) {
+            $lines[] = '  • The public display email will be updated to match.';
+        }
+
+        $lines[] = '';
+        $lines[] = 'The person will need to verify the new email address before it is fully active.';
+
+        return $lines;
+    }
+
     /**
      * @param array<string, mixed> $payload
      * @return list<string>
@@ -829,6 +890,7 @@ private function completionHeadline(SupportCase $case, string $action, bool $suc
 
         return match ($action) {
             'user_profile_update' => 'Done — name updated on CodeWeek account',
+            'user_email_update' => 'Done — account email updated',
             'user_restore' => 'Done — CodeWeek account reactivated',
             'user_role_add' => 'Done — user role added',
             'user_role_remove' => 'Done — user role removed',
@@ -877,7 +939,7 @@ private function buildCompletionBody(
         }
 
         // Role add/remove are batch actions; the per-account list is shown above.
-        if ($email !== '' && ! in_array($action, ['user_role_add', 'user_role_remove'], true)) {
+        if ($email !== '' && ! in_array($action, ['user_role_add', 'user_role_remove', 'user_email_update'], true)) {
             $lines[] = '';
             $lines[] = 'Account email: '.$email;
         }
@@ -888,10 +950,10 @@ private function buildCompletionBody(
 
         $lines[] = '';
         if ($succeeded) {
-            $lines[] = in_array($action, ['user_role_add', 'user_role_remove'], true)
+            $lines[] = in_array($action, ['user_role_add', 'user_role_remove', 'user_email_update'], true)
                 ? 'No further action is needed. You do not need to reply to this email.'
                 : 'No further action is needed. The supporter can sign in with their usual email and password.';
-            if (! in_array($action, ['user_role_add', 'user_role_remove'], true)) {
+            if (! in_array($action, ['user_role_add', 'user_role_remove', 'user_email_update'], true)) {
                 $lines[] = 'You do not need to reply to this email.';
             }
         } else {
@@ -914,6 +976,33 @@ private function completionSuccessLines(SupportCase $case, string $action, array
         $inner = is_array($result['result'] ?? null) ? $result['result'] : [];
         $note = is_string($inner['note'] ?? null) ? $inner['note'] : '';
 
+        if ($action === 'user_email_update') {
+            $before = (array) ($inner['before'] ?? []);
+            $after = (array) ($inner['after'] ?? []);
+
+            if ($note === 'email_already_matches_requested_value') {
+                return [
+                    'The account already uses the requested email address — no change was required.',
+                ];
+            }
+
+            $lines = [
+                'We updated the login email on this CodeWeek account.',
+                '',
+                '  • From: '.(string) ($before['email'] ?? '(unknown)'),
+                '  • To:   '.(string) ($after['email'] ?? '(unknown)'),
+            ];
+
+            if (($inner['would_update_email_display'] ?? false) === true) {
+                $lines[] = '  • The public display email was updated to match.';
+            }
+
+            $lines[] = '';
+            $lines[] = 'The person should sign in with the new email address and complete email verification if prompted.';
+
+            return $lines;
+        }
+
         if ($action === 'user_profile_update') {
             $lines = [
                 'We updated the name shown on the CodeWeek account'.($email !== '' ? ' for '.$email : '').'.',
@@ -1128,7 +1217,11 @@ private function humanizeError(string $code, string $action, int $caseId): strin
         return match (true) {
             str_contains($code, 'no_matching_user') => 'We could not find a CodeWeek account with that email address.',
             str_contains($code, 'ambiguous_user') => 'More than one account matched this email. A team member must review Case #'.$caseId.' manually.',
-            str_contains($code, 'invalid_email') => 'The email address on the request was not valid.',
+            str_contains($code, 'invalid_from_email') => 'The current email address on the request was not valid.',
+            str_contains($code, 'invalid_to_email') => 'The new email address on the request was not valid.',
+            str_contains($code, 'from_and_to_emails_identical') => 'The current and new email addresses are the same.',
+            str_contains($code, 'to_email_already_in_use') => 'Another CodeWeek account already uses the new email address.',
+            str_contains($code, 'email_already_matches') => 'The account already uses the requested email address.',
             str_contains($code, 'no_profile_fields') => 'The request did not include a first or last name to update.',
             str_contains($code, 'dry_run_mode') => 'The system is in preview-only mode and could not apply live changes.',
             str_contains($code, 'unsupported_approved_action') => 'This type of request cannot be run automatically yet.',