fw/graphics: keep the glyph metadata SPI lookup inlined

35ff0d4 ("fw/graphics: consult the font's other own resource when
routed lookup misses") added a second call site for
prv_get_glyph_metadata_from_spi(), which stopped GCC from inlining it
into prv_get_glyph_in_font(): the glyph lookup path grew from one
64-byte frame to 40 + 64 bytes of nested frames.

This chain (graphics_draw_text -> walk_line -> text_resources_get_glyph
-> resource/pfs syscalls) is the deepest consumer of the app task's
2 KiB stack on non-emery/gabbro platforms, and the extra 40 bytes
pushed watchfaces already near the limit into the stack guard. On a
Pebble 2 Duo this presented as v4.33.1 "not sticking": the active
watchface overflowed on every boot seconds after launch, the fault
escalated to a reboot, and after three reboots the bootloader fell
back to PRF (the QR onboarding screen).

Mark prv_get_glyph_metadata_from_spi() ALWAYS_INLINE. With both call
sites inlined GCC overlaps their stack slots, restoring the pre-4.32.0
64-byte frame, and the merged function is slightly smaller (836 vs 878
bytes) than the outlined pair since the call overhead disappears.

Fixes FIRM-3949

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Joshua Jun <lets@throw.rocks>

Author: jplexer

src/fw/applib/graphics/text_resources.c

@@ -10,6 +10,7 @@
 #include "applib/fonts/fonts_private.h"
 #include "resource/resource_ids.auto.h"
 #include <pbl/logging/logging.h>
+#include <pbl/util/attributes.h>
 #include "system/passert.h"
 #include "system/profiler.h"
 #include "pbl/util/math.h"
@@ -349,10 +350,10 @@ static bool prv_load_glyph_bitmap(Codepoint codepoint, const FontResource *font_
   return true;
 }
 
-static const GlyphData *prv_get_glyph_metadata_from_spi(Codepoint codepoint,
-                                                        FontCache *font_cache,
-                                                        const FontResource *font_res,
-                                                        bool need_bitmap) {
+static ALWAYS_INLINE const GlyphData *prv_get_glyph_metadata_from_spi(Codepoint codepoint,
+                                                                      FontCache *font_cache,
+                                                                      const FontResource *font_res,
+                                                                      bool need_bitmap) {
   const uint32_t cache_key = prv_get_cache_key(font_res, codepoint);
   LineCacheData *cached = NULL;