applib: draw attached action bars from their laid-out frame

is_on_right() is the desired side for new bars. Press animation and
round fill were using that live value, so a Settings toggle or late
opt-in could flip drawing while the strip stayed put.

Co-authored-by: Cursor Grok 4.6 <noreply@cursor.com>
Signed-off-by: Arnav Jain <arnjain3@gmail.com>

Author: myNameArnav

src/fw/applib/ui/action_bar_layer.c

@@ -69,6 +69,14 @@ bool action_bar_layer_is_on_right(void) {
   return true;
 }
 
+// Laid-out frame side. Drawing must not follow a live pref/opt-in change.
+static bool prv_attached_bar_is_on_right(const ActionBarLayer *action_bar) {
+  if (!action_bar->window) {
+    return action_bar_layer_is_on_right();
+  }
+  return action_bar->layer.frame.origin.x != 0;
+}
+
 int16_t action_bar_layer_get_content_origin_x(void) {
   return action_bar_layer_is_on_right() ? 0 : prv_width();
 }
@@ -206,7 +214,7 @@ static GPoint prv_get_button_press_offset(ActionBarLayer *action_bar, uint8_t bu
       GPoint(0, animation_offset),
   };
   // MoveLeft is "toward content" when the bar is on the right; flip when it is on the left.
-  if (!action_bar_layer_is_on_right()) {
+  if (!prv_attached_bar_is_on_right(action_bar)) {
     offset[ActionBarLayerIconPressAnimationMoveLeft].x = animation_offset;
     offset[ActionBarLayerIconPressAnimationMoveRight].x = -animation_offset;
   }
@@ -224,7 +232,7 @@ void prv_draw_background_round(ActionBarLayer *action_bar, GContext *ctx, GColor
   GRect action_bar_circle_frame = (GRect) {
       .size = GSize(action_bar_circle_diameter, action_bar_circle_diameter)
   };
-  const GAlign align = action_bar_layer_is_on_right() ? GAlignLeft : GAlignRight;
+  const GAlign align = prv_attached_bar_is_on_right(action_bar) ? GAlignLeft : GAlignRight;
   grect_align(&action_bar_circle_frame, &action_bar->layer.bounds, align, false /* clips */);
   graphics_fill_oval(ctx, action_bar_circle_frame, GOvalScaleModeFitCircle);
 }
@@ -280,7 +288,7 @@ void action_bar_update_proc(ActionBarLayer *action_bar, GContext* ctx) {
       grect_align(&icon_rect, &rect, GAlignCenter, clip);
 #if PBL_ROUND
       // Offset needed because the curvature of the action bar makes the icons look off-center
-      const int32_t icon_horizontal_offset = action_bar_layer_is_on_right() ? -2 : 2;
+      const int32_t icon_horizontal_offset = prv_attached_bar_is_on_right(action_bar) ? -2 : 2;
       icon_rect.origin.x += icon_horizontal_offset;
 #endif
       icon_rect.origin.x += offset.x;

src/fw/applib/ui/action_bar_layer.h

@@ -291,12 +291,14 @@ void action_bar_layer_set_background_color(ActionBarLayer *action_bar, GColor ba
 //! Process-wide: affects every action bar in this app. Third-party apps default
 //! to the right edge; system and kernel UI always follow orientation. Call before
 //! \ref action_bar_layer_add_to_window(); it does not move a bar already
-//! attached to a window.
+//! attached to a window. Toggling Left-Handed Mode in Settings likewise leaves
+//! attached bars in place until the window is reopened or the bar is added again.
 //! @param follow true to place action bars on the button side in Left-Handed Mode
 void action_bar_layer_set_follows_display_orientation(bool follow);
 
-//! Whether the action bar sits on the right edge of the window.
-//! @return true if the bar is (or will be) on the right, false if on the left
+//! Desired side for new bars (and for the inset helpers), not the frame of an
+//! already-attached bar.
+//! @return true if a newly added bar will sit on the right, false if on the left
 bool action_bar_layer_is_on_right(void);
 
 //! X origin of the content area beside the action bar (0 when the bar is on the right).