fw/timeline: fix the all-day pin's vertical offset on Pebble Time 2

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Apurv Patani <pataniapurv@gmail.com>

Author: 2 people

src/fw/services/timeline/timeline_layout.c

@@ -387,7 +387,15 @@ static GTextNode *prv_create_all_day_text_node(const TimelineLayout *layout) {
     .text.style_font = TextStyleFont_Title,
     .text.fixed_lines = 1,
     .text.alignment = PBL_IF_RECT_ELSE(LayoutTextAlignment_Left, LayoutTextAlignment_Right),
-    .text.extent.offset.y = -13,
+    // The font leaves blank space above the text; this pulls the header back up. Large rect
+    // displays need less of a pull than the others.
+    .text.extent.offset.y = PREFERRED_CONTENT_SIZE_SWITCH(PreferredContentSizeDefault,
+      /* This is the same as Medium until Small is designed */
+      /* small */ -13,
+      /* medium */ -13,
+      /* large */ PBL_IF_RECT_ELSE(-8, -13),
+      /* This is the same as Large until ExtraLarge is designed */
+      /* extralarge */ PBL_IF_RECT_ELSE(-8, -13)),
     .text.extent.margin.h = -7,
   };
   GTextNodeText *text_node =

tests/fw/apps/system_apps/timeline/test_timeline_list_view.c

@@ -37,6 +37,7 @@ typedef struct TimelineItemConfig {
   const char *title;
   const char *subtitle;
   TimelineResourceId icon;
+  bool all_day;
 } TimelineItemConfig;
 
 typedef struct ListViewConfig {
@@ -63,6 +64,7 @@ static void prv_add_timeline_item(const TimelineItemConfig *config, bool past) {
                                                 &list, NULL);
     attribute_list_destroy_list(&list);
     PBL_ASSERTN(item);
+    item->header.all_day = config->all_day;
   }
   if (item) {
     pin_db_insert_item(item);
@@ -252,3 +254,30 @@ void test_timeline_list_view__pin_and_fin_past(void) {
   FAKE_GRAPHICS_CONTEXT_CHECK_DEST_BITMAP_FILE();
 }
 
+
+void prv_create_and_render_all_day(bool past) {
+  prv_create_list_view_and_render(&(ListViewConfig) {
+    .pins = {
+      &(TimelineItemConfig) {
+        // Must sit further back than the duration, or the past view correctly excludes it
+        // for still being in progress.
+        .relative_timestamp = 2 * SECONDS_PER_DAY,
+        .title = "Independence Day",
+        .duration = MINUTES_PER_DAY,
+        .icon = TIMELINE_RESOURCE_TIMELINE_CALENDAR,
+        .all_day = true,
+      }
+    },
+    .past = past,
+  });
+}
+
+void test_timeline_list_view__all_day_future(void) {
+  prv_create_and_render_all_day(false /* past */);
+  FAKE_GRAPHICS_CONTEXT_CHECK_DEST_BITMAP_FILE();
+}
+
+void test_timeline_list_view__all_day_past(void) {
+  prv_create_and_render_all_day(true /* past */);
+  FAKE_GRAPHICS_CONTEXT_CHECK_DEST_BITMAP_FILE();
+}

tests/fw/apps/system_apps/timeline/wscript_build

@@ -131,7 +131,7 @@ clar(ctx,
      defines=ctx.env.test_image_defines + ["USE_DISPLAY_PERIMETER_ON_FONT_LAYOUT=1"],
      runtime_deps=ctx.env.test_pngs + ctx.env.test_pbis + ctx.env.test_pfos,
      override_includes=['dummy_board'],
-     platforms=['obelix', 'gabbro'])
+     platforms=['obelix', 'gabbro', 'asterix'])
 
 clar(ctx,
      sources_ant_glob=(