feat(ocr): optimize clipboard image handling and memory management during OCR processing

yusixian · yusixian · commit a08139bffb4a · 2026-02-22T03:02:41.000+08:00
diff --git a/Sources/Core/OCR/ScreenCaptureOCR.swift b/Sources/Core/OCR/ScreenCaptureOCR.swift
@@ -28,12 +28,16 @@ enum ScreenCaptureOCR {
             throw OCRError.captureCancelled
         }
 
-        // Read image from clipboard
-        let pasteboard = NSPasteboard.general
-        guard let image = NSImage(pasteboard: pasteboard),
-              let cgImage = image.cgImage(forProposedRect: nil, context: nil, hints: nil)
-        else {
-            throw OCRError.noImageInClipboard
+        // Read image from clipboard and perform OCR inside autoreleasepool
+        // to ensure large screenshot images are freed promptly.
+        let cgImage: CGImage = try autoreleasepool {
+            let pasteboard = NSPasteboard.general
+            guard let image = NSImage(pasteboard: pasteboard),
+                  let cg = image.cgImage(forProposedRect: nil, context: nil, hints: nil)
+            else {
+                throw OCRError.noImageInClipboard
+            }
+            return cg
         }
 
         return try await recognizeText(in: cgImage)
diff --git a/Sources/Services/Providers/AppleTranslationProvider.swift b/Sources/Services/Providers/AppleTranslationProvider.swift
@@ -95,6 +95,7 @@ struct AppleTranslationProvider: TranslationProvider {
                     windowRef.value = window
 
                     if Task.isCancelled {
+                        window.contentView = nil
                         window.close()
                         continuation.resume(throwing: CancellationError())
                         return
diff --git a/Sources/Services/Providers/BaiduTranslateProvider.swift b/Sources/Services/Providers/BaiduTranslateProvider.swift
@@ -66,7 +66,7 @@ struct BaiduTranslateProvider: TranslationProvider {
         request.setValue("application/x-www-form-urlencoded", forHTTPHeaderField: "Content-Type")
         request.httpBody = formParts.joined(separator: "&").data(using: .utf8)
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
diff --git a/Sources/Services/Providers/BingTranslateProvider.swift b/Sources/Services/Providers/BingTranslateProvider.swift
@@ -67,7 +67,7 @@ struct BingTranslateProvider: TranslationProvider {
         request.setValue("https://www.bing.com/translator", forHTTPHeaderField: "Referer")
         request.httpBody = formBody.data(using: .utf8)
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
@@ -160,7 +160,7 @@ private actor BingTokenManager {
         request.timeoutInterval = 15
         request.setValue(Self.userAgent, forHTTPHeaderField: "User-Agent")
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse, httpResponse.statusCode == 200 else {
             throw TranslationError.apiError(
diff --git a/Sources/Services/Providers/CaiyunProvider.swift b/Sources/Services/Providers/CaiyunProvider.swift
@@ -70,7 +70,7 @@ struct CaiyunProvider: TranslationProvider {
         request.setValue("token \(token)", forHTTPHeaderField: "x-authorization")
         request.httpBody = try JSONSerialization.data(withJSONObject: body)
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
diff --git a/Sources/Services/Providers/DeepLProvider.swift b/Sources/Services/Providers/DeepLProvider.swift
@@ -61,7 +61,7 @@ struct DeepLProvider: TranslationProvider {
         request.setValue("application/x-www-form-urlencoded", forHTTPHeaderField: "Content-Type")
         request.httpBody = formParts.joined(separator: "&").data(using: .utf8)
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
diff --git a/Sources/Services/Providers/GoogleTranslateProvider.swift b/Sources/Services/Providers/GoogleTranslateProvider.swift
@@ -56,7 +56,7 @@ struct GoogleTranslateProvider: TranslationProvider {
             forHTTPHeaderField: "User-Agent"
         )
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
diff --git a/Sources/Services/Providers/NiuTransProvider.swift b/Sources/Services/Providers/NiuTransProvider.swift
@@ -55,7 +55,7 @@ struct NiuTransProvider: TranslationProvider {
         request.setValue("application/x-www-form-urlencoded", forHTTPHeaderField: "Content-Type")
         request.httpBody = formParts.joined(separator: "&").data(using: .utf8)
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
diff --git a/Sources/Services/Providers/OllamaProvider.swift b/Sources/Services/Providers/OllamaProvider.swift
@@ -65,7 +65,7 @@ struct OllamaProvider: TranslationProvider {
                     request.setValue("application/json", forHTTPHeaderField: "Content-Type")
                     request.httpBody = try JSONSerialization.data(withJSONObject: body)
 
-                    let (bytes, response) = try await URLSession.shared.bytes(for: request)
+                    let (bytes, response) = try await translationURLSession.bytes(for: request)
                     try await streamOpenAISSE(bytes, response: response, to: continuation)
                     continuation.finish()
                 } catch let error as URLError where error.code == .cannotConnectToHost || error.code == .timedOut {
@@ -95,7 +95,7 @@ struct OllamaProvider: TranslationProvider {
         var request = URLRequest(url: url)
         request.timeoutInterval = 5
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
@@ -246,7 +246,7 @@ private struct OllamaSettingsView: View {
         var request = URLRequest(url: pingURL)
         request.timeoutInterval = 3
         do {
-            let (_, response) = try await URLSession.shared.data(for: request)
+            let (_, response) = try await translationURLSession.data(for: request)
             if let http = response as? HTTPURLResponse, http.statusCode == 200 {
                 serverStatus = .running
             } else {
diff --git a/Sources/Services/Providers/OpenAICompatibleProvider.swift b/Sources/Services/Providers/OpenAICompatibleProvider.swift
@@ -52,7 +52,7 @@ struct OpenAICompatibleProvider: TranslationProvider {
             let task = Task {
                 do {
                     let request = try buildRequest(text: text, sourceLang: sourceLang, targetLang: targetLang)
-                    let (bytes, response) = try await URLSession.shared.bytes(for: request)
+                    let (bytes, response) = try await translationURLSession.bytes(for: request)
                     try await streamOpenAISSE(bytes, response: response, to: continuation)
                     continuation.finish()
                 } catch {
diff --git a/Sources/Services/Providers/OpenAIConnectionManager.swift b/Sources/Services/Providers/OpenAIConnectionManager.swift
@@ -39,7 +39,7 @@ final class OpenAIConnectionManager {
         request.setValue("Bearer \(apiKey)", forHTTPHeaderField: "Authorization")
 
         do {
-            let (data, response) = try await URLSession.shared.data(for: request)
+            let (data, response) = try await translationURLSession.data(for: request)
             guard let httpResponse = response as? HTTPURLResponse else {
                 modelFetchError = String(localized: "Invalid response")
                 return
@@ -93,7 +93,7 @@ final class OpenAIConnectionManager {
 
         let start = ContinuousClock.now
         do {
-            let (data, response) = try await URLSession.shared.data(for: request)
+            let (data, response) = try await translationURLSession.data(for: request)
             let ms = Int((ContinuousClock.now - start) / .milliseconds(1))
 
             guard let httpResponse = response as? HTTPURLResponse else {
diff --git a/Sources/Services/Providers/YoudaoTranslateProvider.swift b/Sources/Services/Providers/YoudaoTranslateProvider.swift
@@ -78,7 +78,7 @@ struct YoudaoTranslateProvider: TranslationProvider {
         request.setValue("OUTFOX_SEARCH_USER_ID=0@0.0.0.0;", forHTTPHeaderField: "Cookie")
         request.httpBody = formParts.joined(separator: "&").data(using: .utf8)
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse else {
             throw TranslationError.invalidResponse
@@ -229,7 +229,7 @@ private actor YoudaoKeyManager {
         request.setValue("https://fanyi.youdao.com/", forHTTPHeaderField: "Referer")
         request.setValue("OUTFOX_SEARCH_USER_ID=0@0.0.0.0;", forHTTPHeaderField: "Cookie")
 
-        let (data, response) = try await URLSession.shared.data(for: request)
+        let (data, response) = try await translationURLSession.data(for: request)
 
         guard let httpResponse = response as? HTTPURLResponse, httpResponse.statusCode == 200 else {
             // Fallback to hardcoded defaults if key fetch fails
diff --git a/Sources/Services/TranslationProvider.swift b/Sources/Services/TranslationProvider.swift
@@ -51,6 +51,18 @@ extension TranslationProvider {
     var category: ProviderCategory { .llm }
 }
 
+// MARK: - Shared URLSession (zero-cache)
+
+/// A shared URLSession with caching disabled. Translation API responses are unique
+/// per request and should not be cached; using the default URLSession.shared would
+/// accumulate up to 25 MB+ of useless cache data over time.
+let translationURLSession: URLSession = {
+    let config = URLSessionConfiguration.default
+    config.urlCache = nil
+    config.requestCachePolicy = .reloadIgnoringLocalCacheData
+    return URLSession(configuration: config)
+}()
+
 // MARK: - Non-Streaming Helper
 
 extension TranslationProvider {
diff --git a/Sources/UI/TriggerIcon/TriggerIconController.swift b/Sources/UI/TriggerIcon/TriggerIconController.swift
@@ -157,6 +157,7 @@ final class TriggerIconController {
             panel.animator().alphaValue = 0
         }, completionHandler: { [weak self] in
             Task { @MainActor in
+                panel.contentView = nil
                 panel.close()
                 self?.cleanup()
                 self?.onDismissed?()
@@ -168,6 +169,7 @@ final class TriggerIconController {
     func dismissSilently() {
         guard let panel else { return }
         cancelAllTimers()
+        panel.contentView = nil
         panel.close()
         cleanup()
     }
@@ -224,6 +226,7 @@ final class TriggerIconController {
 
         guard let panel else { return }
         // Immediately hide the icon
+        panel.contentView = nil
         panel.close()
         cleanup()
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ struct GoogleTranslateProvider: TranslationProvider {`
`56`	`56`	`forHTTPHeaderField: "User-Agent"`
`57`	`57`	`)`
`58`	`58`
`59`		`- let (data, response) = try await URLSession.shared.data(for: request)`
	`59`	`+ let (data, response) = try await translationURLSession.data(for: request)`
`60`	`60`
`61`	`61`	`guard let httpResponse = response as? HTTPURLResponse else {`
`62`	`62`	`throw TranslationError.invalidResponse`