Skip to content

Commit 3429e8a

Browse files
committed
fix(network): avoid empty variadic log arguments
- 为三处纯文本日志显式添加格式占位符 - 消除 -Wpedantic 可变参数宏告警 Signed-off-by: Fernandez <yuanhaon81@gmail.com>
1 parent 2eaf5fd commit 3429e8a

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

src/network/http/HttpPost.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ void HttpPost::SetAppInfo(const std::string& app_key, const std::string& app_sec
228228
if (app_key.empty() || app_secret.empty()) {
229229
app_key_.clear();
230230
app_secret_.clear();
231-
LOG_ERRO("platform application credentials must provide both key and secret");
231+
LOG_ERRO("{}", "platform application credentials must provide both key and secret");
232232
return;
233233
}
234234
app_key_ = app_key;
@@ -253,7 +253,8 @@ bool HttpPost::LoadAppInfoFromRuntime() {
253253
app_key_.clear();
254254
app_secret_.clear();
255255
if (key_state == CredentialLoadState::kMissing && secret_state == CredentialLoadState::kMissing) {
256-
LOG_INFO("platform application credentials are not configured; signed manager requests are disabled");
256+
LOG_INFO("{}",
257+
"platform application credentials are not configured; signed manager requests are disabled");
257258
} else {
258259
LOG_ERRO("platform application credentials are incomplete: key={}, secret={}",
259260
CredentialStateName(key_state), CredentialStateName(secret_state));
@@ -279,7 +280,8 @@ HttpRequest& HttpPost::GetHttpRequest() {
279280

280281
bool HttpPost::AppendHeaderS(HttpRequest& hrt) {
281282
if (!HasAppInfo()) {
282-
LOG_ERRO("signed manager request rejected because platform application credentials are unavailable");
283+
LOG_ERRO("{}",
284+
"signed manager request rejected because platform application credentials are unavailable");
283285
return false;
284286
}
285287
hrt.SetContentType("application/json");

0 commit comments

Comments
 (0)