[BUG] supplied configuration in CLI overridden by default file

[willemo]

• I'm on the latest version of djLint
• I've searched the issues
• I've read the docs

System Info

• OS: MacOS 14.2.1
• Python Version (3.8.16)
• djLint Version (1.34.1)
• template language: Jinja

Issue

When you have a "default" config file in your project's root folder (e.g. a pyproject.toml file) and you provide a different config file in your CLI command (e.g. --configuration .djlintrc), the former will always override the latter. According to the docs this should not be the case:

Command line args will always override any settings in pyproject.toml.

I've found a possible cause of this: in the load_project_settings function there isn't a return after the provided config path has been loaded, causing the default paths to be checked, which will override the provided config.

How To Reproduce

Create two config files (pyproject.toml and .djlintrc) with different configuration (e.g. only add extend_exclude to the .djlintrc file) and run the following command:

djlint --configuration .djlintrc

The command will ignore the extend_exclude settings from .djlintrc.

Contents of .djlintrc/pyproject.toml [tool.djlint]

pyproject.toml

[tool.djlint]
profile = "jinja"

.djlintrc

{
    "profile": "jinja",
    "extend_exclude": "path/to/file.html"
}

[keikoro]

The paragraph from the Configuration section from which you quoted continues:

Command line args will always override any settings in pyproject.toml. Local project settings will always override global configuration files.

The CLI usage section defines the --configuration option as follows*:

  --configuration FILE            Path to global configuration file in
                                  djlint.toml or .djlintrc format

I interpret this to mean that
a) command line arguments overrule settings of the same name found in any config files and
b) settings in a local config file override settings of the same name in a global config file.

... Where "local" means at the root of the project the files that djLint is run on sit in.

So if you point to a global file which contains a setting that's also contained in the local file, the local setting will take precedence. E.g. a global setting of indent=2 will be ignored in favour of a local setting of indent=4. If you provide the same setting via command line arguments, e.g. --indent="6", both config file settings will be ignored.

Settings which aren't present elsewhere should be "passed through" either way.

I can use settings in global config files fine, so I'm wondering if your problem is more to do with extend_exclude specifically than how settings are processed more generally. See e.g. #664 for earlier reports of problems with it.

*One thing the docs/CLI help seem to have got wrong is that FILE can also be a pyproject.toml file.

[monosans]

I agree that this is not intuitive and does not match the way other familiar tools work. However, this is a breaking change, so I believe it will only be implemented in version 2.0.