fix: linters

Author: fengkx

packages/lsp-server/src/common/features/diagnostics.ts

@@ -44,10 +44,18 @@ const ROOT_OPTION_NAMES = [
 ] as const;
 
 const DEFAULT_ROOT_NAMES = new Set(['Assets', 'Liabilities', 'Equity', 'Income', 'Expenses']);
-const NON_ASCII_RE = /[^\x00-\x7F]/;
 const INVALID_ACCOUNT_NAME_RE = /^Invalid account name:\s*(.+)$/;
 const INVALID_UNKNOWN_ACCOUNT_RE = /^Invalid reference to unknown account ['"](.+?)['"]$/;
 
+function hasNonAscii(text: string): boolean {
+	for (let i = 0; i < text.length; i++) {
+		if (text.charCodeAt(i) > 0x7F) {
+			return true;
+		}
+	}
+	return false;
+}
+
 function isNotGitUri(uri: string): boolean {
 	return URI.parse(uri).scheme !== 'git';
 }
@@ -298,7 +306,7 @@ export class DiagnosticsFeature implements Feature {
 		for (const name of ROOT_OPTION_NAMES) {
 			const option = this.optionsManager.getOption(name);
 			const value = option.asString();
-			if (option.isDefault || !NON_ASCII_RE.test(value) || DEFAULT_ROOT_NAMES.has(value)) {
+			if (option.isDefault || !hasNonAscii(value) || DEFAULT_ROOT_NAMES.has(value)) {
 				continue;
 			}
 			customNonAsciiRoots.add(value);

packages/lsp-server/src/test/features/references-rename.test.ts

@@ -173,9 +173,9 @@ describe('references + rename correctness', () => {
 		expect(Object.values(tagEdit.changes).flat().some((e: any) => e.newText === '#newtag')).toBe(true);
 		const linkEdit = await (rename as any).onRename({ textDocument: { uri }, position: linkPos, newName: '^newlink' });
 		expect(Object.values(linkEdit.changes).flat().some((e: any) => e.newText === '^newlink')).toBe(true);
-		const payeeEdit = await (rename as any).onRename({ textDocument: { uri }, position: payeePos, newName: '\"ACME \\\"Store\\\"\"' });
+		const payeeEdit = await (rename as any).onRename({ textDocument: { uri }, position: payeePos, newName: '"ACME \\"Store\\""' });
 		expect(Object.values(payeeEdit.changes).flat().some((e: any) => e.newText === '"ACME \\"Store\\""')).toBe(true);
-		const narrationEdit = await (rename as any).onRename({ textDocument: { uri }, position: narrationPos, newName: '\"New Narration\"' });
+		const narrationEdit = await (rename as any).onRename({ textDocument: { uri }, position: narrationPos, newName: '"New Narration"' });
 		expect(Object.values(narrationEdit.changes).flat().some((e: any) => e.newText === '"New Narration"')).toBe(true);
 	});
 

packages/lsp-server/src/test/utils/test-server-harness.ts

@@ -57,6 +57,8 @@ export class InMemoryDocumentStore {
 	}
 }
 
+type ListenerFn = (...args: unknown[]) => unknown;
+
 export function positionAt(text: string, needle: string, offsetInNeedle = 0): { line: number; character: number } {
 	const index = text.indexOf(needle);
 	if (index < 0) {
@@ -96,7 +98,7 @@ export function makeFakeConnection(options?: {
 }) {
 	const sentDiagnostics: Array<{ uri: string; diagnostics: Diagnostic[] }> = [];
 	const configurationRequests: Array<unknown> = [];
-	const listeners: Record<string, Function[]> = {};
+	const listeners: Record<string, ListenerFn[]> = {};
 
 	const connection = {
 		workspace: {
@@ -114,16 +116,16 @@ export function makeFakeConnection(options?: {
 		sendDiagnostics(payload: { uri: string; diagnostics: Diagnostic[] }) {
 			sentDiagnostics.push(payload);
 		},
-		onExit(cb: Function) {
+		onExit(cb: ListenerFn) {
 			(listeners['exit'] ||= []).push(cb);
 		},
-		onReferences(cb: Function) {
+		onReferences(cb: ListenerFn) {
 			(listeners['references'] ||= []).push(cb);
 		},
-		onRenameRequest(cb: Function) {
+		onRenameRequest(cb: ListenerFn) {
 			(listeners['rename'] ||= []).push(cb);
 		},
-		onPrepareRename(cb: Function) {
+		onPrepareRename(cb: ListenerFn) {
 			(listeners['prepareRename'] ||= []).push(cb);
 		},
 	} as unknown as import('vscode-languageserver').Connection;

packages/playground/src/main.ts

@@ -72,7 +72,12 @@ function debugLog(...args: unknown[]) {
 }
 
 function hasNonAscii(text: string): boolean {
-	return /[^\x00-\x7F]/.test(text);
+	for (let i = 0; i < text.length; i++) {
+		if (text.charCodeAt(i) > 0x7F) {
+			return true;
+		}
+	}
+	return false;
 }
 
 async function sha256Hex(text: string): Promise<string> {