Skip to content

Commit a55ef0d

Browse files
Peter Oettigpoettig
authored andcommitted
feat: trip end column
1 parent 4a2c90e commit a55ef0d

3 files changed

Lines changed: 18 additions & 7 deletions

File tree

psa_car_controller/psacc/model/trip.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,20 @@ def to_geojson(self):
7575
"average consumption fuel": self.consumption_fuel_km})
7676

7777
def get_info(self):
78-
79-
res = {"consumption_km": self.consumption_km, "start_at": self.start_at,
80-
"consumption_by_temp": self.get_temperature(), "positions": self.get_positions(),
81-
"duration": self.duration * 60, "speed_average": self.speed_average, "distance": self.distance,
82-
"mileage": self.mileage, "altitude_diff": self.altitude_diff, "id": self.id,
83-
"consumption": self.consumption
84-
}
78+
res = {
79+
"consumption_km": self.consumption_km,
80+
"start_at": self.start_at,
81+
"end_at": self.end_at,
82+
"consumption_by_temp": self.get_temperature(),
83+
"positions": self.get_positions(),
84+
"duration": self.duration * 60,
85+
"speed_average": self.speed_average,
86+
"distance": self.distance,
87+
"mileage": self.mileage,
88+
"altitude_diff": self.altitude_diff,
89+
"id": self.id,
90+
"consumption": self.consumption,
91+
}
8592
if self.car.has_battery():
8693
res["consumption_km"] = self.consumption_km
8794

psa_car_controller/web/figures.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ def get_figures(car: Car):
8484
},
8585
columns=[{'id': 'id', 'name': '#', 'type': 'numeric'},
8686
{'id': 'start_at_str', 'name': 'start at', 'type': 'datetime'},
87+
{'id': 'end_at_str', 'name': 'end at', 'type': 'datetime'},
8788
{'id': 'duration', 'name': 'duration', 'type': 'numeric',
8889
'format': deepcopy(nb_format).symbol_suffix(" min").precision(0)},
8990
{'id': 'speed_average', 'name': 'avg. speed', 'type': 'numeric',

tests/test_unit.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ def test_record_position_charging(self):
206206
res = trip.get_info()
207207
assert compare_dict(res, {'consumption_km': 24.21052631578947,
208208
'start_at': date0,
209+
'end_at': date2,
209210
'consumption_by_temp': None,
210211
'positions': {'lat': [latitude], 'long': [longitude]},
211212
'duration': 40.0, 'speed_average': 28.5, 'distance': 19.0, 'mileage': 30.0,
@@ -264,6 +265,7 @@ def test_fuel_car(self):
264265
res = trips[car.vin].get_trips_as_dict()
265266
assert compare_dict(res, [{'consumption_km': 6.947368421052632,
266267
'start_at': date0,
268+
'end_at': date2,
267269
'consumption_by_temp': None,
268270
'positions': {'lat': [latitude],
269271
'long': [longitude]},
@@ -292,6 +294,7 @@ def test_none_mileage(self):
292294
res = trips[car.vin].get_trips_as_dict()
293295
assert compare_dict(res, [{'consumption_km': 6.947368421052632,
294296
'start_at': start,
297+
'end_at': end,
295298
'consumption_by_temp': None,
296299
'positions': {'lat': [latitude],
297300
'long': [longitude]},

0 commit comments

Comments
 (0)