Skip to content

Commit 3c2aad1

Browse files
committed
update
1 parent f0be9c3 commit 3c2aad1

3 files changed

Lines changed: 19 additions & 19 deletions

File tree

fkq-lambda-core/src/main/java/com/formkiq/aws/services/lambda/ApiGatewayRequestToUserActivityFunction.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ public class ApiGatewayRequestToUserActivityFunction {
6565
public UserActivity.Builder apply(final ApiAuthorization authorization,
6666
final ApiGatewayRequestEvent request, final ApiRequestHandlerResponse response) {
6767

68-
UserActivity.Builder builder =
69-
UserActivity.builder().source("HTTP").status(UserActivityStatus.COMPLETE);
68+
UserActivity.Builder builder = UserActivity.builder().source("HTTP")
69+
.status(UserActivityStatus.COMPLETE).insertedDate(getInsertedDate(request));
7070

7171
if (response != null) {
7272
builder = builder.status(response.statusCode());
@@ -85,8 +85,7 @@ public UserActivity.Builder apply(final ApiAuthorization authorization,
8585
String activityType = getType(request);
8686

8787
builder = builder.resource(resource).entityNamespace(entityNamespace).type(activityType)
88-
.insertedDate(getInsertedDate(request)).sourceIpAddress(getSourceIp(request))
89-
.body(getBody(request))
88+
.sourceIpAddress(getSourceIp(request)).body(getBody(request))
9089
.userId(authorization != null ? authorization.getUsername() : "System");
9190

9291
if (isGenerateS3Key(request)) {
@@ -130,7 +129,7 @@ private String findResourceId(final ApiGatewayRequestEvent request,
130129
*/
131130
private static String getResource(final ApiGatewayRequestEvent request) {
132131
String[] split = request.getResource().split("/");
133-
return split[1].toLowerCase();
132+
return split[1];
134133
}
135134

136135
private static String getType(final ApiGatewayRequestEvent request) {

fkq-lambda-core/src/test/java/com/formkiq/aws/services/lambda/ApiGatewayRequestToUserActivityFunctionTest.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public void testGetDocumentById() throws IOException {
101101
assertNull(activity.message());
102102

103103
final long expectedTime = 1750944882199L;
104-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
104+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
105105
assertEquals(request.getPathParameters().get("documentId"), activity.documentId());
106106
}
107107
}
@@ -144,7 +144,7 @@ public void testDeleteDocumentById() throws IOException {
144144
assertNull(activity.message());
145145

146146
final long expectedTime = 1546105259536L;
147-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
147+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
148148
assertEquals(request.getPathParameters().get("documentId"), activity.documentId());
149149
}
150150
}
@@ -183,7 +183,7 @@ public void testGetDocuments() throws IOException {
183183
assertNull(activity.message());
184184

185185
final long expectedTime = 1750944882199L;
186-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
186+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
187187
}
188188
}
189189

@@ -209,7 +209,7 @@ public void testNull() {
209209
assertNull(activity.sourceIpAddress());
210210
assertEquals(UserActivityStatus.COMPLETE, activity.status());
211211
assertNull(activity.message());
212-
assertNull(activity.insertedDate());
212+
assertNotNull(activity.insertedDate());
213213
}
214214

215215
private int getYear() {
@@ -236,7 +236,7 @@ public void testGetEntityTypes() throws IOException {
236236

237237
// then
238238
assertNotNull(activity);
239-
assertEquals("entitytypes", activity.resource());
239+
assertEquals("entityTypes", activity.resource());
240240
assertEquals("HTTP", activity.source());
241241
assertEquals("view", activity.type());
242242
assertNull(activity.entityId());
@@ -251,7 +251,7 @@ public void testGetEntityTypes() throws IOException {
251251
assertNull(activity.message());
252252

253253
final long expectedTime = 1751589734043L;
254-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
254+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
255255
}
256256
}
257257

@@ -280,7 +280,7 @@ public void testAddEntityTypes() throws IOException {
280280

281281
// then
282282
assertNotNull(activity);
283-
assertEquals("entitytypes", activity.resource());
283+
assertEquals("entityTypes", activity.resource());
284284
assertEquals("HTTP", activity.source());
285285
assertEquals("create", activity.type());
286286
assertEquals("""
@@ -295,7 +295,7 @@ public void testAddEntityTypes() throws IOException {
295295
assertEquals(body.get("entityTypeId"), activity.entityTypeId());
296296
assertNull(activity.documentId());
297297

298-
String expectedS3 = "activities/" + getSiteIdName(siteId) + "/entitytypes/year=" + getYear()
298+
String expectedS3 = "activities/" + getSiteIdName(siteId) + "/entityTypes/year=" + getYear()
299299
+ "/month=" + getMonth() + "/day=" + getDay() + "/" + activity.entityTypeId() + "/";
300300
assertTrue(activity.s3Key().startsWith(expectedS3));
301301

@@ -304,7 +304,7 @@ public void testAddEntityTypes() throws IOException {
304304
assertNull(activity.message());
305305

306306
final long expectedTime = 1751589856468L;
307-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
307+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
308308
}
309309
}
310310

@@ -354,7 +354,7 @@ public void testAddEntity() throws IOException {
354354
assertNull(activity.message());
355355

356356
final long expectedTime = 1751636384960L;
357-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
357+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
358358
}
359359
}
360360

@@ -395,7 +395,7 @@ public void testGetEntitiesByType() throws IOException {
395395
assertNull(activity.message());
396396

397397
final long expectedTime = 1751636079140L;
398-
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate());
398+
assertEquals(Instant.ofEpochMilli(expectedTime), activity.insertedDate().toInstant());
399399
}
400400
}
401401

fkq-plugins/src/main/java/com/formkiq/plugins/useractivity/UserActivity.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
package com.formkiq.plugins.useractivity;
2525

2626
import java.time.Instant;
27+
import java.util.Date;
2728

2829
/**
2930
* Represents an activity performed by a user on a document or entity. This includes metadata such
@@ -43,7 +44,7 @@ public record UserActivity(
4344
String userId,
4445

4546
/* The timestamp when the activity was recorded. */
46-
Instant insertedDate,
47+
Date insertedDate,
4748

4849
/* The S3 object key for the stored document or metadata. */
4950
String s3Key,
@@ -221,8 +222,8 @@ public Builder entityNamespace(final String activityEntityNamespace) {
221222
* @return a new {@link UserActivity} object
222223
*/
223224
public UserActivity build() {
224-
return new UserActivity(resource, documentId, type, userId, insertedDate, s3Key, message,
225-
status, sourceIpAddress, source, entityTypeId, entityId, entityNamespace, body);
225+
return new UserActivity(resource, documentId, type, userId, Date.from(insertedDate), s3Key,
226+
message, status, sourceIpAddress, source, entityTypeId, entityId, entityNamespace, body);
226227
}
227228
}
228229
}

0 commit comments

Comments
 (0)