Skip to content

Bug: excluded_apps.txt parsing leaves internal spaces in app names #1719

Description

@raisulislam0

Issue: Bug report

bench\bench.py line 92

When reading excluded_apps.txt, app names with internal spaces (e.g. "erp next", " hrms ") are not normalized. This causes mismatches when comparing app names later in Bench logic.

Create sites/excluded_apps.txt with contents:

erp next
  hrms

Run any Bench command that checks excluded apps.
Observe that "erp next" is treated as a distinct string, not "erpnext".

Expected behavior 📈
App names should be cleaned so that both leading/trailing and internal whitespace are removed. For example:

"erp next" → "erpnext"

" hrms " → "hrms"

Possible Solution:

with open(self.excluded_apps_txt) as f:
    return [line.strip().replace(" ", "") for line in f if line.strip()]

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions