Service Health Status in Endpoints Controller Logs (#4616)

* Service Health Status in Endpoints Controller Logs

This PR includes the health status of the service being registered/updated by the endpoints controller.

This helps in identifying the service health state transitions, which is currently not possible and impacts the ability to troubleshoot issues.

* added changelog

---------

Co-authored-by: Arnab Chatterjee <arnabkaycee@gmail.com>

Author: Ranjandas

.changelog/4616.txt

@@ -0,0 +1,3 @@
+```release-note:improvement
+control-plane: Shows the health status of the services being registered/updates by endpoints controller
+```

control-plane/connect-inject/controllers/endpoints/endpoints_controller.go

@@ -303,7 +303,7 @@ func (r *Controller) registerServicesAndHealthCheck(apiClient *api.Client, pod c
 
 		// Register the service instance with Consul.
 		r.Log.Info("registering service with Consul", "name", serviceRegistration.Service.Service,
-			"id", serviceRegistration.Service.ID)
+			"id", serviceRegistration.Service.ID, "health", healthStatus)
 		_, err = apiClient.Catalog().Register(serviceRegistration, nil)
 		if err != nil {
 			r.Log.Error(err, "failed to register service", "name", serviceRegistration.Service.Service)
@@ -319,7 +319,7 @@ func (r *Controller) registerServicesAndHealthCheck(apiClient *api.Client, pod c
 		}
 
 		// Register the proxy service instance with Consul.
-		r.Log.Info("registering proxy service with Consul", "name", proxyServiceRegistration.Service.Service, "id", proxyServiceRegistration.Service.ID)
+		r.Log.Info("registering proxy service with Consul", "name", proxyServiceRegistration.Service.Service, "id", proxyServiceRegistration.Service.ID, "health", healthStatus)
 		_, err = apiClient.Catalog().Register(proxyServiceRegistration, nil)
 		if err != nil {
 			r.Log.Error(err, "failed to register proxy service", "name", proxyServiceRegistration.Service.Service)