Add support for AadApplication and SharepointOnline in resource azuread_access_package_resource_package_association

[jsfr]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The previous work to implement adding resources to access packages only supported groups (though this isn't mentioned anywhere).

The change to allow both applications and Sharepoint Online though aren't massive, and largely require allowing different IDs as the origin ID.

This PR aims to allow for these two as well, by allowing the access_type to also be a UUID (ID format for app roles) or a URL (seemingly the ID for Sharepoint Online).

Currently, this is a breaking change as it changes the access_type to be required. If we really want this could be avoided, but would mean we keep it defaulting to a value of "Member" which only makes sense for groups.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

Resources changed

• azuread_access_package_resource_package_association - support for Applications and SharePointOnline, change field access_type to be required and accept UUIDs and URLs.

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #1066

[jsfr]

What is missing for this to receive a review? I'd love to move forward with it, and I'm happy to do the work that might be necessary :D

[ramorous]

Have encountered this exact issue now and would love to see this implemented. We're trying to add an application resource to the access package but have to do this manually for about 50 or so access packages.

[ZerimArvinn]

Please review - need to be able to create applications and sharepoint sites to our access packages

[LaurentCusimano]

@jsfr @jackofallops any updates on this?
Looks like to this day it is still impossible to manage AAD apps / app roles within Access packages with the provider... Bummer :/

[jsfr]

@LaurentCusimano It is :( I gave up on this PR after getting absolutely no feedback on it for months.

[jsfr]

@LaurentCusimano and others I'm giving it another go here #1782 please upvote and help with poking the maintainers.