Commit a4cc487
perf(json): reuse pooled buffer for JSON deserialization
DefaultJSONSerializer.Deserialize used json.NewDecoder(body).Decode(),
which allocates a decoder and its internal read buffer on every JSON
request. Read the body into a capped pooled buffer and decode with
json.Unmarshal instead; Unmarshal does not retain the input slice, so the
buffer is safe to reuse. The pool drops oversized buffers (>64 KiB) so a
large body cannot pin memory.
BenchmarkBind_JSON: 1008 B -> 312 B/op (-69%), 9 -> 7 allocs, ~12% faster.
Behavioral note: json.Unmarshal is stricter than Decode — it rejects
trailing data after the JSON value and reports "unexpected end of JSON
input" for truncated bodies (both still 400 Bad Request). Two bind tests
asserting the old "unexpected EOF" message are updated to match.
Also add a general ServeHTTP/JSON benchmark suite (perf_bench_test.go):
BenchmarkBind_JSON now builds the request once and resets a reusable body
instead of calling httptest.NewRequest inside the loop (which dominated
the old measurement), plus BenchmarkJSONSerialize/Deserialize and the
routing benchmarks used to measure both this and the companion router PR.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 78c3d95 commit a4cc487
3 files changed
Lines changed: 95 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
834 | 834 | | |
835 | 835 | | |
836 | 836 | | |
837 | | - | |
| 837 | + | |
838 | 838 | | |
839 | 839 | | |
840 | 840 | | |
| |||
1004 | 1004 | | |
1005 | 1005 | | |
1006 | 1006 | | |
1007 | | - | |
| 1007 | + | |
1008 | 1008 | | |
1009 | 1009 | | |
1010 | 1010 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
13 | 26 | | |
14 | 27 | | |
15 | 28 | | |
| |||
21 | 34 | | |
22 | 35 | | |
23 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
24 | 47 | | |
25 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
26 | 60 | | |
27 | 61 | | |
28 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
114 | 122 | | |
115 | 123 | | |
116 | 124 | | |
117 | 125 | | |
118 | 126 | | |
119 | 127 | | |
120 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
121 | 136 | | |
122 | 137 | | |
123 | | - | |
124 | 138 | | |
125 | 139 | | |
126 | | - | |
127 | | - | |
| 140 | + | |
128 | 141 | | |
129 | 142 | | |
130 | 143 | | |
131 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
132 | 187 | | |
133 | 188 | | |
134 | 189 | | |
| |||
0 commit comments