Fix E2E test flakiness in auth and team suites

- Run microsoft-auth.spec.ts serially so the Admin Settings and Login
  Page suites can't race on shared global system settings under
  fullyParallel
- Wait for seeded values before editing the team settings form and
  retry the edit until both inputs stick, avoiding a late re-render
  silently dropping typed input

Author: marcoshack

test/e2e/tests/admin/microsoft-auth.spec.ts

@@ -2,6 +2,15 @@ import { test as base, expect } from '../../lib/fixtures';
 import { getAdminToken } from '../../lib/fixtures';
 import * as api from '../../lib/api';
 
+// The "Admin Settings" and "Login Page" suites below both mutate the same
+// global system settings (auth_microsoft_enabled and oauth_microsoft_config).
+// Each describe block is already serial internally, but with fullyParallel
+// the two blocks run concurrently on separate workers and stomp on each
+// other's global state — e.g. an Admin Settings test clears the OAuth config
+// while a Login Page test expects Microsoft enabled. Run the whole file
+// serially so the two suites can't race.
+base.describe.configure({ mode: 'serial' });
+
 // Admin-authenticated context for admin settings pages
 const adminTest = base.extend({
   storageState: async ({}, use) => {

test/e2e/tests/teams/team-crud.spec.ts

@@ -45,14 +45,22 @@ test.describe('Team CRUD', () => {
     // Navigate to settings tab
     await page.getByRole('button', { name: 'Settings', exact: true }).click();
 
-    // Update name and description
+    // The settings form is a controlled component whose inputs are seeded
+    // from the team API response. Wait for the original values to land
+    // before editing — otherwise a late re-render during initial page load
+    // can overwrite what we typed, silently dropping the new name.
     const nameInput = page.getByRole('textbox', { name: 'Name' });
-    await nameInput.clear();
-    await nameInput.fill('New Name');
-
     const descTextarea = page.locator('textarea');
-    await descTextarea.clear();
-    await descTextarea.fill('New description');
+    await expect(nameInput).toHaveValue('Old Name');
+    await expect(descTextarea).toHaveValue('Old description');
+
+    // Update name and description, retrying until both values stick.
+    await expect(async () => {
+      await nameInput.fill('New Name');
+      await descTextarea.fill('New description');
+      await expect(nameInput).toHaveValue('New Name', { timeout: 1000 });
+      await expect(descTextarea).toHaveValue('New description', { timeout: 1000 });
+    }).toPass({ timeout: 15000 });
 
     await page.getByRole('button', { name: 'Save', exact: true }).click();