Fido: Disable screen sign-in without local registration (#3459)

Avoid a crash, when the user clicks on screen sign-in

Author: p1gp1g

play-services-fido/core/src/main/kotlin/org/microg/gms/fido/core/ui/AuthenticatorActivity.kt

@@ -184,6 +184,10 @@ class AuthenticatorActivity : AppCompatActivity(), TransportHandlerCallback {
                 this.privilegedCallerName = callerName.takeIf { options is BrowserRequestOptions }
                 this.requiresPrivilege = requiresPrivilege
                 this.supportedTransports = transportHandlers.filter { it.isSupported }.map { it.transport }.toSet()
+                // To sign-in with screen-lock, there must be a local user.
+                if (options.type == RequestOptionsType.SIGN && noLocalUserForSignInstantBlock) {
+                    this.implementedTransports = this.implementedTransports.filter { it != SCREEN_LOCK }.toSet()
+                }
             }.arguments
             val next = if (requiresPrivilege) {
                 null

play-services-fido/core/src/main/kotlin/org/microg/gms/fido/core/ui/AuthenticatorActivityFragmentData.kt

@@ -22,8 +22,10 @@ class AuthenticatorActivityFragmentData(val arguments: Bundle = Bundle()) {
         get() = arguments.getStringArrayList(KEY_SUPPORTED_TRANSPORTS)?.map { Transport.valueOf(it) }?.toSet().orEmpty()
         set(value) = arguments.putStringArrayList(KEY_SUPPORTED_TRANSPORTS, ArrayList(value.map { it.name }))
 
-    val implementedTransports: Set<Transport>
-        get() = AuthenticatorActivity.IMPLEMENTED_TRANSPORTS
+    var implementedTransports: Set<Transport>
+        get() = arguments.getStringArrayList(KEY_IMPLEMENTED_TRANSPORTS)?.map { Transport.valueOf(it) }?.toSet()
+            ?: AuthenticatorActivity.IMPLEMENTED_TRANSPORTS
+        set(value) = arguments.putStringArrayList(KEY_IMPLEMENTED_TRANSPORTS, ArrayList(value.map { it.name }))
 
     var privilegedCallerName: String?
         get() = arguments.getString(KEY_PRIVILEGED_CALLER_NAME)
@@ -37,6 +39,7 @@ class AuthenticatorActivityFragmentData(val arguments: Bundle = Bundle()) {
         const val KEY_APP_NAME = "appName"
         const val KEY_IS_FIRST = "isFirst"
         const val KEY_SUPPORTED_TRANSPORTS = "supportedTransports"
+        const val KEY_IMPLEMENTED_TRANSPORTS = "implementedTransports"
         const val KEY_REQUIRES_PRIVILEGE = "requiresPrivilege"
         const val KEY_PRIVILEGED_CALLER_NAME = "privilegedCallerName"
     }