2994 Attribution and Claim Discussion

[opstic]

Opening this separately as the main issue thread has become quite noisy and to help move the process forward.

My PR set #3359, #3360, #3361 has been proven working both in my own testing and by @unpluggederan's thorough testing.

At this point, @unpluggederan has suggested that attribution/payment can be discussed separately from the remaining code review and polish.

From what @omarsoufiane told me, the platform process works through approval emails sent to bounty contributors when a claim is submitted.

Are there any concrete contributions people believe should be considered for this claim?

Mentioning relevant people:
@mar-v-in
@unpluggederan
@malsatin
@azhao12345
@omarsoufiane

Recording of my local test

recording.mp4

CI build for reference, please install as a system app and turn everything on.

This is intended as a bounty attribution thread, not a microG issue report.

[mar-v-in]

I haven't done any testing yet and also only glimpsed at the code, so I can't make any statement here. However, I am also not involved in the bug bounty and can't decide for others when the bounty should be paid.

[ale5000-git]

In every case, I think that after the code get merged and the functionality is working then the bounty contributors will accept the claim.

[opstic]

@ale5000-git

Yes, that is up to the bounty contributors to decide.

Sorry for opening a separate issue for this. I wanted to avoid adding more noise to the main RCS thread and keep the attribution discussion in one place.

@unpluggederan told me that from his perspective the current state of the implementation justifies discussing payment.
My understanding from his public comments in the original issue is that attribution should be clarified first so the bounty can be paid fairly.

So if there are contributions that should affect attribution for my PRs, they can be pointed out and discussed here.
If not, then hopefully this can make the bounty contributors' decision easier.

[ale5000-git]

If I'm not wrong bounties are usually paid after the PR is merged.
It doesn't prevent merging the code in the PR earlier (and get paid) when things are mostly working and then polishing the rest later in a separate PR.

But the way of doing things on the repo (excluding bounty contributors approval) is up to mar-v-in to decide.