fix(consensus): clean up intelephense warnings, force init re-prompt

- consensus.php: drop unused $baseTimeout param from synthesize() and
  analyze_differences() (and their call sites); remove deprecated
  curl_close() calls (no-op in PHP 8+).
- init skill: add explicit instruction that Step 5 runs on every
  /mots:init, including re-runs — previous behavior short-circuited
  with "already configured" and skipped the consensus re-check.

Author: Manish

bin/consensus.php

@@ -242,7 +242,6 @@ function fan_out(string $prompt, array $keys, int $timeout, ?string $logFile = n
         $curlError = $curlErrno !== CURLE_OK ? (curl_strerror($curlErrno) ?: curl_error($ch)) : curl_error($ch);
 
         curl_multi_remove_handle($mh, $ch);
-        curl_close($ch);
 
         if ($curlError !== '') {
             $reason = match ($curlErrno) {
@@ -314,7 +313,6 @@ function call_claude_judge(string $prompt, string $apiKey, string $model, int $t
     $raw       = curl_exec($ch);
     $httpCode  = (int) curl_getinfo($ch, CURLINFO_HTTP_CODE);
     $curlError = curl_error($ch);
-    curl_close($ch);
 
     if ($curlError !== '') {
         stderr("Judge cURL error: {$curlError}", $logFile);
@@ -332,7 +330,7 @@ function call_claude_judge(string $prompt, string $apiKey, string $model, int $t
 
 // ─── Synthesis ──────────────────────────────────────────────────────────────
 
-function synthesize(array $responses, string $originalPrompt, string $phaseName, string $judgeModel, string $anthropicKey, int $baseTimeout, ?string $logFile = null): ?string {
+function synthesize(array $responses, string $originalPrompt, string $phaseName, string $judgeModel, string $anthropicKey, ?string $logFile = null): ?string {
     $sections = build_response_sections($responses);
 
     $metaPrompt = <<<PROMPT
@@ -393,7 +391,7 @@ function synthesize(array $responses, string $originalPrompt, string $phaseName,
 
 // ─── Differences analysis ───────────────────────────────────────────────────
 
-function analyze_differences(array $responses, string $originalPrompt, string $judgeModel, string $anthropicKey, int $baseTimeout, ?string $logFile = null): ?string {
+function analyze_differences(array $responses, string $originalPrompt, string $judgeModel, string $anthropicKey, ?string $logFile = null): ?string {
     $succeeded = array_filter($responses, fn($r) => $r !== null);
     if (count($succeeded) < 2) {
         stderr('Need at least 2 responses to analyze differences.', $logFile);
@@ -624,7 +622,6 @@ function main(array $argv): int {
         $phase,
         $judgeModel,
         $keys['ANTHROPIC_API_KEY'] ?? '',
-        $fanoutTimeout,
         $logFile
     );
 
@@ -645,7 +642,6 @@ function main(array $argv): int {
         $prompt,
         $judgeModel,
         $keys['ANTHROPIC_API_KEY'] ?? '',
-        $fanoutTimeout,
         $logFile
     );
 

skills/init/SKILL.md

@@ -27,6 +27,8 @@ Set up motspilot in the current project directory.
 
 5. **Set up consensus (interactive — must block and wait):**
 
+   This step runs on EVERY `/mots:init`, including re-runs on an already-configured project. Do NOT short-circuit with "config is already configured, nothing to do" — the whole point of re-running `/mots:init` is usually that the user just added keys and wants consensus enabled. Always perform the checks below, always re-evaluate `CONSENSUS`, and always prompt via `AskUserQuestion` when keys are missing.
+
    Check if consensus can run:
    - Run `php --version` — is PHP 8.0+ available?
    - Check process env for `$ANTHROPIC_API_KEY`, `$OPENAI_API_KEY`, `$GEMINI_API_KEY`.