Skip to content

Commit ab8f14d

Browse files
committed
update defaults in cgroups conf
1 parent 035d75a commit ab8f14d

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

internal/render/common/configmap.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,8 @@ func addSlurmConfigProperties(res *renderutils.PropertiesConfig, config interfac
361361
func generateCGroupConfig(cluster *values.SlurmCluster) renderutils.ConfigFile {
362362
res := &renderutils.PropertiesConfig{}
363363
res.AddProperty("CgroupMountpoint", "/sys/fs/cgroup")
364-
res.AddProperty("ConstrainCores", "yes")
365-
res.AddProperty("ConstrainDevices", "yes")
364+
res.AddProperty("ConstrainCores", "no")
365+
res.AddProperty("ConstrainDevices", "no")
366366
res.AddProperty("ConstrainRAMSpace", "yes")
367367
switch cluster.NodeWorker.CgroupVersion {
368368
case consts.CGroupV1:

internal/render/common/configmap_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ func Test_GenerateCGroupConfig(t *testing.T) {
2727
}
2828
resV2 := generateCGroupConfig(clusterV2)
2929
expectedV2 := `CgroupMountpoint=/sys/fs/cgroup
30-
ConstrainCores=yes
31-
ConstrainDevices=yes
30+
ConstrainCores=no
31+
ConstrainDevices=no
3232
ConstrainRAMSpace=yes
3333
CgroupPlugin=cgroup/v2
3434
ConstrainSwapSpace=no
@@ -41,8 +41,8 @@ IgnoreSystemd=yes`
4141
},
4242
}
4343
expectedV1 := `CgroupMountpoint=/sys/fs/cgroup
44-
ConstrainCores=yes
45-
ConstrainDevices=yes
44+
ConstrainCores=no
45+
ConstrainDevices=no
4646
ConstrainRAMSpace=yes
4747
CgroupPlugin=cgroup/v1
4848
ConstrainSwapSpace=yes`

0 commit comments

Comments
 (0)