From ab8f14d18f4d05870c71c652142d6d9259f478c2 Mon Sep 17 00:00:00 2001 From: Dzmitry Amialiusik Date: Tue, 20 Jan 2026 14:57:20 +0100 Subject: [PATCH 1/5] update defaults in cgroups conf --- internal/render/common/configmap.go | 4 ++-- internal/render/common/configmap_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/render/common/configmap.go b/internal/render/common/configmap.go index ba04e4492..0ac6acdb3 100644 --- a/internal/render/common/configmap.go +++ b/internal/render/common/configmap.go @@ -361,8 +361,8 @@ func addSlurmConfigProperties(res *renderutils.PropertiesConfig, config interfac func generateCGroupConfig(cluster *values.SlurmCluster) renderutils.ConfigFile { res := &renderutils.PropertiesConfig{} res.AddProperty("CgroupMountpoint", "/sys/fs/cgroup") - res.AddProperty("ConstrainCores", "yes") - res.AddProperty("ConstrainDevices", "yes") + res.AddProperty("ConstrainCores", "no") + res.AddProperty("ConstrainDevices", "no") res.AddProperty("ConstrainRAMSpace", "yes") switch cluster.NodeWorker.CgroupVersion { case consts.CGroupV1: diff --git a/internal/render/common/configmap_test.go b/internal/render/common/configmap_test.go index cdaec8174..140e96fc2 100644 --- a/internal/render/common/configmap_test.go +++ b/internal/render/common/configmap_test.go @@ -27,8 +27,8 @@ func Test_GenerateCGroupConfig(t *testing.T) { } resV2 := generateCGroupConfig(clusterV2) expectedV2 := `CgroupMountpoint=/sys/fs/cgroup -ConstrainCores=yes -ConstrainDevices=yes +ConstrainCores=no +ConstrainDevices=no ConstrainRAMSpace=yes CgroupPlugin=cgroup/v2 ConstrainSwapSpace=no @@ -41,8 +41,8 @@ IgnoreSystemd=yes` }, } expectedV1 := `CgroupMountpoint=/sys/fs/cgroup -ConstrainCores=yes -ConstrainDevices=yes +ConstrainCores=no +ConstrainDevices=no ConstrainRAMSpace=yes CgroupPlugin=cgroup/v1 ConstrainSwapSpace=yes` From a6cad0f2d422f108d70f655840556461b99a6dd0 Mon Sep 17 00:00:00 2001 From: Dzmitry Amialiusik Date: Tue, 24 Mar 2026 21:15:40 +0100 Subject: [PATCH 2/5] increase liveness probe timeouts --- internal/render/controller/container.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/render/controller/container.go b/internal/render/controller/container.go index a7318d104..ad990b9f0 100644 --- a/internal/render/controller/container.go +++ b/internal/render/controller/container.go @@ -54,10 +54,10 @@ func renderContainerSlurmctld(container *values.Container, customMounts []slurmv }, }, InitialDelaySeconds: common.DefaultProbeInitialDelaySeconds, - TimeoutSeconds: common.DefaultProbeTimeoutSeconds, + TimeoutSeconds: 5, PeriodSeconds: common.DefaultProbePeriodSeconds, SuccessThreshold: common.DefaultProbeSuccessThreshold, - FailureThreshold: common.DefaultProbeFailureThreshold, + FailureThreshold: 5, }, TerminationMessagePath: corev1.TerminationMessagePathDefault, TerminationMessagePolicy: corev1.TerminationMessageReadFile, From dada406ad369a0f527f9b16d6d3284bd222e519c Mon Sep 17 00:00:00 2001 From: Dzmitry Amialiusik Date: Mon, 30 Mar 2026 15:16:08 +0200 Subject: [PATCH 3/5] increase liveness probe --- internal/render/controller/container.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/render/controller/container.go b/internal/render/controller/container.go index ad990b9f0..6e2b8b05d 100644 --- a/internal/render/controller/container.go +++ b/internal/render/controller/container.go @@ -54,8 +54,8 @@ func renderContainerSlurmctld(container *values.Container, customMounts []slurmv }, }, InitialDelaySeconds: common.DefaultProbeInitialDelaySeconds, - TimeoutSeconds: 5, - PeriodSeconds: common.DefaultProbePeriodSeconds, + TimeoutSeconds: 15, + PeriodSeconds: 20, SuccessThreshold: common.DefaultProbeSuccessThreshold, FailureThreshold: 5, }, From d7e12ba04b3bb65ccaab6b3e6728adac23582b4f Mon Sep 17 00:00:00 2001 From: Uburro Date: Tue, 14 Apr 2026 11:54:10 +0200 Subject: [PATCH 4/5] one more fix --- internal/render/controller/container.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/render/controller/container.go b/internal/render/controller/container.go index 6e2b8b05d..5b99fbd10 100644 --- a/internal/render/controller/container.go +++ b/internal/render/controller/container.go @@ -54,8 +54,8 @@ func renderContainerSlurmctld(container *values.Container, customMounts []slurmv }, }, InitialDelaySeconds: common.DefaultProbeInitialDelaySeconds, - TimeoutSeconds: 15, - PeriodSeconds: 20, + TimeoutSeconds: 60, + PeriodSeconds: 70, SuccessThreshold: common.DefaultProbeSuccessThreshold, FailureThreshold: 5, }, From 25e818b30814dd1b9a5c104005c973a8b955394d Mon Sep 17 00:00:00 2001 From: Uburro Date: Tue, 14 Apr 2026 11:59:38 +0200 Subject: [PATCH 5/5] fix --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 69e678c83..d5271d97e 100644 --- a/Makefile +++ b/Makefile @@ -593,7 +593,7 @@ $(CONTROLLER_GEN): $(LOCALBIN) .PHONY: envtest envtest: $(ENVTEST) ## Download setup-envtest locally if necessary. $(ENVTEST): $(LOCALBIN) - test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest + test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.22 .PHONY: golangci-lint golangci-lint: $(GOLANGCI_LINT) ## Download golangci-lint locally if necessary.