From 87007a124217ce74e3477bb1f4edb70877486179 Mon Sep 17 00:00:00 2001 From: Todd Chamberlain Date: Tue, 24 Mar 2026 15:08:52 -0500 Subject: [PATCH 1/2] Add procMount to nodesets Helm template The NodeSet CRD supports procMount (added in #1980) and the operator renders it in the StatefulSet, but the nodesets Helm template does not pass it through. This prevents Helm-based deployments from setting procMount without manually patching the rendered CR. --- helm/nodesets/templates/nodeset.yaml | 3 +++ helm/nodesets/values.yaml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/helm/nodesets/templates/nodeset.yaml b/helm/nodesets/templates/nodeset.yaml index b5d34d7a3..a9e04f7bb 100644 --- a/helm/nodesets/templates/nodeset.yaml +++ b/helm/nodesets/templates/nodeset.yaml @@ -134,6 +134,9 @@ spec: security: limitsConfig: {{ get (.security | default dict) "limitsConfig" | quote }} appArmorProfile: {{ get (.security | default dict) "appArmorProfile" | default "unconfined" | quote }} + {{- with (get (.security | default dict) "procMount") }} + procMount: {{ . | quote }} + {{- end }} {{- end }} {{- with (required ".Values.nodesets[*].munge is required." .munge) }} diff --git a/helm/nodesets/values.yaml b/helm/nodesets/values.yaml index b43e1e061..fe479fd24 100644 --- a/helm/nodesets/values.yaml +++ b/helm/nodesets/values.yaml @@ -171,6 +171,9 @@ nodesets: # Optional, defaults to empty string # e.g. `* soft nofile 1024` limitsConfig: "" + # Proc mount type for the slurmd container + # Optional, valid values: "Default", "Unmasked" + # procMount: "" # Munge configuration munge: # Each particular NodeSet's containers can have images other than default ones From d508f8f50547e15f96438ef39511966836e80ec5 Mon Sep 17 00:00:00 2001 From: Todd Chamberlain Date: Wed, 25 Mar 2026 11:02:58 -0500 Subject: [PATCH 2/2] Address review feedback: fix example value, add munge procMount --- helm/nodesets/templates/nodeset.yaml | 3 +++ helm/nodesets/values.yaml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/helm/nodesets/templates/nodeset.yaml b/helm/nodesets/templates/nodeset.yaml index a9e04f7bb..76748d8a0 100644 --- a/helm/nodesets/templates/nodeset.yaml +++ b/helm/nodesets/templates/nodeset.yaml @@ -173,6 +173,9 @@ spec: security: limitsConfig: {{ get (.security | default dict) "limitsConfig" | quote }} appArmorProfile: {{ get (.security | default dict) "appArmorProfile" | default "unconfined" | quote }} + {{- with (get (.security | default dict) "procMount") }} + procMount: {{ . | quote }} + {{- end }} {{- end }} {{- $sssd := (.sssd | default dict) }} diff --git a/helm/nodesets/values.yaml b/helm/nodesets/values.yaml index fe479fd24..dc4f7c49c 100644 --- a/helm/nodesets/values.yaml +++ b/helm/nodesets/values.yaml @@ -173,7 +173,7 @@ nodesets: limitsConfig: "" # Proc mount type for the slurmd container # Optional, valid values: "Default", "Unmasked" - # procMount: "" + # procMount: "Default" # Munge configuration munge: # Each particular NodeSet's containers can have images other than default ones