Fix negative index risk when hashing Integer.MIN_VALUE (#487)

Author: caojiajun

camellia-admin/camellia-dashboard/src/main/java/com/netease/nim/camellia/dashboard/controller/AdminController.java

@@ -354,7 +354,7 @@ public WebResult mock(@RequestParam("tid") long tid,
             int bucketSize = shardingTable.getBucketSize();
             DefaultShardingFunc shardingFunc = new DefaultShardingFunc();
             int shardingCode = shardingFunc.shardingCode(key.getBytes(StandardCharsets.UTF_8));
-            int index = Math.abs(shardingCode) % bucketSize;
+            int index = (shardingCode == Integer.MIN_VALUE ? 0 : Math.abs(shardingCode)) % bucketSize;
             ResourceOperation resourceOperation = shardingTable.getResourceOperationMap().get(index);
             Object ret = ReadableResourceTableUtil.readableResourceOperation(resourceOperation);
             LogBean.get().addProps("ret", ret);

camellia-core/src/main/java/com/netease/nim/camellia/core/discovery/HashCamelliaServerSelector.java

@@ -27,7 +27,8 @@ public T pick(List<T> list, Object loadBalanceKey) {
             if (loadBalanceKey == null) {
                 index = ThreadLocalRandom.current().nextInt(list.size());
             } else {
-                index = Math.abs(loadBalanceKey.hashCode()) % list.size();
+                int hash = loadBalanceKey.hashCode();
+                index = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % list.size();
             }
             if (GlobalDiscoveryEnv.logInfoEnable) {
                 logger.info("pick server by hash, loadBalanceKey = {}, index = {}, list = {}", loadBalanceKey, index, list);

camellia-feign-client/camellia-feign/src/main/java/com/netease/nim/camellia/feign/GlobalCamelliaFeignEnv.java

@@ -140,7 +140,8 @@ public int selectLoadBalanceCode(Object loadBalanceKey) {
                 if (resourceList == null || resourceList.isEmpty()) {
                     return -1;
                 }
-                return Math.abs(loadBalanceKey.hashCode()) % resourceList.size();
+                int hash = loadBalanceKey.hashCode();
+                return (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % resourceList.size();
             }
             return -1;
         }

camellia-hot-key/camellia-hot-key-sdk/src/main/java/com/netease/nim/camellia/hot/key/sdk/netty/HotKeyClientHub.java

@@ -140,7 +140,8 @@ private HotKeyClient select0(String name, String key) {
             if (addrs == null || addrs.isEmpty()) {
                 return null;
             }
-            int index = Math.abs(key.hashCode()) % addrs.size();
+            int hash = key.hashCode();
+            int index = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % addrs.size();
             ServerNode addr = addrs.get(index);
             ConcurrentHashMap<ServerNode, HotKeyClientGroup> map = clientGroupMap.get(name);
             if (map == null || map.isEmpty()) {

camellia-id-gen/camellia-id-gen-core/src/main/java/com/netease/nim/camellia/id/gen/snowflake/RedisWorkerIdGen.java

@@ -57,7 +57,8 @@ public long genWorkerId(long maxWorkerId) {
         } catch (Exception e) {
             hostAddress = UUID.randomUUID().toString();
         }
-        long initialId = Math.abs(hostAddress.hashCode()) % (maxWorkerId + 1);
+        int hash = hostAddress.hashCode();
+        long initialId = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % (maxWorkerId + 1);
         long workerId = initialId;
         do {
             CamelliaRedisLock redisLock = CamelliaRedisLock.newLock(template, lockKey(workerId), lockExpireMillis, lockExpireMillis);
@@ -67,7 +68,7 @@ public long genWorkerId(long maxWorkerId) {
                 return workerId;
             }
             workerId++;
-            workerId = Math.abs(workerId) % (maxWorkerId + 1);
+            workerId = (workerId == Long.MIN_VALUE ? 0 : Math.abs(workerId)) % (maxWorkerId + 1);
         } while (workerId != initialId);
 
         throw new CamelliaIdGenException("workerId gen fail");

camellia-redis-proxy/camellia-redis-proxy-core/src/main/java/com/netease/nim/camellia/redis/proxy/cluster/ClusterModeCommandMoveInvoker.java

@@ -138,7 +138,8 @@ private boolean checkSlotInProxyNode(ProxyClusterSlotMap clusterSlotMap, ProxyNo
             if (slotCache != null && System.currentTimeMillis() - slotCache.updateTime <= cacheMillis) {
                 return slotCache.slots.contains(slot);
             }
-            int lockIndex = Math.abs(node.toString().hashCode()) % 32;
+            int hash = node.toString().hashCode();
+            int lockIndex = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % 32;
             ReentrantLock lock = lockArray[lockIndex];
             lock.lock();
             try {

camellia-redis-proxy/camellia-redis-proxy-core/src/main/java/com/netease/nim/camellia/redis/proxy/sentinel/DefaultSentinelModeProcessor.java

@@ -439,7 +439,8 @@ private ProxyNode selectOnlineNode(ChannelInfo channelInfo) {
                 id = UUID.randomUUID().toString();
             }
             int size = onlineNodes.size();
-            int index = Math.abs(id.hashCode()) % size;
+            int hash = id.hashCode();
+            int index = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % size;
             target = onlineNodes.get(index);
         } catch (Exception e) {
             try {

camellia-redis-proxy/camellia-redis-proxy-core/src/main/java/com/netease/nim/camellia/redis/proxy/upstream/sentinel/RedisSentinelClient.java

@@ -149,7 +149,8 @@ public void renew() {
     private void renew0() {
         try {
             if (!masterListenerList.isEmpty()) {
-                int index = Math.abs(renewIndex.getAndIncrement()) % masterListenerList.size();
+                int hash = renewIndex.getAndIncrement();
+                int index = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % masterListenerList.size();
                 RedisSentinelMasterListener masterListener = masterListenerList.get(index);
                 masterListener.renew();
             }

camellia-redis-proxy/camellia-redis-proxy-core/src/main/java/com/netease/nim/camellia/redis/proxy/upstream/sentinel/RedisSentinelSlavesClient.java

@@ -361,12 +361,14 @@ public void renew() {
     private void renew0() {
         try {
             if (!masterListenerList.isEmpty()) {
-                int index = Math.abs(masterRenewIndex.getAndIncrement()) % masterListenerList.size();
+                int hash = masterRenewIndex.getAndIncrement();
+                int index = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % masterListenerList.size();
                 RedisSentinelMasterListener masterListener = masterListenerList.get(index);
                 masterListener.renew();
             }
             if (!slavesListenerList.isEmpty()) {
-                int index = Math.abs(slaveRenewIndex.getAndIncrement()) % slavesListenerList.size();
+                int hash = slaveRenewIndex.getAndIncrement();
+                int index = (hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % slavesListenerList.size();
                 RedisSentinelSlavesListener slavesListener = slavesListenerList.get(index);
                 slavesListener.renew();
             }

camellia-redis-proxy/camellia-redis-proxy-extensions/camellia-redis-proxy-mq/camellia-redis-proxy-mq-kafka/src/main/java/com/netease/nim/camellia/redis/proxy/mq/kafka/KafkaProducerWrapper.java

@@ -42,7 +42,8 @@ public void start() {
     public void send(ProducerRecord<byte[], byte[]> record, MqPack mqPack) {
         if (!isValid()) return;
         byte[] key = record.key();
-        KafkaProducer<byte[], byte[]> producer = list.get(Math.abs(Arrays.hashCode(key)) % list.size());
+        int hash = Arrays.hashCode(key);
+        KafkaProducer<byte[], byte[]> producer = list.get((hash == Integer.MIN_VALUE ? 0 : Math.abs(hash)) % list.size());
         producer.send(record, (recordMetadata, e) -> {
             if (e != null) {
                 valid = false;