refactor: make spawnTest result runtime-agnostic

Replace the POSIX-specific signal field with an aborted boolean computed
by the Node implementor, moving the abort exit-code knowledge out of
portable tests and into child_process.js.

Author: bavulapati

implementors/node/child_process.d.ts

@@ -4,7 +4,7 @@ export interface SpawnTestOptions {
 
 export interface SpawnTestResult {
   status: number | null;
-  signal: NodeJS.Signals | null;
+  aborted: boolean;
   stdout: string;
   stderr: string;
 }

implementors/node/child_process.js

@@ -12,15 +12,24 @@ const HARNESS_MODULE_PATHS = [
   'child_process.js',
 ].map((file) => path.join(import.meta.dirname, file));
 
+// Exit codes that signify the runtime aborted (rather than exiting cleanly with
+// a non-zero status). On POSIX an abort surfaces as a fatal signal; on Windows
+// as one of a small set of exit codes. Mirrors Node.js's
+// `common.nodeProcessAborted`. The POSIX 128+N codes and the Windows NTSTATUS
+// codes share one list because the ranges don't overlap. Keeping this here, in
+// the Node implementor, lets portable tests ask "did it abort?" via the
+// `aborted` flag without encoding any runtime-specific process semantics.
+const ABORT_EXIT_CODES = [132, 133, 134, 139, 0xc0000409, 0xc000001d];
+
 /**
  * Runs a test file in a fresh Node.js subprocess with the CTS harness globals
- * pre-loaded, and returns its exit status, signal, and captured output.
+ * pre-loaded, and returns its exit status, whether it aborted, and output.
  *
  * @param {string} filePath - Path to the JS/MJS file to execute. Resolved
  *   against `options.cwd` if relative.
  * @param {{ cwd?: string }} [options]
  *   - `cwd`: working directory for the child; defaults to `process.cwd()`.
- * @returns {{ status: number | null, signal: NodeJS.Signals | null, stdout: string, stderr: string }}
+ * @returns {{ status: number | null, aborted: boolean, stdout: string, stderr: string }}
  */
 export const spawnTest = (filePath, options = {}) => {
   // --expose-gc is mandatory: gc.js (loaded below) throws at import without it.
@@ -37,7 +46,7 @@ export const spawnTest = (filePath, options = {}) => {
   if (result.error) throw result.error;
   return {
     status: result.status,
-    signal: result.signal,
+    aborted: result.signal !== null || ABORT_EXIT_CODES.includes(result.status),
     stderr: result.stderr?.toString() ?? '',
     stdout: result.stdout?.toString() ?? '',
   };

implementors/node/tests.ts

@@ -32,14 +32,14 @@ export function listDirectoryEntries(dir: string) {
 }
 
 export function runFileInSubprocess(cwd: string, filePath: string): void {
-  const { status, signal, stdout, stderr } = spawnTest(filePath, { cwd });
+  const { status, aborted, stdout, stderr } = spawnTest(filePath, { cwd });
 
   if (stdout) process.stdout.write(stdout);
 
   if (status === 0) return;
 
   const reason =
-    status !== null ? `exit code ${status}` : `signal ${signal ?? 'unknown'}`;
+    status !== null ? `exit code ${status}` : aborted ? 'aborted' : 'unknown';
   const trimmedStderr = stderr.trim();
   const stderrSuffix = trimmedStderr ?
     `\n--- stderr ---\n${trimmedStderr}\n--- end stderr ---` :

tests/harness/spawn-test.js

@@ -8,14 +8,16 @@ if (typeof spawnTest !== 'function') {
 {
   const result = spawnTest('spawn-test-ok-child.mjs');
   assert.strictEqual(result.status, 0, `ok child exited with status ${result.status}; stderr:\n${result.stderr}`);
-  assert.strictEqual(result.signal, null);
+  assert.strictEqual(result.aborted, false);
   assert.strictEqual(result.stderr, '');
 }
 
 // Failing child: non-zero status and stderr contains the thrown marker.
 {
   const result = spawnTest('spawn-test-fail-child.mjs');
   assert.notStrictEqual(result.status, 0, 'fail child should exit non-zero');
+  // A thrown error is a clean non-zero exit, not an abnormal termination.
+  assert.strictEqual(result.aborted, false);
   if (!result.stderr.includes('spawn-test-fail-marker')) {
     throw new Error(`Expected stderr to include the failure marker, got:\n${result.stderr}`);
   }
@@ -24,11 +26,12 @@ if (typeof spawnTest !== 'function') {
 // Result shape: all four fields are present.
 {
   const result = spawnTest('spawn-test-ok-child.mjs');
-  for (const key of ['status', 'signal', 'stdout', 'stderr']) {
+  for (const key of ['status', 'aborted', 'stdout', 'stderr']) {
     if (!(key in result)) {
       throw new Error(`Expected spawnTest result to have "${key}" field`);
     }
   }
+  assert.strictEqual(typeof result.aborted, 'boolean');
   assert.strictEqual(typeof result.stdout, 'string');
   assert.strictEqual(typeof result.stderr, 'string');
 }