Fix SAPI5 (#18473)

Fixup of #18352.
Summary of the issue:

When WASAPI is turned off, bookmark events are not handled properly.
Description of user facing changes:

Users might not notice that, because although the bookmarks are not handled in time, they are still processed at the end of the utterance.
Description of developer facing changes:

None
Description of development approach:

Code that handles the bookmark events when WASAPI is off is added.

Author: gexgd0419

source/synthDrivers/sapi5.py

@@ -202,11 +202,15 @@ def StartStream(self, streamNum: int, pos: int):
 
 	def Bookmark(self, streamNum: int, pos: int, bookmark: str, bookmarkId: int):
 		synth = self.synthRef()
-		if not synth.isSpeaking or not synth.player:
+		if not synth.isSpeaking:
 			return
-		# Bookmark event is raised before the audio after that point.
-		# Queue an IndexReached event at this point.
-		synth.player.feed(None, 0, lambda: self.onIndexReached(streamNum, bookmarkId))
+		if synth.player:
+			# Bookmark event is raised before the audio after that point.
+			# Queue an IndexReached event at this point.
+			synth.player.feed(None, 0, lambda: self.onIndexReached(streamNum, bookmarkId))
+		else:
+			# Bookmark notifications should be sent immediately when WASAPI is off.
+			self.onIndexReached(streamNum, bookmarkId)
 
 	def EndStream(self, streamNum: int, pos: int):
 		synth = self.synthRef()

user_docs/en/changes.md

@@ -39,6 +39,7 @@ There have also been a number of other fixes and improvements, including to mous
 * Unassigned commands have been added to open the NVDA settings dialog in the following categories: Vision, Windows OCR, Add-on Store and Advanced. (#18313, @CyrilleB79)
 * Introduced support for Windows 11 Voice Access, including reporting dictated text and microphone status from everywhere (requires NVDA to be installed). (#16862, #17384, @josephsl)
 * Support for the NLS eReader Zoomax braille display has been added. (#15863, @florin-trutiu)
+* A checkbox has been added in the speech settings to allow users to disable WASAPI for SAPI5 voices. (#18309, @gexgd0419)
 
 ### Changes