Merge pull request #482 from oasisprotocol/andrej/feature/rofl-build-check-image-fqdn

cmd/rofl/build: Check if service images contain FQDNs

Author: abukosek

.golangci.yml

@@ -81,6 +81,7 @@ linters-settings:
           - oras.land/oras-go/v2
           - github.com/wI2L/jsondiff
           - github.com/google/uuid
+          - golang.org/x/net/idna
   exhaustive:
     # Switch statements are to be considered exhaustive if a 'default' case is
     # present, even if all enum members aren't listed in the switch.

cmd/rofl/build/container.go

@@ -3,6 +3,9 @@ package build
 import (
 	"context"
 	"fmt"
+	"strings"
+
+	"golang.org/x/net/idna"
 
 	"github.com/compose-spec/compose-go/v2/cli"
 
@@ -33,10 +36,35 @@ func tdxBuildContainer(
 	if err != nil {
 		return fmt.Errorf("failed to set up compose options: %w", err)
 	}
-	_, err = options.LoadProject(context.Background())
+	proj, err := options.LoadProject(context.Background())
 	if err != nil {
 		fmt.Println(err)
-		return fmt.Errorf("pre-build compose validation failed")
+		return fmt.Errorf("compose file validation failed")
+	}
+
+	// Make sure that the image fields for all services contain a FQDN or it will cause
+	// Podman errors when trying to run it.
+	for serviceName, service := range proj.Services {
+		image := service.Image
+		validationFailedErr := fmt.Errorf("compose file validation failed: image '%s' of service '%s' is not a fully-qualified domain name", image, serviceName)
+
+		if !strings.Contains(image, "/") {
+			return validationFailedErr
+		}
+		s := strings.Split(image, "/")
+		if len(s[0]) == 0 || len(s[1]) == 0 {
+			return validationFailedErr
+		}
+
+		domain := s[0]
+		if !strings.Contains(domain, ".") {
+			return validationFailedErr
+		}
+
+		_, err := idna.Lookup.ToASCII(domain)
+		if err != nil {
+			return validationFailedErr
+		}
 	}
 
 	// Use the pre-built container runtime.

go.mod

@@ -36,6 +36,7 @@ require (
 	github.com/wI2L/jsondiff v0.7.0
 	github.com/zondax/ledger-go v1.0.0
 	golang.org/x/crypto v0.38.0
+	golang.org/x/net v0.38.0
 	golang.org/x/sys v0.33.0
 	golang.org/x/text v0.25.0
 	gopkg.in/yaml.v3 v3.0.1
@@ -158,7 +159,6 @@ require (
 	go.uber.org/multierr v1.11.0 // indirect
 	go.uber.org/zap v1.27.0 // indirect
 	golang.org/x/exp v0.0.0-20250128182459-e0ece0dbea4c // indirect
-	golang.org/x/net v0.38.0 // indirect
 	golang.org/x/sync v0.14.0 // indirect
 	golang.org/x/term v0.32.0 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20241223144023-3abc09e42ca8 // indirect