refactor: migrate ENABLE_LTI_PII_ACKNOWLEDGEMENT off FEATURES-as-dict

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: feanil

openedx/core/djangoapps/agreements/tests/test_views.py

@@ -4,9 +4,7 @@
 
 import json
 from datetime import datetime, timedelta
-from unittest.mock import patch
 
-from django.conf import settings
 from django.test import override_settings
 from django.urls import reverse
 from freezegun import freeze_time
@@ -226,7 +224,7 @@ def test_post_integrity_signature_no_waffle_flag(self):
 
 
 @skip_unless_lms
-@patch.dict(settings.FEATURES, {'ENABLE_LTI_PII_ACKNOWLEDGEMENT': True})
+@override_settings(ENABLE_LTI_PII_ACKNOWLEDGEMENT=True)
 class LTIPIISignatureSignatureViewTests(APITestCase, ModuleStoreTestCase):
     """
         Tests for the LTI PII Signature View
@@ -268,7 +266,7 @@ def _assert_response(self, response, expected_response, user=None, course_id=Non
             assert data['username'] == user.username
             assert data['course_id'] == course_id
 
-    @patch.dict(settings.FEATURES, {'ENABLE_LTI_PII_ACKNOWLEDGEMENT': False})
+    @override_settings(ENABLE_LTI_PII_ACKNOWLEDGEMENT=False)
     def test_enabled_lti_pii_signature(self):
         response = self.client.post(
             reverse(

openedx/core/djangoapps/agreements/views.py

@@ -155,7 +155,7 @@ def post(self, request, course_id):
                 created_at: "2021-04-23T18:25:43.511Z"
             }
         """
-        if not settings.FEATURES.get('ENABLE_LTI_PII_ACKNOWLEDGEMENT'):
+        if not getattr(settings, 'ENABLE_LTI_PII_ACKNOWLEDGEMENT', False):
             return Response(
                 status=status.HTTP_404_NOT_FOUND,
             )