From 80b43747f67d6a149e6afdc52bc5a447b0ea2891 Mon Sep 17 00:00:00 2001 From: Zane Bitter Date: Tue, 23 Jun 2026 18:05:48 +1200 Subject: [PATCH 1/2] Warn when diskSetup is set in ABI diskSetup was added to the install-config after the agent-based installation method was created, without being plumbed through or generating a warning that its value would be ignored. This field is valid for the vSphere platform, so warn the user that it is ignored if specified in an agent install. Assisted-by: Claude Code --- pkg/asset/agent/installconfig.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pkg/asset/agent/installconfig.go b/pkg/asset/agent/installconfig.go index 893dc47d78c..e1346d858cc 100644 --- a/pkg/asset/agent/installconfig.go +++ b/pkg/asset/agent/installconfig.go @@ -461,6 +461,11 @@ func warnUnusedConfig(installConfig *types.InstallConfig) { fieldPath := computePath.Child("platform") logrus.Warnf("%s is ignored", fieldPath) } + + if len(compute.DiskSetup) > 0 { + fieldPath := computePath.Child("diskSetup") + logrus.Warnf("%s is ignored", fieldPath) + } } if installConfig.ControlPlane.Hyperthreading != "Enabled" { @@ -473,6 +478,11 @@ func warnUnusedConfig(installConfig *types.InstallConfig) { logrus.Warnf("%s is ignored", fieldPath) } + if len(installConfig.ControlPlane.DiskSetup) > 0 { + fieldPath := field.NewPath("controlPlane", "diskSetup") + logrus.Warnf("%s is ignored", fieldPath) + } + switch installConfig.Platform.Name() { case baremetal.Name: From 17410e4ca74160108fd49aaab1ab5e2ec9bcaeca Mon Sep 17 00:00:00 2001 From: Zane Bitter Date: Tue, 23 Jun 2026 18:05:52 +1200 Subject: [PATCH 2/2] Warn when ovnKubernetesConfig is set in ABI networking.ovnKubernetesConfig was added to the install-config after the agent-based installation method was created, without being plumbed through to assisted-service or generating a warning that its value would be ignored. Assisted-by: Claude Code --- pkg/asset/agent/installconfig.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkg/asset/agent/installconfig.go b/pkg/asset/agent/installconfig.go index e1346d858cc..513eee98e54 100644 --- a/pkg/asset/agent/installconfig.go +++ b/pkg/asset/agent/installconfig.go @@ -581,6 +581,14 @@ func warnUnusedConfig(installConfig *types.InstallConfig) { } } + if installConfig.Networking != nil && + installConfig.Networking.OVNKubernetesConfig != nil && + installConfig.Networking.OVNKubernetesConfig.IPv4 != nil && + installConfig.Networking.OVNKubernetesConfig.IPv4.InternalJoinSubnet != nil { + fieldPath := field.NewPath("networking", "ovnKubernetesConfig", "ipv4", "internalJoinSubnet") + logrus.Warnf("%s: %s is ignored", fieldPath, installConfig.Networking.OVNKubernetesConfig.IPv4.InternalJoinSubnet) + } + // "External" is the default set from generic install config code if installConfig.Publish != "External" { fieldPath := field.NewPath("publish")