fix(dashboard): posix-normalize workspace_symbol_search result path

paul-basanets · claude · pavlo-basanets-epam · commit 631d6ade5cc3 · 2026-06-08T11:20:50.000+03:00
_workspace_match built the returned match path with
str(Path(file_path).relative_to(root)), which yields backslash
separators on Windows. The existing test only asserts the response
shape, not the separator, so Windows CI didn't catch it.

Normalize with .replace(os.sep, "/"), matching the sibling /code/*
fixes. No-op on posix.

Co-Authored-By: Claude Opus 4.8 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/dashboard/src/components/overview/Timeline.svelte b/dashboard/src/components/overview/Timeline.svelte
@@ -187,6 +187,9 @@
     gap: var(--space-2);
   }
   .ctrl {
+    display: inline-flex;
+    align-items: center;
+    gap: var(--space-1);
     background: transparent;
     border: 1px solid var(--border);
     color: var(--text-primary);
@@ -205,6 +208,9 @@
     margin-bottom: var(--space-2);
   }
   .chip {
+    display: inline-flex;
+    align-items: center;
+    gap: var(--space-1);
     background: transparent;
     border: 1px solid var(--border);
     color: var(--text-muted);
diff --git a/dashboard/src/components/overview/TimelineRow.svelte b/dashboard/src/components/overview/TimelineRow.svelte
@@ -167,9 +167,6 @@
               {showFullInput ? 'Show less' : 'Show full'}
             </button>
           {/if}
-          {#if record.input_truncated}
-            <div class="note">(server-truncated at 8 KB)</div>
-          {/if}
         </div>
         <div class="block">
           <div class="block-head">
@@ -192,9 +189,6 @@
               {showFullOutput ? 'Show less' : 'Show full'}
             </button>
           {/if}
-          {#if record.output_truncated}
-            <div class="note">(server-truncated at 8 KB)</div>
-          {/if}
         </div>
       </div>
     {:else}
@@ -391,10 +385,6 @@
     cursor: pointer;
     padding: 0;
   }
-  .note {
-    color: var(--text-muted);
-    font-size: 0.85em;
-  }
   .err {
     color: var(--log-error);
   }
diff --git a/dashboard/src/lib/api/types.ts b/dashboard/src/lib/api/types.ts
@@ -156,8 +156,6 @@ export interface ToolCallRecord {
   error_message: string | null;
   input_preview: string;
   output_preview: string;
-  input_truncated: boolean;
-  output_truncated: boolean;
   input_tokens: number;
   output_tokens: number;
 }
diff --git a/dashboard/tests/charts.test.ts b/dashboard/tests/charts.test.ts
@@ -127,8 +127,6 @@ function rec(started_at: number, tool = 't'): ToolCallRecord {
     error_message: null,
     input_preview: '',
     output_preview: '',
-    input_truncated: false,
-    output_truncated: false,
     input_tokens: 0,
     output_tokens: 0,
   };
diff --git a/dashboard/tests/timeline-row.test.ts b/dashboard/tests/timeline-row.test.ts
@@ -14,8 +14,6 @@ function historyRow(over: Partial<ToolCallRecord> = {}): TimelineDisplayRow {
     error_message: null,
     input_preview: "{'relative_path': 'src/foo.py', 'flag': True}",
     output_preview: 'file contents here',
-    input_truncated: false,
-    output_truncated: false,
     input_tokens: 1234,
     output_tokens: 340,
     ...over,
diff --git a/dashboard/tests/timeline-rows.test.ts b/dashboard/tests/timeline-rows.test.ts
@@ -12,8 +12,6 @@ function rec(seq: number, tool: string, started_at: number, success = true): Too
     error_message: null,
     input_preview: '',
     output_preview: '',
-    input_truncated: false,
-    output_truncated: false,
     input_tokens: 0,
     output_tokens: 0,
   };
diff --git a/dashboard/tests/timeline-store.test.ts b/dashboard/tests/timeline-store.test.ts
@@ -15,8 +15,6 @@ function record(seq: number, tool = 't'): ToolCallRecord {
     error_message: null,
     input_preview: '',
     output_preview: '',
-    input_truncated: false,
-    output_truncated: false,
     input_tokens: 0,
     output_tokens: 0,
   };
@@ -57,8 +55,6 @@ describe('timeline store', () => {
                 error_message: null,
                 input_preview: '',
                 output_preview: '',
-                input_truncated: false,
-                output_truncated: false,
                 input_tokens: 0,
                 output_tokens: 0,
               },
diff --git a/dashboard/tests/timeline.test.ts b/dashboard/tests/timeline.test.ts
@@ -15,8 +15,6 @@ function rec(seq: number, tool = 'read_file', success = true): ToolCallRecord {
     error_message: success ? null : 'Err',
     input_preview: `in${seq}`,
     output_preview: `out${seq}`,
-    input_truncated: false,
-    output_truncated: false,
     input_tokens: seq * 10,
     output_tokens: seq * 20,
   };
diff --git a/src/serena/analytics.py b/src/serena/analytics.py
@@ -116,22 +116,9 @@ def load_estimator(self) -> TokenCountEstimator:
         return estimator_instance
 
 
-_INPUT_OUTPUT_PREVIEW_BYTES = 8 * 1024
 _RECORD_BUFFER_SIZE = 2000
 
 
-def _truncate_preview(text: str) -> tuple[str, bool]:
-    """
-    Truncate text so its UTF-8 byte length is at most _INPUT_OUTPUT_PREVIEW_BYTES.
-    Returns (possibly-truncated text, was_truncated).
-    """
-    encoded = text.encode("utf-8")
-    if len(encoded) <= _INPUT_OUTPUT_PREVIEW_BYTES:
-        return text, False
-    truncated = encoded[:_INPUT_OUTPUT_PREVIEW_BYTES].decode("utf-8", errors="ignore")
-    return truncated, True
-
-
 @dataclass(frozen=True)
 class ToolCallRecord:
     seq: int
@@ -142,8 +129,6 @@ class ToolCallRecord:
     error_message: str | None
     input_preview: str
     output_preview: str
-    input_truncated: bool
-    output_truncated: bool
     input_tokens: int
     output_tokens: int
 
@@ -226,8 +211,6 @@ def record_call(
         """
         input_tokens = self._estimate_token_count(input_str)
         output_tokens = self._estimate_token_count(output_str)
-        input_preview, input_truncated = _truncate_preview(input_str)
-        output_preview, output_truncated = _truncate_preview(output_str)
         with self._tool_stats_lock:
             self._seq_counter += 1
             seq = self._seq_counter
@@ -246,10 +229,8 @@ def record_call(
                     duration_ms=duration_ms,
                     success=success,
                     error_message=error_message,
-                    input_preview=input_preview,
-                    output_preview=output_preview,
-                    input_truncated=input_truncated,
-                    output_truncated=output_truncated,
+                    input_preview=input_str,
+                    output_preview=output_str,
                     input_tokens=input_tokens,
                     output_tokens=output_tokens,
                 )
diff --git a/src/serena/dashboard.py b/src/serena/dashboard.py
@@ -160,8 +160,6 @@ class ToolCallRecordResponse(BaseModel):
     error_message: str | None
     input_preview: str
     output_preview: str
-    input_truncated: bool
-    output_truncated: bool
     input_tokens: int
     output_tokens: int
 
@@ -342,8 +340,6 @@ def get_tool_call_timeline_route() -> tuple[dict[str, Any], int] | dict[str, Any
                         error_message=r.error_message,
                         input_preview=r.input_preview,
                         output_preview=r.output_preview,
-                        input_truncated=r.input_truncated,
-                        output_truncated=r.output_truncated,
                         input_tokens=r.input_tokens,
                         output_tokens=r.output_tokens,
                     )
diff --git a/src/serena/dashboard_code.py b/src/serena/dashboard_code.py
@@ -293,7 +293,7 @@ def _convert_workspace_match(m: Any, project_root_real: Path) -> _WorkspaceMatch
     rng = _maybe(location, "range") if location is not None else None
     file_path = unquote(urlparse(uri).path) if uri else ""
     try:
-        rel = str(Path(file_path).relative_to(project_root_real)) if file_path else ""
+        rel = str(Path(file_path).relative_to(project_root_real)).replace(os.sep, "/") if file_path else ""
     except Exception:
         rel = file_path
     return _WorkspaceMatch(
diff --git a/src/serena/resources/dashboard/assets/index-DdlKnK31.css b/src/serena/resources/dashboard/assets/index-DdlKnK31.css
diff --git a/src/serena/resources/dashboard/assets/index-ejjDEuVY.css b/src/serena/resources/dashboard/assets/index-ejjDEuVY.css
diff --git a/src/serena/resources/dashboard/assets/index-v30fI01O.js b/src/serena/resources/dashboard/assets/index-v30fI01O.js
diff --git a/src/serena/resources/dashboard/index.html b/src/serena/resources/dashboard/index.html
@@ -13,8 +13,8 @@
       href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&family=JetBrains+Mono:wght@400;500&display=swap"
       rel="stylesheet"
     />
-    <script type="module" crossorigin src="./assets/index-CmBw44Ie.js"></script>
-    <link rel="stylesheet" crossorigin href="./assets/index-ejjDEuVY.css">
+    <script type="module" crossorigin src="./assets/index-v30fI01O.js"></script>
+    <link rel="stylesheet" crossorigin href="./assets/index-DdlKnK31.css">
   </head>
   <body>
     <div id="app"></div>
diff --git a/test/serena/test_analytics.py b/test/serena/test_analytics.py
@@ -27,20 +27,27 @@ def test_entry_update_on_call_tracks_timing_and_errors():
     assert e.last_called_at == 1001.0
 
 
-from serena.analytics import _INPUT_OUTPUT_PREVIEW_BYTES, ToolCallRecord, _truncate_preview
+from serena.analytics import ToolCallRecord
 
 
-def test_truncate_preview_short_input_returns_as_is():
-    text, truncated = _truncate_preview("hello")
-    assert text == "hello"
-    assert truncated is False
-
-
-def test_truncate_preview_long_input_truncates_to_cap():
-    long = "x" * (_INPUT_OUTPUT_PREVIEW_BYTES + 1000)
-    text, truncated = _truncate_preview(long)
-    assert len(text.encode("utf-8")) <= _INPUT_OUTPUT_PREVIEW_BYTES
-    assert truncated is True
+def test_record_call_stores_input_and_output_in_full():
+    """Inputs and outputs are stored untruncated (the dashboard renders them in full)."""
+    stats = ToolUsageStats()
+    big_input = "i" * (64 * 1024)
+    big_output = "o" * (128 * 1024)
+    stats.record_call(
+        tool_name="read_file",
+        input_str=big_input,
+        output_str=big_output,
+        duration_ms=1.0,
+        success=True,
+        error_message=None,
+        now=1000.0,
+    )
+    records, _ = stats.get_records_since(since_seq=None, tool=None, limit=10)
+    assert len(records) == 1
+    assert records[0].input_preview == big_input
+    assert records[0].output_preview == big_output
 
 
 def test_tool_call_record_is_frozen():
@@ -53,8 +60,6 @@ def test_tool_call_record_is_frozen():
         error_message=None,
         input_preview="a",
         output_preview="b",
-        input_truncated=False,
-        output_truncated=False,
         input_tokens=3,
         output_tokens=4,
     )

Original file line number	Diff line number	Diff line change
`@@ -156,8 +156,6 @@ export interface ToolCallRecord {`
`156`	`156`	`error_message: string \| null;`
`157`	`157`	`input_preview: string;`
`158`	`158`	`output_preview: string;`
`159`		`- input_truncated: boolean;`
`160`		`- output_truncated: boolean;`
`161`	`159`	`input_tokens: number;`
`162`	`160`	`output_tokens: number;`
`163`	`161`	`}`