Skip to content

Commit 0ac638e

Browse files
jcelerierclaude
andcommitted
ci(wasm): build score-addon-puara on WebAssembly
The comment this removes was accurate when it was written: puara's standalone `find_package(Avendish)` could not resolve the in-tree copy when cross-compiling, because the Qt/emscripten toolchain leaves CMAKE_FIND_ROOT_PATH_MODE_PACKAGE at ONLY and re-roots every search path under the emscripten sysroot. 1f01f1f fixed that for every addon by writing the config into CMAKE_FIND_PACKAGE_REDIRECTS_DIR, which no root-path mode applies to, so the reason to exclude puara is gone. Nothing else broke: the addon configures and compiles for emscripten unmodified. Its 26 objects are value-domain processors -- gesture descriptors over accelerometer input (Jab/Shake/Tilt/Roll/Compass), biosignal features (Heart, Skin conductance, EDA, ERP, Power Band EEG) and statistics (PCA, Correlation, Clustering, Scaler, Normalizer, Smoother, VAMP) -- built on halp, Eigen and xtensor, all of which score already provides. No hardware, no sockets, no dlopen, so the browser takes the whole set. 118189852 -> 119171518 bytes raw (+0.94 MiB), 42334354 -> 42619697 gzipped (+0.28 MiB), measured with the CI flags. Verified at runtime, not just at link: in a deployed build driven from headless Chrome all 26 processes instantiate in a loaded document, where the same probe against the pre-change build finds 26/26 missing, and creating all 26 at once and starting playback leaves the module alive with nothing logged to the console. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oPj1zRcxSQX7FNni7EHM6
1 parent cd2742d commit 0ac638e

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

ci/common.deps.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,12 @@ clone_addon https://github.com/jcelerier/bendage
4646
clone_addon https://github.com/ossia/score-addon-airwindows
4747
clone_addon https://github.com/ossia/score-addon-cv
4848
clone_addon https://github.com/ossia/score-addon-onnx
49+
clone_addon https://github.com/ossia/score-addon-puara
4950

5051
CI_PLATFORM="${1:-DEFAULT}"
5152

5253
if [[ "$CI_PLATFORM" != "WASM" ]];
5354
then
54-
# puara does a standalone find_package(Avendish) that fails in the wasm build
55-
clone_addon https://github.com/ossia/score-addon-puara
5655
clone_addon https://github.com/ossia/score-addon-ble
5756
clone_addon https://github.com/ossia/score-addon-contextfree
5857
clone_addon https://github.com/ossia/score-addon-deuterium

0 commit comments

Comments
 (0)